Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to call connection callbacks in synchronous failure #16509

Closed
wants to merge 1 commit into from
Closed

Make sure to call connection callbacks in synchronous failure #16509

wants to merge 1 commit into from

Commits on Mar 21, 2022

  1. Make sure to call connection callbacks in synchronous failure 

    If OperationalDeviceProxy::Connect fails synchronously it does not call
pending failure callbacks except for the argument to the current call.

This leads to unanswered connection requests as FindOrEstablishSession
immediately calls ReleaseSession() after such a failure, which deletes
the proxy.
    @mspang
    mspang committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    1d0d4e0 View commit details
    Browse the repository at this point in the history