-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ephemeral ports for chip-tool by default. #16452
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-ephemeral-ports
Mar 21, 2022
Merged
Use ephemeral ports for chip-tool by default. #16452
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-ephemeral-ports
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
robszewczyk and
sagar-apple
March 18, 2022 17:49
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 18, 2022 17:49
andy31415
approved these changes
Mar 18, 2022
PR #16452: Size comparison from 472c351 to e7333fd Increases (1 build for linux)
Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
chip-tool-ephemeral-ports
branch
from
March 18, 2022 18:29
e7333fd
to
2aecfcb
Compare
PR #16452: Size comparison from bbc944c to 2aecfcb Increases (2 builds for linux)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool uses fixed port numbers.
Change overview
Stop doing that.
Testing
Verified that I can run two instances of chip-tool using the same fabric in parallel on the same laptop.