Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ephemeral ports for chip-tool by default. #16452

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Use ephemeral ports for chip-tool by default. #16452

merged 1 commit into from
Mar 21, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Mar 18, 2022 •
edited
Loading

Problem

chip-tool uses fixed port numbers.

Change overview

Stop doing that.

Testing

Verified that I can run two instances of chip-tool using the same fabric in parallel on the same laptop.

@restyled-io restyled-io bot mentioned this pull request Mar 18, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16452: Size comparison from 472c351 to e7333fd

Increases (1 build for linux)
platform target config section 472c351 e7333fd change % change
linux chip-tool-ipv6only arm64 (read only) 9768076 9768092 16 0.0
.text 8223092 8223108 16 0.0
Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 472c351 e7333fd change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603874 603874 0 0.0
.app_xip_area 510972 510972 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561654 561654 0 0.0
.app_xip_area 470280 470280 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571506 571506 0 0.0
.app_xip_area 470484 470484 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921992 921992 0 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 921984 921984 0 0.0
BRD4161A+rpc (read only) 950812 950812 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 950804 950804 0 0.0
window-app BRD4161A (read only) 852296 852296 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 852288 852288 0 0.0
k32w light k32w061+release (read/write) 701104 701104 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615780 615780 0 0.0
lock k32w061+release (read/write) 700964 700964 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615632 615632 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9768076 9768092 16 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8223092 8223108 16 0.0
thermostat-no-ble arm64 (read only) 2222724 2222724 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137988 137988 0 0.0
.text 1864672 1864672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353164 2353164 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315764 1315764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155763 1155763 0 0.0
bss 146724 146724 0 0.0
rodata 145892 145892 0 0.0
text 787992 787992 0 0.0
p6 all-clusters-app default (read/write) 2492496 2492496 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450760 1450760 0 0.0
light-app default (read/write) 2396080 2396080 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1354344 1354344 0 0.0
lock-app default (read/write) 2359624 2359624 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317888 1317888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 895702 895702 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633326 633326 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

PR #16452: Size comparison from bbc944c to 2aecfcb

Increases (2 builds for linux)
platform target config section bbc944c 2aecfcb change % change
linux chip-tool debug (read only) 10143941 10143973 32 0.0
.text 8843557 8843589 32 0.0
chip-tool-ipv6only arm64 (read only) 9768076 9768092 16 0.0
.text 8223092 8223108 16 0.0
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bbc944c 2aecfcb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603874 603874 0 0.0
.app_xip_area 510972 510972 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561654 561654 0 0.0
.app_xip_area 470280 470280 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571506 571506 0 0.0
.app_xip_area 470484 470484 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921992 921992 0 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 921984 921984 0 0.0
BRD4161A+rpc (read only) 950812 950812 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 950804 950804 0 0.0
window-app BRD4161A (read only) 852296 852296 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 852288 852288 0 0.0
k32w light k32w061+release (read/write) 701104 701104 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615780 615780 0 0.0
lock k32w061+release (read/write) 700964 700964 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615632 615632 0 0.0
linux all-clusters-app debug (read only) 2474673 2474673 0 0.0
(read/write) 146576 146576 0 0.0
.bss 60736 60736 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211237 211237 0 0.0
.text 2099986 2099986 0 0.0
bridge-app debug+rpc (read only) 1750973 1750973 0 0.0
(read/write) 92848 92848 0 0.0
.bss 47880 47880 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144236 144236 0 0.0
.text 1491525 1491525 0 0.0
chip-tool debug (read only) 10143941 10143973 32 0.0
(read/write) 358272 358272 0 0.0
.bss 25728 25728 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325408 325408 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 517781 517781 0 0.0
.text 8843557 8843589 32 0.0
chip-tool-ipv6only arm64 (read only) 9768076 9768092 16 0.0
(read/write) 476113 476113 0 0.0
.bss 44033 44033 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493620 493620 0 0.0
.text 8223092 8223108 16 0.0
door-lock-app debug (read only) 2002313 2002313 0 0.0
(read/write) 120256 120256 0 0.0
.bss 51008 51008 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180476 180476 0 0.0
.text 1672178 1672178 0 0.0
lighting-app debug+rpc (read only) 2133593 2133593 0 0.0
(read/write) 125544 125544 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 172732 172732 0 0.0
.text 1804178 1804178 0 0.0
ota-provider-app debug (read only) 1936801 1936801 0 0.0
(read/write) 116048 116048 0 0.0
.bss 50912 50912 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 165995 165995 0 0.0
.text 1619042 1619042 0 0.0
ota-requestor-app debug (read only) 1966809 1966809 0 0.0
(read/write) 119016 119016 0 0.0
.bss 51904 51904 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162244 162244 0 0.0
.text 1652578 1652578 0 0.0
shell debug (read only) 2424849 2424849 0 0.0
(read/write) 150632 150632 0 0.0
.bss 70664 70664 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209170 209170 0 0.0
.text 2058978 2058978 0 0.0
thermostat-no-ble arm64 (read only) 2222724 2222724 0 0.0
(read/write) 149809 149809 0 0.0
.bss 65713 65713 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 137988 137988 0 0.0
.text 1864672 1864672 0 0.0
tv-app debug (read only) 2675065 2675065 0 0.0
(read/write) 251136 251136 0 0.0
.bss 167808 167808 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206517 206517 0 0.0
.text 2293698 2293698 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353164 2353164 0 0.0
.bss 186644 186644 0 0.0
.data 5752 5752 0 0.0
.text 1315764 1315764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155763 1155763 0 0.0
bss 146724 146724 0 0.0
rodata 145892 145892 0 0.0
text 787992 787992 0 0.0
p6 all-clusters-app default (read/write) 2492496 2492496 0 0.0
.bss 120072 120072 0 0.0
.data 2632 2632 0 0.0
.text 1450760 1450760 0 0.0
light-app default (read/write) 2396080 2396080 0 0.0
.bss 113536 113536 0 0.0
.data 2488 2488 0 0.0
.text 1354344 1354344 0 0.0
lock-app default (read/write) 2359624 2359624 0 0.0
.bss 113280 113280 0 0.0
.data 2448 2448 0 0.0
.text 1317888 1317888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 895702 895702 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 633326 633326 0 0.0

@andy31415 andy31415 merged commit e93c9d6 into project-chip:master Mar 21, 2022
@bzbarsky-apple bzbarsky-apple deleted the chip-tool-ephemeral-ports branch March 21, 2022 14:36
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Use ephemeral ports for chip-tool by default. (project-chip#16452)
0be7512
@bzbarsky-apple bzbarsky-apple mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @andy31415