Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Retry a CASE session establishment after session tear down #16153

Merged
merged 1 commit into from
Mar 14, 2022
Merged

[OTA] Retry a CASE session establishment after session tear down #16153

merged 1 commit into from
Mar 14, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

When a CASE session has become invalid (session was previously established but the provider has rebooted and has no knowledge of this session), requestor would tear down the CASE session. The tear down is discovered on a subsequent query attempt. However, after the tear down, there is no attempt at another query.

Fixes: #16047

Change overview

  • After the CASE session tear down occurs, allow OTA Requestor to continue another attempt

Testing

  • Verified happy path transfer succeeds
  • Verified that when provider is rebooted, subsequent transfer succeeds after CASE tear down

@boring-cyborg boring-cyborg bot added the app label Mar 11, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

PR #16153: Size comparison from 5a28865 to b2318a4

Increases (6 builds for cyw30739, efr32, k32w, linux, nrfconnect)
platform target config section 5a28865 b2318a4 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 569962 570098 136 0.0
.app_xip_area 469012 469148 136 0.0
efr32 lighting-app BRD4161A (read only) 926304 926536 232 0.0
.text 926296 926528 232 0.0
BRD4161A+rpc (read only) 955092 955324 232 0.0
.text 955084 955316 232 0.0
k32w light k32w061+release (read/write) 699012 699220 208 0.0
.text 613756 613964 208 0.0
linux ota-requestor-app debug (read only) 1945377 1946961 1584 0.1
.rodata 160068 160164 96 0.1
.text 1634098 1635586 1488 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156171 1156399 228 0.0
rodata 145220 145288 68 0.0
text 789164 789324 160 0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 5a28865 b2318a4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602482 602482 0 0.0
.app_xip_area 509652 509652 0 0.0
.bss 75584 75584 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560342 560342 0 0.0
.app_xip_area 469040 469040 0 0.0
.bss 74088 74088 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 569962 570098 136 0.0
.app_xip_area 469012 469148 136 0.0
.bss 83392 83392 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926304 926536 232 0.0
(read/write) 128664 128664 0 0.0
.bss 126656 126656 0 0.0
.data 2008 2008 0 0.0
.text 926296 926528 232 0.0
BRD4161A+rpc (read only) 955092 955324 232 0.0
(read/write) 144620 144620 0 0.0
.bss 142432 142432 0 0.0
.data 2188 2188 0 0.0
.text 955084 955316 232 0.0
window-app BRD4161A (read only) 858776 858776 0 0.0
(read/write) 126640 126640 0 0.0
.bss 124776 124776 0 0.0
.data 1864 1864 0 0.0
.text 858768 858768 0 0.0
esp32 all-clusters-app c3devkit (read only) 961348 961348 0 0.0
(read/write) 1394994 1394994 0 0.0
.dram0.bss 64064 64064 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 961348 961348 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016947 1016947 0 0.0
(read/write) 462212 462212 0 0.0
.dram0.bss 69584 69584 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226776 226776 0 0.0
.flash.text 1011563 1011563 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699012 699220 208 0.0
.bss 77568 77568 0 0.0
.data 1888 1888 0 0.0
.text 613756 613964 208 0.0
lock k32w061+release (read/write) 699844 699844 0 0.0
.bss 77560 77560 0 0.0
.data 1908 1908 0 0.0
.text 614576 614576 0 0.0
linux all-clusters-app debug (read only) 2464625 2464625 0 0.0
(read/write) 146416 146416 0 0.0
.bss 60672 60672 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2090610 2090610 0 0.0
bridge-app debug+rpc (read only) 1749189 1749189 0 0.0
(read/write) 92944 92944 0 0.0
.bss 47784 47784 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38128 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143340 143340 0 0.0
.text 1490213 1490213 0 0.0
chip-tool debug (read only) 10094093 10094093 0 0.0
(read/write) 357680 357680 0 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324864 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514933 514933 0 0.0
.text 8797909 8797909 0 0.0
chip-tool-ipv6only arm64 (read only) 9727420 9727420 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492228 492228 0 0.0
.text 8185348 8185348 0 0.0
door-lock-app debug (read only) 1983809 1983809 0 0.0
(read/write) 119808 119808 0 0.0
.bss 50976 50976 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178428 178428 0 0.0
.text 1656402 1656402 0 0.0
lighting-app debug+rpc (read only) 2115385 2115385 0 0.0
(read/write) 125160 125160 0 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66408 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170972 170972 0 0.0
.text 1788418 1788418 0 0.0
ota-provider-app debug (read only) 1917121 1917121 0 0.0
(read/write) 115568 115568 0 0.0
.bss 50848 50848 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 163691 163691 0 0.0
.text 1602370 1602370 0 0.0
ota-requestor-app debug (read only) 1945377 1946961 1584 0.1
(read/write) 118568 118568 0 0.0
.bss 51872 51872 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59848 59848 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160068 160164 96 0.1
.text 1634098 1635586 1488 0.1
shell debug (read only) 2410433 2410433 0 0.0
(read/write) 150216 150216 0 0.0
.bss 70632 70632 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73088 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207442 207442 0 0.0
.text 2046754 2046754 0 0.0
thermostat-no-ble arm64 (read only) 2206596 2206596 0 0.0
(read/write) 149393 149393 0 0.0
.bss 65665 65665 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136804 136804 0 0.0
.text 1850480 1850480 0 0.0
tv-app debug (read only) 2655217 2655217 0 0.0
(read/write) 250808 250808 0 0.0
.bss 167872 167872 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204245 204245 0 0.0
.text 2276834 2276834 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156171 1156399 228 0.0
bss 146652 146652 0 0.0
rodata 145220 145288 68 0.0
text 789164 789324 160 0.0
p6 all-clusters-app default (read/write) 2500304 2500304 0 0.0
.bss 120088 120088 0 0.0
.data 2632 2632 0 0.0
.text 1458568 1458568 0 0.0
light-app default (read/write) 2404152 2404152 0 0.0
.bss 113552 113552 0 0.0
.data 2488 2488 0 0.0
.text 1362416 1362416 0 0.0
lock-app default (read/write) 2367696 2367696 0 0.0
.bss 113296 113296 0 0.0
.data 2448 2448 0 0.0
.text 1325960 1325960 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893842 893842 0 0.0
bss 87440 87440 0 0.0
noinit 37160 37160 0 0.0
text 631884 631884 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 13, 2022 •
edited
Loading

PR #16153: Size comparison from 2982c0c to ad22509

Increases (5 builds for cyw30739, efr32, k32w, nrfconnect)
platform target config section 2982c0c ad22509 change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570002 570154 152 0.0
.app_xip_area 469060 469212 152 0.0
efr32 lighting-app BRD4161A (read only) 918144 918380 236 0.0
.text 918136 918372 236 0.0
BRD4161A+rpc (read only) 946932 947184 252 0.0
(read/write) 144612 144616 4 0.0
.text 946924 947176 252 0.0
k32w light k32w061+release (read/write) 699052 699268 216 0.0
.text 613804 614020 216 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156219 1156455 236 0.0
rodata 145220 145296 76 0.1
text 789208 789372 164 0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2982c0c ad22509 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602530 602530 0 0.0
.app_xip_area 509708 509708 0 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560390 560390 0 0.0
.app_xip_area 469096 469096 0 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570002 570154 152 0.0
.app_xip_area 469060 469212 152 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 918144 918380 236 0.0
(read/write) 128656 128656 0 0.0
.bss 126648 126648 0 0.0
.data 2008 2008 0 0.0
.text 918136 918372 236 0.0
BRD4161A+rpc (read only) 946932 947184 252 0.0
(read/write) 144612 144616 4 0.0
.bss 142424 142424 0 0.0
.data 2188 2188 0 0.0
.text 946924 947176 252 0.0
window-app BRD4161A (read only) 850616 850616 0 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850608 850608 0 0.0
esp32 all-clusters-app c3devkit (read only) 961344 961344 0 0.0
(read/write) 1394994 1394994 0 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 961344 961344 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1016963 1016963 0 0.0
(read/write) 462204 462204 0 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226776 226776 0 0.0
.flash.text 1011579 1011579 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699052 699268 216 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 613804 614020 216 0.0
lock k32w061+release (read/write) 699884 699884 0 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614624 614624 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9727788 9727788 0 0.0
(read/write) 475425 475425 0 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371232 0 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492244 492244 0 0.0
.text 8185700 8185700 0 0.0
thermostat-no-ble arm64 (read only) 2206980 2206980 0 0.0
(read/write) 149377 149377 0 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136820 136820 0 0.0
.text 1850848 1850848 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352748 2352748 0 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315348 1315348 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156219 1156455 236 0.0
bss 146644 146644 0 0.0
rodata 145220 145296 76 0.1
text 789208 789372 164 0.0
p6 all-clusters-app default (read/write) 2492128 2492128 0 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450392 1450392 0 0.0
light-app default (read/write) 2395992 2395992 0 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354256 1354256 0 0.0
lock-app default (read/write) 2359536 2359536 0 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317800 1317800 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 893842 893842 0 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631882 631882 0 0.0

@andy31415 andy31415 merged commit d22a557 into project-chip:master Mar 14, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@carol-apple @andrei-menzopol
[OTA] Retry a CASE session establishment after session tear down (pro…
503eea8 
…ject-chip#16153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@isiu-apple isiu-apple isiu-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTA] Support for requestor retrying new CASE session when receiving timeout error
3 participants
@carol-apple @andy31415 @isiu-apple