-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a simple DetermineProviderLocation #15979
Merged
andy31415
merged 1 commit into
project-chip:master
from
harsha-rajendran:Implement-Determine-OTA-Provider-Location
Mar 9, 2022
Merged
Implement a simple DetermineProviderLocation #15979
andy31415
merged 1 commit into
project-chip:master
from
harsha-rajendran:Implement-Determine-OTA-Provider-Location
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02 and
msandstedt
March 8, 2022 20:19
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 8, 2022 20:19
harsha-rajendran
force-pushed
the
Implement-Determine-OTA-Provider-Location
branch
from
March 8, 2022 20:28
bffb7e7
to
62714f3
Compare
PR #15979: Size comparison from a69fde3 to 62714f3 Increases (6 builds for cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (4 builds for cyw30739, efr32, k32w)
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
isiu-apple
approved these changes
Mar 8, 2022
carol-apple
reviewed
Mar 9, 2022
carol-apple
reviewed
Mar 9, 2022
Damian-Nordic
approved these changes
Mar 9, 2022
selissia
approved these changes
Mar 9, 2022
carol-apple
reviewed
Mar 9, 2022
carol-apple
approved these changes
Mar 9, 2022
harsha-rajendran
force-pushed
the
Implement-Determine-OTA-Provider-Location
branch
from
March 9, 2022 18:08
1c2295a
to
643ec6c
Compare
Squashed commits and rebased. |
tcarmelveilleux
approved these changes
Mar 9, 2022
PR #15979: Size comparison from 4349e22 to 643ec6c Increases (6 builds for cyw30739, efr32, k32w, linux, nrfconnect)
Decreases (4 builds for cyw30739, efr32, k32w)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Provide a generic implementation for DetermineProviderLocation()
Change overview
It has been decided that a simple "iterate-through-the-list" approach would be the best path forward.
DetermineProviderLocation() iterates through the list of DefaultOTAProviders, finds the last-used-provider and returns the entry after it (cycles back to the start of the list). If no suitable candidate has been found, an error is returned.
Testing