[Android] Fix CHIPTool cluster cmds fail or app crashes (Issue #15637). #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
woody-apple
approved these changes
Mar 8, 2022
boring-cyborg
bot
added
config
documentation
andy31415
reviewed
Mar 8, 2022
andy31415
reviewed
Mar 8, 2022
andy31415
requested changes
Mar 8, 2022
There was a problem hiding this comment.
This PR looks like it contains changes from several other PRs and probably has more deltas than the 'fix cmd fail and app crashes' as the title describes.
I am unable to find what actual deltas exist: this is 91K added lines and 1.3K deleted lines and cannot be code reviewed.
Please update the patch.
Yes, I followed the guideline to contribute which included "rebase to master if it has changed since your changes" which is where all the extra came from. My change only affects 2 files. I'll see if I can update my PR it so it only shows my changes... Should be fixed now. The "Files changed" tab shows only 2 files and they just have my changes. Sorry about that, it's my first time contributing a PR. |
andy31415
approved these changes
Mar 8, 2022
Thanks! Added the checkmark, needs restyle update before merge. |
|
PR #15919: Size comparison from 2822511 to 6c76554 Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
Litome
force-pushed
the
Android_FixForIssue#15637
branch
2 times, most recently
from
8846dff to
7416324
Compare
bzbarsky-apple
approved these changes
Mar 9, 2022
|
@Litome The CLA machinery is not happy because the address in the commits does not match your github info, as far as I can tell. Sorry about the legal hurdles... |
|
PR #15919: Size comparison from 4349e22 to 1ac92ff Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Litome
force-pushed
the
Android_FixForIssue#15637
branch
from
1ac92ff to
1544b2b
Compare
@bzbarsky-apple I really don't know how to get past this. I've changed my GitHub settings so that my "Primary email address" is the same as my .gitconfig settings so it matches my commits and re-accepted / signed the CLA agreement but nothing seems to work. Any idea how to smooth this administrative hurdle? |
|
/rebase |
|
@woody-apple See the CLA question above? |
woody-apple
force-pushed
the
Android_FixForIssue#15637
branch
from
1544b2b to
7812a8a
Compare
|
PR #15919: Size comparison from c4d81c8 to 7812a8a Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ArekBalysNordic
pushed a commit
to ArekBalysNordic/connectedhomeip
that referenced
this pull request
Mar 18, 2022
…t-chip#15637). (project-chip#15919) * [Android] Fix CHIPTool cluster cmds fail or app crashes (Issue project-chip#15637). * [Android] Fix expression in verification instead of commenting out the verification. * Restyled by clang-format * [Android] Fix merge issue and revert un-necessary changes to verification expression Co-authored-by: Lisandre Taylor <lisandre.taylor@greenenergyoptions.co.uk> Co-authored-by: Restyled.io <commits@restyled.io>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…t-chip#15637). (project-chip#15919) * [Android] Fix CHIPTool cluster cmds fail or app crashes (Issue project-chip#15637). * [Android] Fix expression in verification instead of commenting out the verification. * Restyled by clang-format * [Android] Fix merge issue and revert un-necessary changes to verification expression Co-authored-by: Lisandre Taylor <lisandre.taylor@greenenergyoptions.co.uk> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
offset_bytes >= decodedLengthcheck ifoffset_bytesis zero.address != nullptrandport != 0when "PROVISIONING CHIP DEVICE WITH WI-FI" as the verification gets called multiple times during provisioning.Testing
How was this tested? (at least one bullet point required)