Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a memory leak in src/crypto/CHIPCryptoPALOpenSSL.cpp #15682

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix a memory leak in src/crypto/CHIPCryptoPALOpenSSL.cpp #15682

merged 1 commit into from
Mar 2, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

The EC_KEY is not freed.

Change overview

  • free it

@vivien-apple vivien-apple self-assigned this Mar 1, 2022
@boring-cyborg boring-cyborg bot added the crypto label Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

PR #15682: Size comparison from d2dffce to 2ec9620

Increases above 0.2%:

platform target config section d2dffce 2ec9620 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075687 36304 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700432 728788 28356 4.0
Increases (3 builds for linux, nrfconnect)
platform target config section d2dffce 2ec9620 change % change
linux chip-tool debug (read only) 8962485 8962501 16 0.0
.text 7877669 7877685 16 0.0
tv-app debug (read only) 2592169 2592185 16 0.0
.text 2219426 2219442 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075687 36304 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700432 728788 28356 4.0
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d2dffce 2ec9620 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599990 599990 0 0.0
.app_xip_area 504764 504764 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557978 557978 0 0.0
.app_xip_area 464288 464288 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578398 578398 0 0.0
.app_xip_area 475276 475276 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916916 916916 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 916908 916908 0 0.0
BRD4161A+rpc (read only) 947000 947000 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 946992 946992 0 0.0
lock-app BRD4161A+wf200 (read only) 986748 986748 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986740 986740 0 0.0
window-app BRD4161A (read only) 850844 850844 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850836 850836 0 0.0
esp32 all-clusters-app m5stack (read only) 1005099 1005099 0 0.0
(read/write) 458336 458336 0 0.0
.dram0.bss 68160 68160 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999715 999715 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692176 692176 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606900 606900 0 0.0
lock k32w061+release (read/write) 695536 695536 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610020 610020 0 0.0
linux all-clusters-app debug (read only) 2397185 2397185 0 0.0
(read/write) 144824 144824 0 0.0
.bss 59296 59296 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205029 205029 0 0.0
.text 2029314 2029314 0 0.0
bridge-app debug+rpc (read only) 1722765 1722765 0 0.0
(read/write) 92848 92848 0 0.0
.bss 47624 47624 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38104 38104 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1465237 1465237 0 0.0
chip-tool debug (read only) 8962485 8962501 16 0.0
(read/write) 282560 282560 0 0.0
.bss 25248 25248 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 250152 250152 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 478261 478261 0 0.0
.text 7877669 7877685 16 0.0
chip-tool-ipv6only arm64 (read only) 8723412 8723412 0 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405140 7405140 0 0.0
door-lock-app debug (read only) 1937913 1937913 0 0.0
(read/write) 119296 119296 0 0.0
.bss 50624 50624 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62232 62232 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173692 173692 0 0.0
.text 1615666 1615666 0 0.0
lighting-app debug+rpc (read only) 2073745 2073745 0 0.0
(read/write) 124656 124656 0 0.0
.bss 51552 51552 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66152 66152 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166460 166460 0 0.0
.text 1751762 1751762 0 0.0
ota-provider-app debug (read only) 1870017 1870017 0 0.0
(read/write) 114928 114928 0 0.0
.bss 50432 50432 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57512 57512 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158867 158867 0 0.0
.text 1560514 1560514 0 0.0
ota-requestor-app debug (read only) 1881025 1881025 0 0.0
(read/write) 116696 116696 0 0.0
.bss 51296 51296 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152612 152612 0 0.0
.text 1579506 1579506 0 0.0
shell debug (read only) 2365369 2365369 0 0.0
(read/write) 147272 147272 0 0.0
.bss 67616 67616 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204946 204946 0 0.0
.text 2003794 2003794 0 0.0
thermostat-no-ble arm64 (read only) 2164884 2164884 0 0.0
(read/write) 148657 148657 0 0.0
.bss 65329 65329 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75088 75088 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133124 133124 0 0.0
.text 1813440 1813440 0 0.0
tv-app debug (read only) 2592169 2592185 16 0.0
(read/write) 148760 148760 0 0.0
.bss 65888 65888 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73640 73640 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 198909 198909 0 0.0
.text 2219426 2219442 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350404 2350404 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313004 1313004 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039383 1075687 36304 3.5
bss 125820 127672 1852 1.5
rodata 135904 141808 5904 4.3
text 700432 728788 28356 4.0
p6 all-clusters-app default (read/write) 2488576 2488576 0 0.0
.bss 118728 118728 0 0.0
.data 2696 2696 0 0.0
.text 1446840 1446840 0 0.0
light-app default (read/write) 2395784 2395784 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354048 1354048 0 0.0
lock-app default (read/write) 2359312 2359312 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317576 1317576 0 0.0
qpg lighting-app qpg6105+debug (read only) 601576 601576 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596256 596256 0 0.0
lock-app qpg6105+debug (read only) 567292 567292 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 561972 561972 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883586 883586 0 0.0
bss 86400 86400 0 0.0
noinit 37160 37160 0 0.0
text 624368 624368 0 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the Leak_CHIPCryptoPALOpenSSL branch from 2ec9620 to e080d46 Compare March 2, 2022 06:17
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15682: Size comparison from cd44d83 to e080d46

Increases above 0.2%:

platform target config section cd44d83 e080d46 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
Increases (1 build for nrfconnect)
platform target config section cd44d83 e080d46 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cd44d83 e080d46 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600022 600022 0 0.0
.app_xip_area 504796 504796 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558010 558010 0 0.0
.app_xip_area 464320 464320 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578430 578430 0 0.0
.app_xip_area 475308 475308 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917012 917012 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917004 917004 0 0.0
BRD4161A+rpc (read only) 947096 947096 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947088 947088 0 0.0
lock-app BRD4161A+wf200 (read only) 986828 986828 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986820 986820 0 0.0
window-app BRD4161A (read only) 850940 850940 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850932 850932 0 0.0
esp32 all-clusters-app m5stack (read only) 1005191 1005191 0 0.0
(read/write) 458344 458344 0 0.0
.dram0.bss 68168 68168 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999807 999807 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692208 692208 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606932 606932 0 0.0
lock k32w061+release (read/write) 695568 695568 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610052 610052 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8723956 8723956 0 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405684 7405684 0 0.0
thermostat-no-ble arm64 (read only) 2165476 2165476 0 0.0
(read/write) 148657 148657 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75064 75064 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133140 133140 0 0.0
.text 1814016 1814016 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350452 2350452 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313052 1313052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1075751 36272 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700500 728856 28356 4.0
p6 all-clusters-app default (read/write) 2488704 2488704 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1446968 1446968 0 0.0
light-app default (read/write) 2395880 2395880 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354144 1354144 0 0.0
lock-app default (read/write) 2359408 2359408 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317672 1317672 0 0.0
qpg lighting-app qpg6105+debug (read only) 601608 601608 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read only) 567324 567324 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562004 562004 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883682 883682 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 624464 624464 0 0.0

@vivien-apple vivien-apple merged commit 6f75dd7 into project-chip:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@emargolis emargolis emargolis approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
crypto review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @bzbarsky-apple @tcarmelveilleux @emargolis