Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bindings] Save binding table in persistent storage #15449

Merged
merged 6 commits into from
Mar 4, 2022
Merged

[bindings] Save binding table in persistent storage #15449

merged 6 commits into from
Mar 4, 2022

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Feb 23, 2022 •
edited
Loading

Problem

The binding table content is not saved in the storage and will be lost after reboot.

Change overview

Save binding table to storage.

Testing

Unit test cases added for the BindingTable class to test storage features.

Manually tested with:

  • Pairing device with on two fabrics and add binding table content respectively. After reboot the values read are correct.
  • Modify binding table on different fabrics. After reboot the values read are correct.
  • Remove one fabric. After reboot the values read on another fabric are correct.
  • After reboot the bound devices can still receive the on/off commands from the all-cluster-app.

@gjc13 gjc13 requested review from bzbarsky-apple and andy31415 and removed request for andy31415 February 25, 2022 09:05
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #15449: Size comparison from 980e177 to a90cd1e

Increases (13 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section 980e177 a90cd1e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599010 599338 328 0.1
.app_xip_area 503856 504120 264 0.1
.bss 77844 77908 64 0.1
lock cyw930739m2evb_01 (read/write) 557094 557422 328 0.1
.app_xip_area 463476 463740 264 0.1
.bss 76348 76412 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 577598 577926 328 0.1
.app_xip_area 474556 474820 264 0.1
.bss 85444 85508 64 0.1
k32w light k32w061+release (read/write) 691360 691416 56 0.0
.bss 77472 77512 40 0.1
.text 606164 606180 16 0.0
lock k32w061+release (read/write) 694648 694704 56 0.0
.bss 77688 77728 40 0.1
.text 609196 609212 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8748748 8751404 2656 0.0
(read/write) 411601 411681 80 0.0
.bss 58609 58689 80 0.1
.text 7427620 7430276 2656 0.0
thermostat-no-ble arm64 (read only) 2161012 2163620 2608 0.1
(read/write) 148577 148641 64 0.0
.bss 65265 65329 64 0.1
.rodata 132756 132804 48 0.0
.text 1809952 1812512 2560 0.1
p6 all-clusters-app default (read/write) 2487472 2488184 712 0.0
.bss 118656 118704 48 0.0
.text 1445736 1446448 712 0.0
light-app default (read/write) 2394696 2394712 16 0.0
.bss 112976 113016 40 0.0
.text 1352960 1352976 16 0.0
lock-app default (read/write) 2358256 2358288 32 0.0
.bss 112720 112760 40 0.0
.text 1316520 1316552 32 0.0
qpg lighting-app qpg6105+debug (read only) 600648 600664 16 0.0
.bss 90904 90944 40 0.0
.text 595328 595344 16 0.0
lock-app qpg6105+debug (read only) 566452 566468 16 0.0
.bss 90912 90952 40 0.0
.text 561132 561148 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 882546 883286 740 0.1
bss 86336 86384 48 0.1
text 623544 624168 624 0.1
Full report (14 builds for cyw30739, k32w, linux, p6, qpg, telink)
platform target config section 980e177 a90cd1e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599010 599338 328 0.1
.app_xip_area 503856 504120 264 0.1
.bss 77844 77908 64 0.1
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557094 557422 328 0.1
.app_xip_area 463476 463740 264 0.1
.bss 76348 76412 64 0.1
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577598 577926 328 0.1
.app_xip_area 474556 474820 264 0.1
.bss 85444 85508 64 0.1
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 691360 691416 56 0.0
.bss 77472 77512 40 0.1
.data 1924 1924 0 0.0
.text 606164 606180 16 0.0
lock k32w061+release (read/write) 694648 694704 56 0.0
.bss 77688 77728 40 0.1
.data 1964 1964 0 0.0
.text 609196 609212 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8748748 8751404 2656 0.0
(read/write) 411601 411681 80 0.0
.bss 58609 58689 80 0.1
.data 1216 1216 0 0.0
.data.rel.ro 296568 296568 0 0.0
.dynamic 560 560 0 0.0
.got 51408 51408 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456676 456676 0 0.0
.text 7427620 7430276 2656 0.0
thermostat-no-ble arm64 (read only) 2161012 2163620 2608 0.1
(read/write) 148577 148641 64 0.0
.bss 65265 65329 64 0.1
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132756 132804 48 0.0
.text 1809952 1812512 2560 0.1
p6 all-clusters-app default (read/write) 2487472 2488184 712 0.0
.bss 118656 118704 48 0.0
.data 2688 2688 0 0.0
.text 1445736 1446448 712 0.0
light-app default (read/write) 2394696 2394712 16 0.0
.bss 112976 113016 40 0.0
.data 2536 2536 0 0.0
.text 1352960 1352976 16 0.0
lock-app default (read/write) 2358256 2358288 32 0.0
.bss 112720 112760 40 0.0
.data 2496 2496 0 0.0
.text 1316520 1316552 32 0.0
qpg lighting-app qpg6105+debug (read only) 600648 600664 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90944 40 0.0
.data 1124 1124 0 0.0
.text 595328 595344 16 0.0
lock-app qpg6105+debug (read only) 566452 566468 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90952 40 0.0
.data 1076 1076 0 0.0
.text 561132 561148 16 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882546 883286 740 0.1
bss 86336 86384 48 0.1
noinit 37160 37160 0 0.0
text 623544 624168 624 0.1

@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #15449: Size comparison from 980e177 to 98ddad7

Increases above 0.2%:

platform target config section 980e177 98ddad7 change % change
linux all-clusters-app debug (read only) 2392145 2401409 9264 0.4
.text 2025202 2034210 9008 0.4
chip-tool debug .bss 40384 40480 96 0.2
shell debug (read only) 2360553 2367193 6640 0.3
.text 1999842 2006258 6416 0.3
Increases (42 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 980e177 98ddad7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599010 599338 328 0.1
.app_xip_area 503856 504120 264 0.1
.bss 77844 77908 64 0.1
lock cyw930739m2evb_01 (read/write) 557094 557422 328 0.1
.app_xip_area 463476 463740 264 0.1
.bss 76348 76412 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 577598 577926 328 0.1
.app_xip_area 474556 474820 264 0.1
.bss 85444 85508 64 0.1
efr32 lighting-app BRD4161A (read only) 915892 915908 16 0.0
(read/write) 128608 128648 40 0.0
.bss 126560 126600 40 0.0
.text 915884 915900 16 0.0
BRD4161A+rpc (read only) 945988 946004 16 0.0
(read/write) 145548 145588 40 0.0
.bss 143336 143376 40 0.0
.text 945980 945996 16 0.0
lock-app BRD4161A+wf200 (read only) 985812 985828 16 0.0
(read/write) 120360 120400 40 0.0
.bss 118436 118476 40 0.0
.text 985804 985820 16 0.0
window-app BRD4161A (read only) 849984 850000 16 0.0
(read/write) 126840 126880 40 0.0
.bss 124920 124960 40 0.0
.text 849976 849992 16 0.0
esp32 all-clusters-app c3devkit (read only) 952386 953948 1562 0.2
(read/write) 1392858 1393002 144 0.0
.dram0.bss 62936 62984 48 0.1
.flash.rodata 196848 196944 96 0.0
.flash.text 952386 953948 1562 0.2
m5stack (read only) 1002411 1003831 1420 0.1
(read/write) 458336 458480 144 0.0
.dram0.bss 68080 68128 48 0.1
.flash.rodata 224056 224152 96 0.0
.flash.text 997027 998447 1420 0.1
k32w light k32w061+release (read/write) 691360 691416 56 0.0
.bss 77472 77512 40 0.1
.text 606164 606180 16 0.0
lock k32w061+release (read/write) 694648 694704 56 0.0
.bss 77688 77728 40 0.1
.text 609196 609212 16 0.0
linux all-clusters-app debug (read only) 2392145 2401409 9264 0.4
(read/write) 144688 144752 64 0.0
.bss 59232 59296 64 0.1
.rodata 204197 204453 256 0.1
.text 2025202 2034210 9008 0.4
bridge-app debug+rpc (read only) 1718253 1718333 80 0.0
(read/write) 92736 92768 32 0.0
.bss 47552 47584 32 0.1
.text 1461461 1461541 80 0.0
chip-tool debug (read only) 8994413 8997069 2656 0.0
(read/write) 298488 298584 96 0.0
.bss 40384 40480 96 0.2
.text 7905429 7908085 2656 0.0
chip-tool-ipv6only arm64 (read only) 8748748 8751404 2656 0.0
(read/write) 411601 411681 80 0.0
.bss 58609 58689 80 0.1
.text 7427620 7430276 2656 0.0
door-lock-app debug (read only) 1933881 1933945 64 0.0
(read/write) 119128 119160 32 0.0
.bss 50496 50528 32 0.1
.text 1612370 1612434 64 0.0
lighting-app debug+rpc (read only) 2068713 2068777 64 0.0
(read/write) 124488 124520 32 0.0
.bss 51424 51456 32 0.1
.text 1747666 1747730 64 0.0
ota-provider-app debug (read only) 1866449 1866513 64 0.0
(read/write) 114792 114824 32 0.0
.bss 50368 50400 32 0.1
.text 1557714 1557778 64 0.0
ota-requestor-app debug (read only) 1876945 1877025 80 0.0
(read/write) 116560 116592 32 0.0
.bss 51232 51264 32 0.1
.text 1576194 1576274 80 0.0
shell debug (read only) 2360553 2367193 6640 0.3
(read/write) 147168 147264 96 0.1
.bss 67552 67648 96 0.1
.rodata 204178 204402 224 0.1
.text 1999842 2006258 6416 0.3
thermostat-no-ble arm64 (read only) 2161012 2163620 2608 0.1
(read/write) 148577 148641 64 0.0
.bss 65265 65329 64 0.1
.rodata 132756 132804 48 0.0
.text 1809952 1812512 2560 0.1
tv-app debug (read only) 2586937 2590969 4032 0.2
(read/write) 148624 148688 64 0.0
.bss 65824 65888 64 0.1
.rodata 198173 198397 224 0.1
.text 2215026 2218834 3808 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2449520 2450160 640 0.0
.bss 191016 191064 48 0.0
.text 1412092 1412732 640 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 188188 188228 40 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2350036 2350100 64 0.0
.bss 187092 187132 40 0.0
.text 1312636 1312700 64 0.0
shell CY8CPROTO_062_4343W+release .bss 185728 185768 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038379 1039051 672 0.1
bss 125752 125800 48 0.0
rodata 135772 135836 64 0.0
text 699640 700176 536 0.1
lighting-app nrf52840dk_nrf52840 (read/write) 1001607 1001655 48 0.0
bss 122060 122100 40 0.0
text 686020 686036 16 0.0
nrf52840dk_nrf52840+rpc (read/write) 967919 967967 48 0.0
bss 119144 119184 40 0.0
text 663244 663260 16 0.0
nrf52840dongle_nrf52840 (read/write) 1017679 1017727 48 0.0
bss 123108 123148 40 0.0
text 690724 690740 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904418 904466 48 0.0
bss 119348 119388 40 0.0
text 595732 595748 16 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930695 930743 48 0.0
bss 120276 120316 40 0.0
text 628504 628520 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834318 834398 80 0.0
bss 117596 117636 40 0.0
text 538980 538996 16 0.0
pump-app nrf52840dk_nrf52840 (read/write) 928939 928987 48 0.0
bss 120008 120048 40 0.0
text 627932 627948 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924915 924963 48 0.0
bss 120012 120052 40 0.0
text 624188 624204 16 0.0
shell nrf52840dk_nrf52840 (read/write) 788795 789035 240 0.0
bss 112360 112384 24 0.0
text 525496 525732 236 0.0
p6 all-clusters-app default (read/write) 2487472 2488184 712 0.0
.bss 118656 118704 48 0.0
.text 1445736 1446448 712 0.0
light-app default (read/write) 2394696 2394712 16 0.0
.bss 112976 113016 40 0.0
.text 1352960 1352976 16 0.0
lock-app default (read/write) 2358256 2358288 32 0.0
.bss 112720 112760 40 0.0
.text 1316520 1316552 32 0.0
qpg lighting-app qpg6105+debug (read only) 600648 600664 16 0.0
.bss 90904 90944 40 0.0
.text 595328 595344 16 0.0
lock-app qpg6105+debug (read only) 566452 566468 16 0.0
.bss 90912 90952 40 0.0
.text 561132 561148 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 882546 883286 740 0.1
bss 86336 86384 48 0.1
text 623544 624168 624 0.1
Full report (45 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 980e177 98ddad7 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599010 599338 328 0.1
.app_xip_area 503856 504120 264 0.1
.bss 77844 77908 64 0.1
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557094 557422 328 0.1
.app_xip_area 463476 463740 264 0.1
.bss 76348 76412 64 0.1
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577598 577926 328 0.1
.app_xip_area 474556 474820 264 0.1
.bss 85444 85508 64 0.1
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915892 915908 16 0.0
(read/write) 128608 128648 40 0.0
.bss 126560 126600 40 0.0
.data 2048 2048 0 0.0
.text 915884 915900 16 0.0
BRD4161A+rpc (read only) 945988 946004 16 0.0
(read/write) 145548 145588 40 0.0
.bss 143336 143376 40 0.0
.data 2212 2212 0 0.0
.text 945980 945996 16 0.0
lock-app BRD4161A+wf200 (read only) 985812 985828 16 0.0
(read/write) 120360 120400 40 0.0
.bss 118436 118476 40 0.0
.data 1924 1924 0 0.0
.text 985804 985820 16 0.0
window-app BRD4161A (read only) 849984 850000 16 0.0
(read/write) 126840 126880 40 0.0
.bss 124920 124960 40 0.0
.data 1916 1916 0 0.0
.text 849976 849992 16 0.0
esp32 all-clusters-app c3devkit (read only) 952386 953948 1562 0.2
(read/write) 1392858 1393002 144 0.0
.dram0.bss 62936 62984 48 0.1
.dram0.data 14172 14172 0 0.0
.flash.rodata 196848 196944 96 0.0
.flash.text 952386 953948 1562 0.2
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1002411 1003831 1420 0.1
(read/write) 458336 458480 144 0.0
.dram0.bss 68080 68128 48 0.1
.dram0.data 34072 34072 0 0.0
.flash.rodata 224056 224152 96 0.0
.flash.text 997027 998447 1420 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691360 691416 56 0.0
.bss 77472 77512 40 0.1
.data 1924 1924 0 0.0
.text 606164 606180 16 0.0
lock k32w061+release (read/write) 694648 694704 56 0.0
.bss 77688 77728 40 0.1
.data 1964 1964 0 0.0
.text 609196 609212 16 0.0
linux all-clusters-app debug (read only) 2392145 2401409 9264 0.4
(read/write) 144688 144752 64 0.0
.bss 59232 59296 64 0.1
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204197 204453 256 0.1
.text 2025202 2034210 9008 0.4
bridge-app debug+rpc (read only) 1718253 1718333 80 0.0
(read/write) 92736 92768 32 0.0
.bss 47552 47584 32 0.1
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 141012 141012 0 0.0
.text 1461461 1461541 80 0.0
chip-tool debug (read only) 8994413 8997069 2656 0.0
(read/write) 298488 298584 96 0.0
.bss 40384 40480 96 0.2
.data 1164 1164 0 0.0
.data.rel.ro 250872 250872 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480533 480533 0 0.0
.text 7905429 7908085 2656 0.0
chip-tool-ipv6only arm64 (read only) 8748748 8751404 2656 0.0
(read/write) 411601 411681 80 0.0
.bss 58609 58689 80 0.1
.data 1216 1216 0 0.0
.data.rel.ro 296568 296568 0 0.0
.dynamic 560 560 0 0.0
.got 51408 51408 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456676 456676 0 0.0
.text 7427620 7430276 2656 0.0
door-lock-app debug (read only) 1933881 1933945 64 0.0
(read/write) 119128 119160 32 0.0
.bss 50496 50528 32 0.1
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 173052 173052 0 0.0
.text 1612370 1612434 64 0.0
lighting-app debug+rpc (read only) 2068713 2068777 64 0.0
(read/write) 124488 124520 32 0.0
.bss 51424 51456 32 0.1
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 165617 165617 0 0.0
.text 1747666 1747730 64 0.0
ota-provider-app debug (read only) 1866449 1866513 64 0.0
(read/write) 114792 114824 32 0.0
.bss 50368 50400 32 0.1
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 158195 158195 0 0.0
.text 1557714 1557778 64 0.0
ota-requestor-app debug (read only) 1876945 1877025 80 0.0
(read/write) 116560 116592 32 0.0
.bss 51232 51264 32 0.1
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151940 151940 0 0.0
.text 1576194 1576274 80 0.0
shell debug (read only) 2360553 2367193 6640 0.3
(read/write) 147168 147264 96 0.1
.bss 67552 67648 96 0.1
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 204178 204402 224 0.1
.text 1999842 2006258 6416 0.3
thermostat-no-ble arm64 (read only) 2161012 2163620 2608 0.1
(read/write) 148577 148641 64 0.0
.bss 65265 65329 64 0.1
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132756 132804 48 0.0
.text 1809952 1812512 2560 0.1
tv-app debug (read only) 2586937 2590969 4032 0.2
(read/write) 148624 148688 64 0.0
.bss 65824 65888 64 0.1
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 198173 198397 224 0.1
.text 2215026 2218834 3808 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449520 2450160 640 0.0
.bss 191016 191064 48 0.0
.data 5512 5512 0 0.0
.text 1412092 1412732 640 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414280 2414280 0 0.0
.bss 188188 188228 40 0.0
.data 5800 5800 0 0.0
.text 1376852 1376852 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350036 2350100 64 0.0
.bss 187092 187132 40 0.0
.data 5776 5776 0 0.0
.text 1312636 1312700 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340032 2340032 0 0.0
.bss 185728 185768 40 0.0
.data 5608 5608 0 0.0
.text 1302604 1302604 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038379 1039051 672 0.1
bss 125752 125800 48 0.0
rodata 135772 135836 64 0.0
text 699640 700176 536 0.1
lighting-app nrf52840dk_nrf52840 (read/write) 1001607 1001655 48 0.0
bss 122060 122100 40 0.0
rodata 116016 116016 0 0.0
text 686020 686036 16 0.0
nrf52840dk_nrf52840+rpc (read/write) 967919 967967 48 0.0
bss 119144 119184 40 0.0
rodata 107392 107392 0 0.0
text 663244 663260 16 0.0
nrf52840dongle_nrf52840 (read/write) 1017679 1017727 48 0.0
bss 123108 123148 40 0.0
rodata 115700 115700 0 0.0
text 690724 690740 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904418 904466 48 0.0
bss 119348 119388 40 0.0
rodata 108128 108128 0 0.0
text 595732 595748 16 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930695 930743 48 0.0
bss 120276 120316 40 0.0
rodata 104848 104848 0 0.0
text 628504 628520 16 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834318 834398 80 0.0
bss 117596 117636 40 0.0
rodata 96876 96876 0 0.0
text 538980 538996 16 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 928939 928987 48 0.0
bss 120008 120048 40 0.0
rodata 103828 103828 0 0.0
text 627932 627948 16 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924915 924963 48 0.0
bss 120012 120052 40 0.0
rodata 103524 103524 0 0.0
text 624188 624204 16 0.0
shell nrf52840dk_nrf52840 (read/write) 788795 789035 240 0.0
bss 112360 112384 24 0.0
rodata 74836 74836 0 0.0
text 525496 525732 236 0.0
p6 all-clusters-app default (read/write) 2487472 2488184 712 0.0
.bss 118656 118704 48 0.0
.data 2688 2688 0 0.0
.text 1445736 1446448 712 0.0
light-app default (read/write) 2394696 2394712 16 0.0
.bss 112976 113016 40 0.0
.data 2536 2536 0 0.0
.text 1352960 1352976 16 0.0
lock-app default (read/write) 2358256 2358288 32 0.0
.bss 112720 112760 40 0.0
.data 2496 2496 0 0.0
.text 1316520 1316552 32 0.0
qpg lighting-app qpg6105+debug (read only) 600648 600664 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90944 40 0.0
.data 1124 1124 0 0.0
.text 595328 595344 16 0.0
lock-app qpg6105+debug (read only) 566452 566468 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90952 40 0.0
.data 1076 1076 0 0.0
.text 561132 561148 16 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882546 883286 740 0.1
bss 86336 86384 48 0.1
noinit 37160 37160 0 0.0
text 623544 624168 624 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Feb 25, 2022
View reviewed changes
examples/all-clusters-app/all-clusters-common/src/binding-handler.cpp Show resolved Hide resolved
src/app/util/binding-table.cpp Outdated Show resolved Hide resolved
src/app/util/binding-table.h Outdated Show resolved Hide resolved
@gjc13 gjc13 requested a review from andy31415 March 2, 2022 03:22
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

PR #15449: Size comparison from 883528d to 3c621a9

Increases above 0.2%:

platform target config section 883528d 3c621a9 change % change
linux all-clusters-app debug (read only) 2397713 2406897 9184 0.4
.text 2029842 2038802 8960 0.4
chip-tool debug .bss 25248 25344 96 0.4
shell debug (read only) 2365929 2372601 6672 0.3
.text 2004322 2010738 6416 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1076419 36940 3.6
bss 125828 127728 1900 1.5
rodata 135904 141868 5964 4.4
text 700500 729392 28892 4.1
Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 883528d 3c621a9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600038 600366 328 0.1
.app_xip_area 504812 505076 264 0.1
.bss 77908 77972 64 0.1
lock cyw930739m2evb_01 (read/write) 558026 558354 328 0.1
.app_xip_area 464336 464600 264 0.1
.bss 76412 76476 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 578446 578774 328 0.1
.app_xip_area 475324 475588 264 0.1
.bss 85516 85580 64 0.1
efr32 lighting-app BRD4161A (read only) 917028 917044 16 0.0
(read/write) 128672 128712 40 0.0
.bss 126616 126656 40 0.0
.text 917020 917036 16 0.0
BRD4161A+rpc (read/write) 145616 145656 40 0.0
.bss 143392 143432 40 0.0
lock-app BRD4161A+wf200 (read only) 986844 986876 32 0.0
(read/write) 120432 120472 40 0.0
.bss 118500 118540 40 0.0
.text 986836 986868 32 0.0
window-app BRD4161A (read only) 850956 850988 32 0.0
(read/write) 126908 126948 40 0.0
.bss 124984 125024 40 0.0
.text 850948 850980 32 0.0
esp32 all-clusters-app m5stack (read only) 1005191 1006727 1536 0.2
(read/write) 458344 458488 144 0.0
.dram0.bss 68168 68216 48 0.1
.flash.rodata 224600 224696 96 0.0
.flash.text 999807 1001343 1536 0.2
k32w light k32w061+release (read/write) 692224 692280 56 0.0
.bss 77544 77584 40 0.1
.text 606948 606964 16 0.0
lock k32w061+release (read/write) 695584 695640 56 0.0
.bss 77744 77784 40 0.1
.text 610068 610084 16 0.0
linux all-clusters-app debug (read only) 2397713 2406897 9184 0.4
(read/write) 144856 144888 32 0.0
.bss 59328 59360 32 0.1
.rodata 205029 205253 224 0.1
.text 2029842 2038802 8960 0.4
bridge-app debug+rpc (read only) 1723165 1723245 80 0.0
(read/write) 92848 92880 32 0.0
.bss 47624 47656 32 0.1
.text 1465637 1465717 80 0.0
chip-tool debug (read only) 8963125 8965781 2656 0.0
(read/write) 282560 282656 96 0.0
.bss 25248 25344 96 0.4
.text 7878309 7880965 2656 0.0
door-lock-app debug (read only) 1938345 1938425 80 0.0
(read/write) 119296 119328 32 0.0
.bss 50624 50656 32 0.1
.text 1616066 1616146 80 0.0
lighting-app debug+rpc (read only) 2074145 2074225 80 0.0
(read/write) 124656 124688 32 0.0
.bss 51552 51584 32 0.1
.text 1752162 1752242 80 0.0
ota-provider-app debug (read only) 1870449 1870513 64 0.0
(read/write) 114928 114960 32 0.0
.bss 50432 50464 32 0.1
.text 1560914 1560978 64 0.0
ota-requestor-app debug (read only) 1881425 1881489 64 0.0
(read/write) 116696 116728 32 0.0
.bss 51296 51328 32 0.1
.text 1579906 1579970 64 0.0
shell debug (read only) 2365929 2372601 6672 0.3
(read/write) 147304 147368 64 0.0
.bss 67648 67712 64 0.1
.rodata 204978 205234 256 0.1
.text 2004322 2010738 6416 0.3
tv-app debug (read only) 2602585 2606617 4032 0.2
(read/write) 250968 251000 32 0.0
.bss 168096 168128 32 0.0
.rodata 199133 199357 224 0.1
.text 2229570 2233378 3808 0.2
mbed lock-app CY8CPROTO_062_4343W+release .bss 187156 187196 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1076419 36940 3.6
bss 125828 127728 1900 1.5
rodata 135904 141868 5964 4.4
text 700500 729392 28892 4.1
p6 all-clusters-app default (read/write) 2488704 2489416 712 0.0
.bss 118736 118784 48 0.0
.text 1446968 1447680 712 0.0
light-app default (read/write) 2395896 2395928 32 0.0
.bss 113048 113088 40 0.0
.text 1354160 1354192 32 0.0
lock-app default (read/write) 2359424 2359440 16 0.0
.bss 112792 112832 40 0.0
.text 1317688 1317704 16 0.0
qpg lighting-app qpg6105+debug (read only) 601624 601640 16 0.0
.bss 90928 90968 40 0.0
.text 596304 596320 16 0.0
lock-app qpg6105+debug (read only) 567340 567356 16 0.0
.bss 90936 90976 40 0.0
.text 562020 562036 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 883698 884446 748 0.1
bss 86408 86456 48 0.1
text 624464 625094 630 0.1
Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 883528d 3c621a9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600038 600366 328 0.1
.app_xip_area 504812 505076 264 0.1
.bss 77908 77972 64 0.1
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558026 558354 328 0.1
.app_xip_area 464336 464600 264 0.1
.bss 76412 76476 64 0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578446 578774 328 0.1
.app_xip_area 475324 475588 264 0.1
.bss 85516 85580 64 0.1
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917028 917044 16 0.0
(read/write) 128672 128712 40 0.0
.bss 126616 126656 40 0.0
.data 2056 2056 0 0.0
.text 917020 917036 16 0.0
BRD4161A+rpc (read only) 947112 947112 0 0.0
(read/write) 145616 145656 40 0.0
.bss 143392 143432 40 0.0
.data 2220 2220 0 0.0
.text 947104 947104 0 0.0
lock-app BRD4161A+wf200 (read only) 986844 986876 32 0.0
(read/write) 120432 120472 40 0.0
.bss 118500 118540 40 0.0
.data 1932 1932 0 0.0
.text 986836 986868 32 0.0
window-app BRD4161A (read only) 850956 850988 32 0.0
(read/write) 126908 126948 40 0.0
.bss 124984 125024 40 0.0
.data 1924 1924 0 0.0
.text 850948 850980 32 0.0
esp32 all-clusters-app m5stack (read only) 1005191 1006727 1536 0.2
(read/write) 458344 458488 144 0.0
.dram0.bss 68168 68216 48 0.1
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224696 96 0.0
.flash.text 999807 1001343 1536 0.2
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692224 692280 56 0.0
.bss 77544 77584 40 0.1
.data 1932 1932 0 0.0
.text 606948 606964 16 0.0
lock k32w061+release (read/write) 695584 695640 56 0.0
.bss 77744 77784 40 0.1
.data 1972 1972 0 0.0
.text 610068 610084 16 0.0
linux all-clusters-app debug (read only) 2397713 2406897 9184 0.4
(read/write) 144856 144888 32 0.0
.bss 59328 59360 32 0.1
.data 1392 1392 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 205029 205253 224 0.1
.text 2029842 2038802 8960 0.4
bridge-app debug+rpc (read only) 1723165 1723245 80 0.0
(read/write) 92848 92880 32 0.0
.bss 47624 47656 32 0.1
.data 2048 2048 0 0.0
.data.rel.ro 38104 38104 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1465637 1465717 80 0.0
chip-tool debug (read only) 8963125 8965781 2656 0.0
(read/write) 282560 282656 96 0.0
.bss 25248 25344 96 0.4
.data 1136 1136 0 0.0
.data.rel.ro 250152 250152 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 478261 478261 0 0.0
.text 7878309 7880965 2656 0.0
door-lock-app debug (read only) 1938345 1938425 80 0.0
(read/write) 119296 119328 32 0.0
.bss 50624 50656 32 0.1
.data 1056 1056 0 0.0
.data.rel.ro 62232 62232 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173724 173724 0 0.0
.text 1616066 1616146 80 0.0
lighting-app debug+rpc (read only) 2074145 2074225 80 0.0
(read/write) 124656 124688 32 0.0
.bss 51552 51584 32 0.1
.data 1472 1472 0 0.0
.data.rel.ro 66152 66152 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 166460 166460 0 0.0
.text 1752162 1752242 80 0.0
ota-provider-app debug (read only) 1870449 1870513 64 0.0
(read/write) 114928 114960 32 0.0
.bss 50432 50464 32 0.1
.data 1352 1352 0 0.0
.data.rel.ro 57512 57512 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1560914 1560978 64 0.0
ota-requestor-app debug (read only) 1881425 1881489 64 0.0
(read/write) 116696 116728 32 0.0
.bss 51296 51328 32 0.1
.data 1224 1224 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 152612 152612 0 0.0
.text 1579906 1579970 64 0.0
shell debug (read only) 2365929 2372601 6672 0.3
(read/write) 147304 147368 64 0.0
.bss 67648 67712 64 0.1
.data 864 864 0 0.0
.data.rel.ro 73144 73144 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 204978 205234 256 0.1
.text 2004322 2010738 6416 0.3
tv-app debug (read only) 2602585 2606617 4032 0.2
(read/write) 250968 251000 32 0.0
.bss 168096 168128 32 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73640 73640 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199133 199357 224 0.1
.text 2229570 2233378 3808 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 187156 187196 40 0.0
.data 5784 5784 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039479 1076419 36940 3.6
bss 125828 127728 1900 1.5
rodata 135904 141868 5964 4.4
text 700500 729392 28892 4.1
p6 all-clusters-app default (read/write) 2488704 2489416 712 0.0
.bss 118736 118784 48 0.0
.data 2696 2696 0 0.0
.text 1446968 1447680 712 0.0
light-app default (read/write) 2395896 2395928 32 0.0
.bss 113048 113088 40 0.0
.data 2544 2544 0 0.0
.text 1354160 1354192 32 0.0
lock-app default (read/write) 2359424 2359440 16 0.0
.bss 112792 112832 40 0.0
.data 2504 2504 0 0.0
.text 1317688 1317704 16 0.0
qpg lighting-app qpg6105+debug (read only) 601624 601640 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90968 40 0.0
.data 1132 1132 0 0.0
.text 596304 596320 16 0.0
lock-app qpg6105+debug (read only) 567340 567356 16 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90976 40 0.0
.data 1084 1084 0 0.0
.text 562020 562036 16 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883698 884446 748 0.1
bss 86408 86456 48 0.1
noinit 37160 37160 0 0.0
text 624464 625094 630 0.1

@bzbarsky-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

Fast tracking, given this has had enough time for review.

@woody-apple
Copy link
Contributor

@gjc13 Sadly there are conflicts, but this is fast tracked, please fix and merge!

@gjc13
Copy link
Contributor Author

gjc13 commented Mar 3, 2022

@woody-apple Conflicts resolved.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

PR #15449: Size comparison from 66aef3e to d8ab723

Increases (7 builds for cyw30739, p6, telink)
platform target config section 66aef3e d8ab723 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600618 600938 320 0.1
.app_xip_area 505392 505648 256 0.1
.bss 77908 77972 64 0.1
lock cyw930739m2evb_01 (read/write) 558614 558934 320 0.1
.app_xip_area 464924 465180 256 0.1
.bss 76412 76476 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 579394 579714 320 0.1
.app_xip_area 476008 476264 256 0.1
.bss 85780 85844 64 0.1
p6 all-clusters-app default (read/write) 2489552 2490240 688 0.0
.bss 118736 118784 48 0.0
.text 1447816 1448504 688 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 113048 113088 40 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112792 112832 40 0.0
.text 1318504 1318520 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 884222 884962 740 0.1
bss 86408 86456 48 0.1
text 625174 625804 630 0.1
Full report (7 builds for cyw30739, p6, telink)
platform target config section 66aef3e d8ab723 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600618 600938 320 0.1
.app_xip_area 505392 505648 256 0.1
.bss 77908 77972 64 0.1
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558614 558934 320 0.1
.app_xip_area 464924 465180 256 0.1
.bss 76412 76476 64 0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 579394 579714 320 0.1
.app_xip_area 476008 476264 256 0.1
.bss 85780 85844 64 0.1
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
p6 all-clusters-app default (read/write) 2489552 2490240 688 0.0
.bss 118736 118784 48 0.0
.data 2696 2696 0 0.0
.text 1447816 1448504 688 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 113048 113088 40 0.0
.data 2544 2544 0 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112792 112832 40 0.0
.data 2504 2504 0 0.0
.text 1318504 1318520 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 884222 884962 740 0.1
bss 86408 86456 48 0.1
noinit 37160 37160 0 0.0
text 625174 625804 630 0.1

@gjc13
Copy link
Contributor Author

gjc13 commented Mar 4, 2022

@woody-apple @andy31415 Merged with master again.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15449: Size comparison from 5a8ffc1 to 3f4f6a3

Increases (19 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5a8ffc1 3f4f6a3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600294 600614 320 0.1
.app_xip_area 505316 505572 256 0.1
.bss 77660 77724 64 0.1
lock cyw930739m2evb_01 (read/write) 558290 558610 320 0.1
.app_xip_area 464848 465104 256 0.1
.bss 76164 76228 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 580290 580610 320 0.1
.app_xip_area 477128 477384 256 0.1
.bss 85524 85588 64 0.1
efr32 lighting-app BRD4161A (read only) 919804 919820 16 0.0
(read/write) 128840 128880 40 0.0
.bss 126752 126792 40 0.0
.text 919796 919812 16 0.0
BRD4161A+rpc (read only) 949880 949896 16 0.0
(read/write) 145784 145824 40 0.0
.bss 143528 143568 40 0.0
.text 949872 949888 16 0.0
lock-app BRD4161A+wf200 (read only) 988140 988156 16 0.0
(read/write) 120312 120352 40 0.0
.bss 118380 118420 40 0.0
.text 988132 988148 16 0.0
window-app BRD4161A (read only) 853136 853152 16 0.0
(read/write) 126784 126824 40 0.0
.bss 124856 124896 40 0.0
.text 853128 853144 16 0.0
k32w light k32w061+release (read/write) 694008 694064 56 0.0
.bss 77680 77720 40 0.1
.text 608556 608572 16 0.0
lock k32w061+release (read/write) 695760 695816 56 0.0
.bss 77616 77656 40 0.1
.text 610372 610388 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097844 9100500 2656 0.0
(read/write) 418529 418609 80 0.0
.bss 43761 43841 80 0.2
.text 7706468 7709124 2656 0.0
thermostat-no-ble arm64 (read only) 2169156 2171796 2640 0.1
(read/write) 148417 148481 64 0.0
.bss 65121 65185 64 0.1
.rodata 132900 132964 64 0.0
.text 1817984 1820560 2576 0.1
mbed lock-app CY8CPROTO_062_4343W+release .bss 187036 187076 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1078115 1078719 604 0.1
bss 128900 128948 48 0.0
rodata 142028 142088 60 0.0
text 731896 732436 540 0.1
p6 all-clusters-app default (read/write) 2489608 2490304 696 0.0
.bss 118608 118656 48 0.0
.text 1447872 1448568 696 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 112920 112960 40 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112664 112704 40 0.0
.text 1318504 1318520 16 0.0
qpg lighting-app qpg6105+debug (read only) 603152 603168 16 0.0
.bss 91056 91096 40 0.0
.text 597832 597848 16 0.0
lock-app qpg6105+debug (read only) 568836 568852 16 0.0
.bss 91064 91104 40 0.0
.text 563516 563532 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 887462 888202 740 0.1
bss 86864 86912 48 0.1
text 626986 627612 626 0.1
Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5a8ffc1 3f4f6a3 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600294 600614 320 0.1
.app_xip_area 505316 505572 256 0.1
.bss 77660 77724 64 0.1
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558290 558610 320 0.1
.app_xip_area 464848 465104 256 0.1
.bss 76164 76228 64 0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580290 580610 320 0.1
.app_xip_area 477128 477384 256 0.1
.bss 85524 85588 64 0.1
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919804 919820 16 0.0
(read/write) 128840 128880 40 0.0
.bss 126752 126792 40 0.0
.data 2088 2088 0 0.0
.text 919796 919812 16 0.0
BRD4161A+rpc (read only) 949880 949896 16 0.0
(read/write) 145784 145824 40 0.0
.bss 143528 143568 40 0.0
.data 2252 2252 0 0.0
.text 949872 949888 16 0.0
lock-app BRD4161A+wf200 (read only) 988140 988156 16 0.0
(read/write) 120312 120352 40 0.0
.bss 118380 118420 40 0.0
.data 1932 1932 0 0.0
.text 988132 988148 16 0.0
window-app BRD4161A (read only) 853136 853152 16 0.0
(read/write) 126784 126824 40 0.0
.bss 124856 124896 40 0.0
.data 1924 1924 0 0.0
.text 853128 853144 16 0.0
k32w light k32w061+release (read/write) 694008 694064 56 0.0
.bss 77680 77720 40 0.1
.data 1972 1972 0 0.0
.text 608556 608572 16 0.0
lock k32w061+release (read/write) 695760 695816 56 0.0
.bss 77616 77656 40 0.1
.data 1972 1972 0 0.0
.text 610372 610388 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097844 9100500 2656 0.0
(read/write) 418529 418609 80 0.0
.bss 43761 43841 80 0.2
.data 1192 1192 0 0.0
.data.rel.ro 317936 317936 0 0.0
.dynamic 560 560 0 0.0
.got 51856 51856 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473628 473628 0 0.0
.text 7706468 7709124 2656 0.0
thermostat-no-ble arm64 (read only) 2169156 2171796 2640 0.1
(read/write) 148417 148481 64 0.0
.bss 65121 65185 64 0.1
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132964 64 0.0
.text 1817984 1820560 2576 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350772 2350772 0 0.0
.bss 187036 187076 40 0.0
.data 5784 5784 0 0.0
.text 1313372 1313372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1078115 1078719 604 0.1
bss 128900 128948 48 0.0
rodata 142028 142088 60 0.0
text 731896 732436 540 0.1
p6 all-clusters-app default (read/write) 2489608 2490304 696 0.0
.bss 118608 118656 48 0.0
.data 2696 2696 0 0.0
.text 1447872 1448568 696 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 112920 112960 40 0.0
.data 2544 2544 0 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112664 112704 40 0.0
.data 2504 2504 0 0.0
.text 1318504 1318520 16 0.0
qpg lighting-app qpg6105+debug (read only) 603152 603168 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91056 91096 40 0.0
.data 1172 1172 0 0.0
.text 597832 597848 16 0.0
lock-app qpg6105+debug (read only) 568836 568852 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91104 40 0.0
.data 1124 1124 0 0.0
.text 563516 563532 16 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 887462 888202 740 0.1
bss 86864 86912 48 0.1
noinit 37160 37160 0 0.0
text 626986 627612 626 0.1

@github-actions
Copy link

github-actions bot commented Mar 4, 2022 •
edited
Loading

PR #15449: Size comparison from 5a8ffc1 to 94fe4c0

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5a8ffc1 94fe4c0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600294 600614 320 0.1
.app_xip_area 505316 505572 256 0.1
.bss 77660 77724 64 0.1
lock cyw930739m2evb_01 (read/write) 558290 558610 320 0.1
.app_xip_area 464848 465104 256 0.1
.bss 76164 76228 64 0.1
ota-requestor cyw930739m2evb_01 (read/write) 580290 580610 320 0.1
.app_xip_area 477128 477384 256 0.1
.bss 85524 85588 64 0.1
efr32 lighting-app BRD4161A (read only) 919804 919820 16 0.0
(read/write) 128840 128880 40 0.0
.bss 126752 126792 40 0.0
.text 919796 919812 16 0.0
BRD4161A+rpc (read only) 949880 949896 16 0.0
(read/write) 145784 145824 40 0.0
.bss 143528 143568 40 0.0
.text 949872 949888 16 0.0
lock-app BRD4161A+wf200 (read only) 988140 988156 16 0.0
(read/write) 120312 120352 40 0.0
.bss 118380 118420 40 0.0
.text 988132 988148 16 0.0
window-app BRD4161A (read only) 853136 853152 16 0.0
(read/write) 126784 126824 40 0.0
.bss 124856 124896 40 0.0
.text 853128 853144 16 0.0
esp32 all-clusters-app c3devkit (read only) 953132 954714 1582 0.2
(read/write) 1392570 1392722 152 0.0
.dram0.bss 62536 62584 48 0.1
.flash.rodata 196880 196984 104 0.1
.flash.text 953132 954714 1582 0.2
m5stack (read only) 1008407 1009843 1436 0.1
(read/write) 459692 459828 136 0.0
.dram0.bss 68056 68104 48 0.1
.flash.rodata 225720 225808 88 0.0
.flash.text 1003023 1004459 1436 0.1
k32w light k32w061+release (read/write) 694008 694064 56 0.0
.bss 77680 77720 40 0.1
.text 608556 608572 16 0.0
lock k32w061+release (read/write) 695760 695816 56 0.0
.bss 77616 77656 40 0.1
.text 610372 610388 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097844 9100500 2656 0.0
(read/write) 418529 418609 80 0.0
.bss 43761 43841 80 0.2
.text 7706468 7709124 2656 0.0
thermostat-no-ble arm64 (read only) 2169156 2171796 2640 0.1
(read/write) 148417 148481 64 0.0
.bss 65121 65185 64 0.1
.rodata 132900 132964 64 0.0
.text 1817984 1820560 2576 0.1
mbed lock-app CY8CPROTO_062_4343W+release .bss 187036 187076 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1078115 1078719 604 0.1
bss 128900 128948 48 0.0
rodata 142028 142088 60 0.0
text 731896 732436 540 0.1
p6 all-clusters-app default (read/write) 2489608 2490304 696 0.0
.bss 118608 118656 48 0.0
.text 1447872 1448568 696 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 112920 112960 40 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112664 112704 40 0.0
.text 1318504 1318520 16 0.0
qpg lighting-app qpg6105+debug (read only) 603152 603168 16 0.0
.bss 91056 91096 40 0.0
.text 597832 597848 16 0.0
lock-app qpg6105+debug (read only) 568836 568852 16 0.0
.bss 91064 91104 40 0.0
.text 563516 563532 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 887462 888202 740 0.1
bss 86864 86912 48 0.1
text 626986 627612 626 0.1
Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5a8ffc1 94fe4c0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600294 600614 320 0.1
.app_xip_area 505316 505572 256 0.1
.bss 77660 77724 64 0.1
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558290 558610 320 0.1
.app_xip_area 464848 465104 256 0.1
.bss 76164 76228 64 0.1
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 580290 580610 320 0.1
.app_xip_area 477128 477384 256 0.1
.bss 85524 85588 64 0.1
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919804 919820 16 0.0
(read/write) 128840 128880 40 0.0
.bss 126752 126792 40 0.0
.data 2088 2088 0 0.0
.text 919796 919812 16 0.0
BRD4161A+rpc (read only) 949880 949896 16 0.0
(read/write) 145784 145824 40 0.0
.bss 143528 143568 40 0.0
.data 2252 2252 0 0.0
.text 949872 949888 16 0.0
lock-app BRD4161A+wf200 (read only) 988140 988156 16 0.0
(read/write) 120312 120352 40 0.0
.bss 118380 118420 40 0.0
.data 1932 1932 0 0.0
.text 988132 988148 16 0.0
window-app BRD4161A (read only) 853136 853152 16 0.0
(read/write) 126784 126824 40 0.0
.bss 124856 124896 40 0.0
.data 1924 1924 0 0.0
.text 853128 853144 16 0.0
esp32 all-clusters-app c3devkit (read only) 953132 954714 1582 0.2
(read/write) 1392570 1392722 152 0.0
.dram0.bss 62536 62584 48 0.1
.dram0.data 14236 14236 0 0.0
.flash.rodata 196880 196984 104 0.1
.flash.text 953132 954714 1582 0.2
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1008407 1009843 1436 0.1
(read/write) 459692 459828 136 0.0
.dram0.bss 68056 68104 48 0.1
.dram0.data 34080 34080 0 0.0
.flash.rodata 225720 225808 88 0.0
.flash.text 1003023 1004459 1436 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694008 694064 56 0.0
.bss 77680 77720 40 0.1
.data 1972 1972 0 0.0
.text 608556 608572 16 0.0
lock k32w061+release (read/write) 695760 695816 56 0.0
.bss 77616 77656 40 0.1
.data 1972 1972 0 0.0
.text 610372 610388 16 0.0
linux chip-tool-ipv6only arm64 (read only) 9097844 9100500 2656 0.0
(read/write) 418529 418609 80 0.0
.bss 43761 43841 80 0.2
.data 1192 1192 0 0.0
.data.rel.ro 317936 317936 0 0.0
.dynamic 560 560 0 0.0
.got 51856 51856 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473628 473628 0 0.0
.text 7706468 7709124 2656 0.0
thermostat-no-ble arm64 (read only) 2169156 2171796 2640 0.1
(read/write) 148417 148481 64 0.0
.bss 65121 65185 64 0.1
.data 1072 1072 0 0.0
.data.rel.ro 75048 75048 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132900 132964 64 0.0
.text 1817984 1820560 2576 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350772 2350772 0 0.0
.bss 187036 187076 40 0.0
.data 5784 5784 0 0.0
.text 1313372 1313372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1078115 1078719 604 0.1
bss 128900 128948 48 0.0
rodata 142028 142088 60 0.0
text 731896 732436 540 0.1
p6 all-clusters-app default (read/write) 2489608 2490304 696 0.0
.bss 118608 118656 48 0.0
.data 2696 2696 0 0.0
.text 1447872 1448568 696 0.0
light-app default (read/write) 2396728 2396744 16 0.0
.bss 112920 112960 40 0.0
.data 2544 2544 0 0.0
.text 1354992 1355008 16 0.0
lock-app default (read/write) 2360240 2360256 16 0.0
.bss 112664 112704 40 0.0
.data 2504 2504 0 0.0
.text 1318504 1318520 16 0.0
qpg lighting-app qpg6105+debug (read only) 603152 603168 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91056 91096 40 0.0
.data 1172 1172 0 0.0
.text 597832 597848 16 0.0
lock-app qpg6105+debug (read only) 568836 568852 16 0.0
(read/write) 146936 146936 0 0.0
.bss 91064 91104 40 0.0
.data 1124 1124 0 0.0
.text 563516 563532 16 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 887462 888202 740 0.1
bss 86864 86912 48 0.1
noinit 37160 37160 0 0.0
text 626986 627612 626 0.1

@andy31415 andy31415 merged commit 508f682 into project-chip:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gjc13 @bzbarsky-apple @woody-apple @tcarmelveilleux @andy31415