Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker definition for nRF Connect SDK #1529

Merged

Conversation

Damian-Nordic
Copy link
Contributor

Problem

We need a docker image to check build of the nRF Connect platform in the Examples github workflow (once the platform is added; see #1493).

Proposed Solution

Put a new docker image definition in integrations/docker/images/chip-build-nrfconnect-platform directory.

fixes #1528

@rwalker-apple
Copy link
Contributor

could this be folded into the chip-build-nrf-platform image, instead?

@Damian-Nordic
Copy link
Contributor Author

@rwalker-apple Thanks for your comment. I thought that if a docker image is not only meant for CI, but potentially also for users (who usually won't build an application for both nRF5 and nRF Connect at a time), then it's better to have two smaller than one bigger image. What do you think?

@rwalker-apple
Copy link
Contributor

rwalker-apple commented Jul 9, 2020

@rwalker-apple Thanks for your comment. I thought that if a docker image is not only meant for CI, but potentially also for users (who usually won't build an application for both nRF5 and nRF Connect at a time), then it's better to have two smaller than one bigger image. What do you think?

I don't have any strong feelings, just noticed that you're replicating much of what the nrf-platform docker image is.

One thought I have is that this may increase the maintenance burden for CHIP's "build for Nordic" environment, as there would be 2 places the platform and compiler version are maintained.

If tooling for the 2 Nordic targets don't conflict with each other, I'd just tack onto the other image (maybe rename it, as well?)

@woody-apple woody-apple merged commit 4c8c053 into project-chip:master Jul 10, 2020
@Damian-Nordic
Copy link
Contributor Author

I don't have any strong feelings, just noticed that you're replicating much of what the nrf-platform docker image is.

One thought I have is that this may increase the maintenance burden for CHIP's "build for Nordic" environment, as there would be 2 places the platform and compiler version are maintained.

If tooling for the 2 Nordic targets don't conflict with each other, I'd just tack onto the other image (maybe rename it, as well?)

That's a good point although I would still prefer having separate images for both SDKs not to bloat their sizes (despite of the common pieces most of their components are exclusive). But I guess I can turn the nrf Dockerfile into a multi-stage one on the next update.

@rwalker-apple
Copy link
Contributor

I don't have any strong feelings, just noticed that you're replicating much of what the nrf-platform docker image is.
One thought I have is that this may increase the maintenance burden for CHIP's "build for Nordic" environment, as there would be 2 places the platform and compiler version are maintained.
If tooling for the 2 Nordic targets don't conflict with each other, I'd just tack onto the other image (maybe rename it, as well?)

That's a good point although I would still prefer having separate images for both SDKs not to bloat their sizes (despite of the common pieces most of their components are exclusive). But I guess I can turn the nrf Dockerfile into a multi-stage one on the next update.

great plan. would you file an issue describing what needs fixing and what approach should be taken to address?

@Damian-Nordic
Copy link
Contributor Author

great plan. would you file an issue describing what needs fixing and what approach should be taken to address?

sure, done!

@Damian-Nordic Damian-Nordic deleted the feature/nrfconnect-docker branch July 21, 2020 13:24
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from feature/update-unify-release-branch to silabs

Squashed commit of the following:

commit a4a1d8ac18e9b5c1f8842af431d81fda137704f8
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Thu Feb 1 17:54:58 2024 +0530

    Updated Unify Release branch path
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
Merge in WMN_TOOLS/matter from feature/update-unify-release-branch to silabs

Squashed commit of the following:

commit a4a1d8ac18e9b5c1f8842af431d81fda137704f8
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Thu Feb 1 17:54:58 2024 +0530

    Updated Unify Release branch path
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
Merge in WMN_TOOLS/matter from feature/update-unify-release-branch to silabs

Squashed commit of the following:

commit a4a1d8ac18e9b5c1f8842af431d81fda137704f8
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Thu Feb 1 17:54:58 2024 +0530

    Updated Unify Release branch path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker for nRF Connect SDK
6 participants