-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for adding PAA trust store to chip-tool #15224
Merged
andy31415
merged 7 commits into
project-chip:master
from
tcarmelveilleux:chip-tool-trust-store
Feb 22, 2022
Merged
Prepare for adding PAA trust store to chip-tool #15224
andy31415
merged 7 commits into
project-chip:master
from
tcarmelveilleux:chip-tool-trust-store
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR is on the way to resolving project-chip#15209. - This PR does the following: - Splits DefaultDeviceAttesationVerifier from the main src/credentials target since it is an optional component that can be overridden by different commissioners - Adds the beginning of plumbing to properly select the Trust Store for the DefaultDeviceAttestationVerifier. - Moved DefaultDeviceAttestatationVerifier from credentials/examples to credentials/attestation_verifier Missing, to come in the follow-up: - The implementation of a new file-based PAA trust store configured with the path passed in the plumbing added here. Testing done: unit tests and cert tests still pass. Commissioning still works
woody-apple
approved these changes
Feb 15, 2022
Fast tracking tooling updates. |
PR #15224: Size comparison from 62164cb to 154f208 Increases (8 builds for linux, p6)
Decreases (5 builds for esp32, linux, mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #15224: Size comparison from e05785f to 69f55fe Increases (6 builds for linux, p6)
Decreases (5 builds for esp32, linux, mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 16, 2022
PR #15224: Size comparison from e05785f to b3fbf35 Increases (6 builds for linux, p6)
Decreases (5 builds for esp32, linux, mbed)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Feb 17, 2022
PR #15224: Size comparison from 967546f to a4f8ceb Increases (6 builds for linux, p6)
Decreases (5 builds for esp32, linux, mbed)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
jmeg-sfy
reviewed
Feb 22, 2022
jmeg-sfy
approved these changes
Feb 22, 2022
Assuming NRF timeout is not due to this PR. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
the DefaultDeviceAttestationVerifier. The trust store is injected to all
controllers/commissioners in chip-tool so that when they execute
attestation, it can work
since it is an optional component that can be overridden by different
commissioners
DefaultDeviceAttestatationVerifier.*
fromcredentials/examples
tocredentials/attestation_verifier
Missing, to come in the follow-up:
the path passed in the plumbing added here.
Testing
Testing done: unit tests and cert tests still pass. Commissioning still works