-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dependency Loop Error Introduced with #14676 #15127
Fix Dependency Loop Error Introduced with #14676 #15127
Conversation
PR #15127: Size comparison from 5cb8800 to 35ffbea Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
src/include/platform/internal/GenericConfigurationManagerImpl.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve as a fix for flaky builds, however for long term maintainability more work is required' Hardcoding things like 32
instead of using constants because it is hard to include things should be solvable by having separate includes and dependencies.
src/include/platform/internal/GenericConfigurationManagerImpl.cpp
Outdated
Show resolved
Hide resolved
Moved some of the Spake2p defines to the CHIPCryptoPAL.h
35ffbea
to
5c33603
Compare
PR #15127: Size comparison from 6e55dee to 5c33603 Increases (4 builds for mbed)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
…-chip#15127) Moved some of the Spake2p defines to the CHIPCryptoPAL.h
Problem
Described in #15121
Change overview
Fixed
Testing
existing tests