-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Add a simple pairing API for YAML #15075
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_PairingAPI
Feb 11, 2022
Merged
[YAML] Add a simple pairing API for YAML #15075
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:YAML_PairingAPI
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
changed the title
Yaml pairing api
[YAML] Add a simple pairing API for YAML
Feb 11, 2022
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
February 11, 2022 10:32
pullapprove
bot
requested review from
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 11, 2022 10:32
PR #15075: Size comparison from 0edb9f9 to 50e06a1 Increases (1 build for linux)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
reviewed
Feb 11, 2022
src/app/zap-templates/common/simulated-clusters/clusters/CommissionerCommands.js
Outdated
Show resolved
Hide resolved
jmeg-sfy
approved these changes
Feb 11, 2022
PR #15075: Size comparison from 0edb9f9 to 31c3d47 Increases (19 builds for cyw30739, efr32, esp32, k32w, mbed, p6, qpg)
Full report (22 builds for cyw30739, efr32, esp32, k32w, mbed, p6, qpg, telink)
|
vivien-apple
force-pushed
the
YAML_PairingAPI
branch
from
February 11, 2022 16:07
31c3d47
to
d759c80
Compare
PR #15075: Size comparison from 0bd4b85 to d759c80 Increases (2 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 11, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* [YAML] Add a simple pairing API for YAML * Update src/app/zap-templates/common/simulated-clusters/clusters/CommissionerCommands.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
YAML does not have a wait to commission the alternatives identities
Change overview
Testing
I have locally tested it with a test that makes use of multiple fabrics at https://github.com/vivien-apple/connectedhomeip-1/blob/TestMultiAdmin/src/app/tests/suites/TestMultiAdmin.yaml
I'm working on moving forward to get it in the tree.