Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Reject complex types in global response checker #15005

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[Android] Reject complex types in global response checker #15005

merged 1 commit into from
Feb 10, 2022

Conversation

austinh0
Copy link
Contributor

Problem

  • if_in_global_responses needs to reject complex types like nullable, optional, etc., or else Java code can erroneously use (for example) IntegerCallback where for a nullable int.

Change overview

  • Rename to if_basic_global_response, and call inverse if nullable/optional/etc.

Testing

@restyled-io restyled-io bot mentioned this pull request Feb 10, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #15005: Size comparison from 56634bf to 3ef7bbc

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 56634bf 3ef7bbc change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606682 606682 0 0.0
.app_xip_area 508112 508112 0 0.0
.bss 81268 81268 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563158 563158 0 0.0
.app_xip_area 466148 466148 0 0.0
.bss 79740 79740 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584170 584170 0 0.0
.app_xip_area 477912 477912 0 0.0
.bss 88660 88660 0 0.0
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906792 906792 0 0.0
(read/write) 129000 129000 0 0.0
.bss 126960 126960 0 0.0
.data 2036 2036 0 0.0
.text 906784 906784 0 0.0
BRD4161A+rpc (read only) 894236 894236 0 0.0
(read/write) 145656 145656 0 0.0
.bss 143520 143520 0 0.0
.data 2136 2136 0 0.0
.text 894228 894228 0 0.0
window-app BRD4161A (read only) 841920 841920 0 0.0
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1904 1904 0 0.0
.text 841912 841912 0 0.0
esp32 all-clusters-app c3devkit (read only) 943304 943304 0 0.0
(read/write) 1400250 1400250 0 0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 199040 199040 0 0.0
.flash.text 943304 943304 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 990967 0 0.0
(read/write) 465080 465080 0 0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 225712 225712 0 0.0
.flash.text 985583 985583 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683544 683544 0 0.0
.bss 78264 78264 0 0.0
.data 1908 1908 0 0.0
.text 597572 597572 0 0.0
lock k32w061+release (read/write) 688408 688408 0 0.0
.bss 78664 78664 0 0.0
.data 1952 1952 0 0.0
.text 601992 601992 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7478116 7478116 0 0.0
(read/write) 303409 303409 0 0.0
.bss 51777 51777 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 199520 199520 0 0.0
.dynamic 560 560 0 0.0
.got 47088 47088 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403020 403020 0 0.0
.text 6435220 6435220 0 0.0
thermostat-no-ble arm64 (read only) 2139804 2139804 0 0.0
(read/write) 142273 142273 0 0.0
.bss 59201 59201 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 74912 74912 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132956 0 0.0
.text 1788736 1788736 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396072 2396072 0 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1358672 1358672 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2357760 0 0.0
.bss 182704 182704 0 0.0
.data 5632 5632 0 0.0
.text 1320360 1320360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321288 0 0.0
.bss 182592 182592 0 0.0
.data 5608 5608 0 0.0
.text 1283888 1283888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307292 0 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1269864 1269864 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015363 1015363 0 0.0
bss 123020 123020 0 0.0
rodata 119416 119416 0 0.0
text 693908 693908 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984183 984183 0 0.0
bss 120208 120208 0 0.0
rodata 110780 110780 0 0.0
text 673520 673520 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031067 1031067 0 0.0
bss 124416 124416 0 0.0
rodata 118276 118276 0 0.0
text 698528 698528 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 921958 921958 0 0.0
bss 119584 119584 0 0.0
rodata 112656 112656 0 0.0
text 608944 608944 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945083 945083 0 0.0
bss 121400 121400 0 0.0
rodata 108160 108160 0 0.0
text 636948 636948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852594 852594 0 0.0
bss 117992 117992 0 0.0
rodata 101332 101332 0 0.0
text 552756 552756 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944507 944507 0 0.0
bss 121120 121120 0 0.0
rodata 107520 107520 0 0.0
text 637208 637208 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 939847 939847 0 0.0
bss 121124 121124 0 0.0
rodata 106812 106812 0 0.0
text 633244 633244 0 0.0
shell nrf52840dk_nrf52840 (read/write) 805927 805927 0 0.0
bss 112400 112400 0 0.0
rodata 78812 78812 0 0.0
text 537036 537036 0 0.0
p6 all-clusters-app default (read/write) 2482304 2482304 0 0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440568 1440568 0 0.0
light-app default (read/write) 2388648 2388648 0 0.0
.bss 109352 109352 0 0.0
.data 2528 2528 0 0.0
.text 1346912 1346912 0 0.0
lock-app default (read/write) 2352104 2352104 0 0.0
.bss 109072 109072 0 0.0
.data 2488 2488 0 0.0
.text 1310368 1310368 0 0.0
qpg lighting-app qpg6105+debug (read only) 592956 592956 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90536 90536 0 0.0
.data 1112 1112 0 0.0
.text 587636 587636 0 0.0
lock-app qpg6105+debug (read only) 558708 558708 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90520 90520 0 0.0
.data 1064 1064 0 0.0
.text 553388 553388 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874334 0 0.0
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613082 613082 0 0.0

chulspro
chulspro approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chulspro chulspro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ~ Looks good to me

@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #15005: Size comparison from 31b5331 to ee5000a

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 31b5331 ee5000a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 607102 607102 0 0.0
.app_xip_area 508532 508532 0 0.0
.bss 81268 81268 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563806 563806 0 0.0
.app_xip_area 466804 466804 0 0.0
.bss 79740 79740 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584582 584582 0 0.0
.app_xip_area 478332 478332 0 0.0
.bss 88660 88660 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907520 907520 0 0.0
(read/write) 128992 128992 0 0.0
.bss 126960 126960 0 0.0
.data 2032 2032 0 0.0
.text 907512 907512 0 0.0
BRD4161A+rpc (read only) 894948 894948 0 0.0
(read/write) 145652 145652 0 0.0
.bss 143520 143520 0 0.0
.data 2132 2132 0 0.0
.text 894940 894940 0 0.0
window-app BRD4161A (read only) 842632 842632 0 0.0
(read/write) 127064 127064 0 0.0
.bss 125160 125160 0 0.0
.data 1900 1900 0 0.0
.text 842624 842624 0 0.0
esp32 all-clusters-app c3devkit (read only) 943846 943846 0 0.0
(read/write) 1399770 1399770 0 0.0
.dram0.bss 68024 68024 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198576 198576 0 0.0
.flash.text 943846 943846 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 991147 991147 0 0.0
(read/write) 464608 464608 0 0.0
.dram0.bss 73168 73168 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 225248 225248 0 0.0
.flash.text 985763 985763 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 684216 684216 0 0.0
.bss 78264 78264 0 0.0
.data 1904 1904 0 0.0
.text 598248 598248 0 0.0
lock k32w061+release (read/write) 689080 689080 0 0.0
.bss 78664 78664 0 0.0
.data 1948 1948 0 0.0
.text 602668 602668 0 0.0
linux all-clusters-app debug (read only) 2346249 2346249 0 0.0
(read/write) 141696 141696 0 0.0
.bss 56224 56224 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205253 205253 0 0.0
.text 1978770 1978770 0 0.0
bridge-app debug+rpc (read only) 1713909 1713909 0 0.0
(read/write) 85864 85864 0 0.0
.bss 40624 40624 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141036 141036 0 0.0
.text 1456373 1456373 0 0.0
chip-tool debug (read only) 8229453 8229453 0 0.0
(read/write) 232248 232248 0 0.0
.bss 33512 33512 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 191528 191528 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 456309 456309 0 0.0
.text 7292501 7292501 0 0.0
chip-tool-ipv6only arm64 (read only) 8053036 8053036 0 0.0
(read/write) 339473 339473 0 0.0
.bss 51777 51777 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 233784 233784 0 0.0
.dynamic 560 560 0 0.0
.got 48904 48904 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 433156 433156 0 0.0
.text 6894308 6894308 0 0.0
door-lock-app debug (read only) 1919065 1919065 0 0.0
(read/write) 112184 112184 0 0.0
.bss 43696 43696 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172434 172434 0 0.0
.text 1598162 1598162 0 0.0
lighting-app debug+rpc (read only) 2043369 2043369 0 0.0
(read/write) 117464 117464 0 0.0
.bss 44672 44672 0 0.0
.data 1464 1464 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165937 165937 0 0.0
.text 1722642 1722642 0 0.0
ota-provider-app debug (read only) 1858721 1858721 0 0.0
(read/write) 107928 107928 0 0.0
.bss 43648 43648 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157982 157982 0 0.0
.text 1550194 1550194 0 0.0
ota-requestor-app debug (read only) 1853433 1853433 0 0.0
(read/write) 109048 109048 0 0.0
.bss 43936 43936 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58504 58504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151407 151407 0 0.0
.text 1553202 1553202 0 0.0
shell debug (read only) 2320009 2320009 0 0.0
(read/write) 144688 144688 0 0.0
.bss 65120 65120 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206258 206258 0 0.0
.text 1957330 1957330 0 0.0
thermostat-no-ble arm64 (read only) 2140044 2140044 0 0.0
(read/write) 142305 142305 0 0.0
.bss 59201 59201 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74960 74960 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132460 132460 0 0.0
.text 1789472 1789472 0 0.0
tv-app debug (read only) 2515905 2515905 0 0.0
(read/write) 141056 141056 0 0.0
.bss 58848 58848 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197292 197292 0 0.0
.text 2145698 2145698 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396768 2396768 0 0.0
.bss 190092 190092 0 0.0
.data 5320 5320 0 0.0
.text 1359368 1359368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358456 2358456 0 0.0
.bss 182704 182704 0 0.0
.data 5624 5624 0 0.0
.text 1321056 1321056 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321984 2321984 0 0.0
.bss 182592 182592 0 0.0
.data 5600 5600 0 0.0
.text 1284584 1284584 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307988 2307988 0 0.0
.bss 179844 179844 0 0.0
.data 5424 5424 0 0.0
.text 1270560 1270560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1016043 1016043 0 0.0
bss 123020 123020 0 0.0
rodata 119528 119528 0 0.0
text 694484 694484 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 984875 984875 0 0.0
bss 120208 120208 0 0.0
rodata 110896 110896 0 0.0
text 674096 674096 0 0.0
nrf52840dongle_nrf52840 (read/write) 1031759 1031759 0 0.0
bss 124416 124416 0 0.0
rodata 118392 118392 0 0.0
text 699100 699100 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 922642 922642 0 0.0
bss 119584 119584 0 0.0
rodata 112772 112772 0 0.0
text 609520 609520 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 945759 945759 0 0.0
bss 121400 121400 0 0.0
rodata 108276 108276 0 0.0
text 637512 637512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853266 853266 0 0.0
bss 117992 117992 0 0.0
rodata 101444 101444 0 0.0
text 553320 553320 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 945187 945187 0 0.0
bss 121120 121120 0 0.0
rodata 107632 107632 0 0.0
text 637772 637772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 940519 940519 0 0.0
bss 121124 121124 0 0.0
rodata 106924 106924 0 0.0
text 633808 633808 0 0.0
shell nrf52840dk_nrf52840 (read/write) 806335 806335 0 0.0
bss 112400 112400 0 0.0
rodata 78948 78948 0 0.0
text 537308 537308 0 0.0
p6 all-clusters-app default (read/write) 2482288 2482288 0 0.0
.bss 119704 119704 0 0.0
.data 2672 2672 0 0.0
.text 1440552 1440552 0 0.0
light-app default (read/write) 2388632 2388632 0 0.0
.bss 109352 109352 0 0.0
.data 2520 2520 0 0.0
.text 1346896 1346896 0 0.0
lock-app default (read/write) 2352072 2352072 0 0.0
.bss 109072 109072 0 0.0
.data 2480 2480 0 0.0
.text 1310336 1310336 0 0.0
qpg lighting-app qpg6105+debug (read only) 593632 593632 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90536 90536 0 0.0
.data 1108 1108 0 0.0
.text 588312 588312 0 0.0
lock-app qpg6105+debug (read only) 559384 559384 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90520 90520 0 0.0
.data 1060 1060 0 0.0
.text 554064 554064 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874830 874830 0 0.0
bss 90352 90352 0 0.0
noinit 37160 37160 0 0.0
text 613464 613464 0 0.0

@austinh0 austinh0 merged commit dc99fb3 into project-chip:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chulspro chulspro chulspro approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinh0 @chulspro @yufengwangca @bzbarsky-apple