Pull/k32w adaptation 15.4 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
doru91
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
|
|
Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
andy31415
approved these changes
Jul 2, 2020
BroderickCarlin
approved these changes
Jul 2, 2020
|
|
||
| namespace nl { | ||
| namespace Inet { | ||
| class IPAddress; |
There was a problem hiding this comment.
this appears not to be needed by anything in this header. why is it here?
| va_start(v, aFormat); | ||
|
|
||
| #if K32W_LOG_ENABLED | ||
| char formattedMsg[CHIP_DEVICE_CONFIG_LOG_MESSAGE_MAX_SIZE - 1] = { 0 }; |
There was a problem hiding this comment.
this near copy of the code above in LogV() is a little unfortunate
dleach02
reviewed
Jul 17, 2020
| DeviceLayer::OnLogOutput(); | ||
|
|
||
| #endif // NRF_LOG_ENABLED | ||
| } |
There was a problem hiding this comment.
Should probably remove the NRF names that are not aligned with the K32W names
There was a problem hiding this comment.
Will remove the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds the 15.4 adaptation layer for NXP K32W platform (https://www.nxp.com/products/wireless/thread/k32w061-41-high-performance-secure-and-ultra-low-power-mcu-for-zigbeethread-and-bluetooth-le-5-0-with-built-in-nfc-option:K32W061_41).
Most of the code is taken from OpenWeave and the namespace was changed to Project CHIP.
In the following PRs will add the changes required for the build system and also a demo lock app.