-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MatchesFabricIndex method to codec #13881
Merged
mlepage-google
merged 1 commit into
project-chip:master
from
mlepage-google:matches-fabric-index
Jan 27, 2022
Merged
Add MatchesFabricIndex method to codec #13881
mlepage-google
merged 1 commit into
project-chip:master
from
mlepage-google:matches-fabric-index
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for proper fabric-filtered read operation, at least until we restructure encode/decode to use more of the generated types.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple and
robszewczyk
January 24, 2022 19:44
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 24, 2022 19:44
andy31415
approved these changes
Jan 24, 2022
PR #13881: Size comparison from 4449e65 to 3cee804 Increases (3 builds for esp32, p6)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 25, 2022
woody-apple
approved these changes
Jan 27, 2022
msandstedt
approved these changes
Jan 27, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
Needed for proper fabric-filtered read operation, at least until we restructure encode/decode to use more of the generated types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ACL not fabric filtered when read
Change overview
Add MatchesFabricIndex method to AccessControlEntryCodec
This is necessary for fabric filtered read to work, if using that
codec for encoding.
This is a quick fix, it may be preferable to move encoding to a
higher level to use more of the generated types, but that will
require more refactoring.
Testing