-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to print long manual pairing code #13860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #13860: Size comparison from 5227f3e to 31a3bbb Increases (21 builds for esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
dhrishi
reviewed
Jan 24, 2022
dhrishi
changed the title
Long manual code added.
Add support to print long manual pairing code
Jan 24, 2022
jadhavrohit924
force-pushed
the
manual-code
branch
from
January 25, 2022 06:15
31a3bbb
to
b6c8a7c
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
pan-apple
January 25, 2022 06:15
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 25, 2022 06:15
PR #13860: Size comparison from 270081a to b6c8a7c Increases (13 builds for esp32, k32w, mbed, p6, qpg, telink)
Full report (20 builds for cyw30739, efr32, esp32, k32w, mbed, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
manual-code
branch
from
January 25, 2022 08:00
b6c8a7c
to
5c2b844
Compare
PR #13860: Size comparison from e169fcf to 5c2b844 Increases (11 builds for k32w, mbed, p6, qpg, telink)
Full report (20 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
dhrishi
approved these changes
Jan 25, 2022
andy31415
approved these changes
Jan 25, 2022
fast track: small delta, has been up sufficient time for cross timezone review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Previously, long pairing code was not showing in the log snippets, now it is available.
Testing
How was this tested? (at least one bullet point required)
I (1160) chip[SVR]: Long Manual pairing code: [749701123309050177298]