-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces to pass ipk and adminSubject from op creds delegate #13830
Add interfaces to pass ipk and adminSubject from op creds delegate #13830
Conversation
The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally. This commit adds optional interfaces to pass these from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place. Fixes project-chip#13503
bba6303
to
c8e4976
Compare
PR #13830: Size comparison from 225a20b to 5b75b52 Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
PR #13830: Size comparison from ed8d276 to 578537e Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #13830: Size comparison from e9da114 to e41e47b Increases above 0.2%:
Increases (18 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #13830: Size comparison from be9582b to 108c747 Increases (1 build for linux)
Decreases (2 builds for qpg)
Full report (9 builds for cyw30739, k32w, linux, qpg, telink)
|
PR #13830: Size comparison from de95567 to dc9dbf7 Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
9c85b56
to
0c51b64
Compare
PR #13830: Size comparison from 75b9637 to 0c51b64 Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…roject-chip#13830) * Add interfaces to pass ipk and adminSubject from op creds delegate The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally. This commit adds optional interfaces to pass these from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place. Fixes project-chip#13503 * fix android build * fix sanitization test * fix iOS build * per tcarmelveilleux, do not enclose 0-length IPK ind AddNOC * remove Has methods from CommissioningParameters for brevity * restyle * Fix project-chip#12915 merge
Problem
The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally.
Change overview
This commit adds optional interfaces to pass IPK and AdminSubject from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place.
Fixes #13503
Testing