Add interfaces to pass ipk and adminSubject from op creds delegate #13830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally. This commit adds optional interfaces to pass these from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place. Fixes project-chip#13503
msandstedt
force-pushed
the
13503-add-admin-subject-and-ipk-interfaces
branch
from
bba6303
to
c8e4976
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google and
mrjerryjohns
|
PR #13830: Size comparison from 225a20b to 5b75b52 Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
|
PR #13830: Size comparison from ed8d276 to 578537e Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 24, 2022
|
PR #13830: Size comparison from e9da114 to e41e47b Increases above 0.2%:
Increases (18 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #13830: Size comparison from be9582b to 108c747 Increases (1 build for linux)
Decreases (2 builds for qpg)
Full report (9 builds for cyw30739, k32w, linux, qpg, telink)
|
|
PR #13830: Size comparison from de95567 to dc9dbf7 Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
msandstedt
force-pushed
the
13503-add-admin-subject-and-ipk-interfaces
branch
from
9c85b56
to
0c51b64
Compare
|
PR #13830: Size comparison from 75b9637 to 0c51b64 Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Jan 26, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…roject-chip#13830) * Add interfaces to pass ipk and adminSubject from op creds delegate The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally. This commit adds optional interfaces to pass these from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place. Fixes project-chip#13503 * fix android build * fix sanitization test * fix iOS build * per tcarmelveilleux, do not enclose 0-length IPK ind AddNOC * remove Has methods from CommissioningParameters for brevity * restyle * Fix project-chip#12915 merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The operational credentials delegate provides interfaces to pass certificates back to the commissioner, but cannot fully specify the contents of the AddNOC command. Missing are the IPK and AdminSubject. Without these, those can only be managed locally.
Change overview
This commit adds optional interfaces to pass IPK and AdminSubject from the delegate. Where AdminSubject is not passed, the commissioner uses its own node ID as before. And where IPK is not passed, the commissioner writes a 0-length IPK, which is also as before and is what we are using until GroupKeyManagement and other dependencies are in place.
Fixes #13503
Testing