Update ZAP to pick up reportability changes. #13802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple and
robszewczyk
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
yufengwangca
approved these changes
Jan 21, 2022
|
PR #13802: Size comparison from cf1b254 to 740ff75 Increases (1 build for linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Jan 21, 2022
jmeg-sfy
approved these changes
Jan 21, 2022
|
fast track: zap external repo update and match. |
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 24, 2022
We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable.
andy31415
added a commit
that referenced
this pull request
Jan 25, 2022
* Complex types in Java * Regenerate * loop fix (#13828) * Ran zap regen (#13837) * Update ZAP to pick up reportability changes. (#13802) We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable. * Use UniquePtr, fix templates * Regen with updated ZAP * Regen again Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Co-authored-by: Andrei Litvin <andrei@andy314.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable.
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
* Complex types in Java * Regenerate * loop fix (project-chip#13828) * Ran zap regen (project-chip#13837) * Update ZAP to pick up reportability changes. (project-chip#13802) We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable. * Use UniquePtr, fix templates * Regen with updated ZAP * Regen again Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Co-authored-by: Andrei Litvin <andrei@andy314.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now explicitly default all attributes to "reportable". XML
files will be able to set reportingPolicy="prohibited" for things that
the Matter spec decides are not subscribable.
Problem
ZAP UI controls whether things are marked as "reportable".
Change overview
Ignore the UI. Set things to default to "reportable" globally, with an affordance to mark things that are non-reportable (non-subscribable) accordingly in XML.
Testing
Ran codegen, and a non-reportable attribute that had gotten added is now being treated as reportable.