-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowCovering: fix Limits checks + factorization #13729
Merged
woody-apple
merged 12 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-conversion
Jan 26, 2022
Merged
WindowCovering: fix Limits checks + factorization #13729
woody-apple
merged 12 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-conversion
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
January 19, 2022 21:33
jmartinez-silabs
approved these changes
Jan 20, 2022
andy31415
approved these changes
Jan 21, 2022
@bzbarsky-apple if you would like to have a look thanks , @eve-cxrp also thanks |
src/app/clusters/window-covering-server/window-covering-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/window-covering-server/window-covering-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/window-covering-server/window-covering-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/window-covering-server/window-covering-server.h
Outdated
Show resolved
Hide resolved
- automatically set global field
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-conversion
branch
from
January 24, 2022 10:30
42379bb
to
5c51952
Compare
PR #13729: Size comparison from 5227f3e to 5c51952 Increases (4 builds for efr32, esp32, p6)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given > 3 days of review. Comments look resolved too.
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
* DEV: Remove IsOpen IsClosed function and use CheckLimitState * DEV: Move HasFeature function for external usage * DEV: Factorize conversion function * DEV: Add IsPercent100thsValid check method * DEV: Add OperationalStatusSet Global field helpers function - automatically set global field * DEV: Add ComputeOperationalState function * Restyled by clang-format * DEV: Rename limits using "Over" to "Post" * DEV: Cleanup HasFeature function * DEV: Add comments to explain the convert function * DEV: Replace Limit Post by Past * Style: correct bad description of ConvertValue Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Goal: Lay down some small changes for next PRs
Change overview
Add some Helper methods :
Testing
How was this tested? (at least one bullet point required)