-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add structs_with_cluster_name zap helper instead of relying on a partial and multiple zcl_structs calls #13726
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_ZAPStructsHelper
Jan 26, 2022
Merged
[chip-tool] Add structs_with_cluster_name zap helper instead of relying on a partial and multiple zcl_structs calls #13726
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_ZAPStructsHelper
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple and
sagar-apple
January 19, 2022 20:16
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 19, 2022 20:16
bzbarsky-apple
approved these changes
Jan 19, 2022
PR #13726: Size comparison from ffd25d8 to 63f56c4 Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_ZAPStructsHelper
branch
from
January 20, 2022 12:27
63f56c4
to
97a7d58
Compare
PR #13726: Size comparison from 914ba3e to 97a7d58 Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
woody-apple
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given tool changes.
…ng on a partial and multiple zcl_structs calls
vivien-apple
force-pushed
the
ChipTool_ZAPStructsHelper
branch
from
January 26, 2022 12:38
97a7d58
to
1f9b668
Compare
PR #13726: Size comparison from e45f0a1 to 1f9b668 Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…ng on a partial and multiple zcl_structs calls (project-chip#13726) * [chip-tool] Add structs_with_cluster_name zap helper instead of relying on a partial and multiple zcl_structs calls * Update generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To generate the code for the necessary
structs
inchip-tool
, one needs to uses 2zcl_structs
block, which makes it mandatory to create a partial if you want code to be reused. This is annoying and confusing is you need to create an other class that needs to generate code for structs too, while it can be solved by a simple helper.Change overview
structs_with_cluster_name
inchip-tool