add isShortDiscriminator to SetupPayload #13671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
pan-apple and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #13671: Size comparison from 78a6636 to 30714d6 Increases (24 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
force-pushed
the
add-is-short-discriminator
branch
2 times, most recently
from
e3eebf8
to
30714d6
Compare
|
PR #13671: Size comparison from 150c479 to 30714d6 Increases (20 builds for efr32, k32w, nrfconnect, p6, qpg, telink)
Full report (28 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
|
PR #13671: Size comparison from 41d3a6c to a180e7a Increases (12 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
The SetupPayload (Onboarding Payload in spec terminology) should be fully self describing, but isn't because it does not record whether the discriminator is the short or long version. This commit makes the necessary additions to expose that information. This improvement is then used to simplify the code in SetUpCodePairer, which was passing around its own isShort bool. Instead, it now just uses the SetupPayload struct in all interfaces.
msandstedt
force-pushed
the
add-is-short-discriminator
branch
from
a180e7a
to
69e2a92
Compare
|
PR #13671: Size comparison from 5274676 to 69e2a92 Increases (12 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (19 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
sagar-apple
approved these changes
Jan 19, 2022
bzbarsky-apple
approved these changes
Jan 19, 2022
andy31415
approved these changes
Jan 21, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
The SetupPayload (Onboarding Payload in spec terminology) should be fully self describing, but isn't because it does not record whether the discriminator is the short or long version. This commit makes the necessary additions to expose that information. This improvement is then used to simplify the code in SetUpCodePairer, which was passing around its own isShort bool. Instead, it now just uses the SetupPayload struct in all interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SetupPayload (Onboarding Payload in spec terminology) should be
fully self describing, but isn't because it does not record whether the
discriminator is the short or long version.
Change overview
This commit makes the necessary additions to expose that information.
This improvement is then used to simplify the code in SetUpCodePairer,
which was passing around its own isShort bool. Instead, it now just
uses the SetupPayload struct in all interfaces.
Testing
Build succeeds, unit and integration tests pass.