-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. #13521
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-mfg-code-search-record
Jan 13, 2022
Merged
Remove unused manufacturerCode field of EmberAfAttributeSearchRecord. #13521
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-mfg-code-search-record
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only written, never read. The emberAfReadSequentialAttributesAddToResponse function that was one of the writers is unused, so removing that too.
bzbarsky-apple
force-pushed
the
nix-mfg-code-search-record
branch
from
January 13, 2022 01:49
cffa6fe
to
8813435
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns and
msandstedt
January 13, 2022 01:50
pullapprove
bot
requested review from
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
January 13, 2022 01:50
PR #13521: Size comparison from 8093b77 to 8813435 Increases (1 build for esp32)
Decreases (24 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 13, 2022
msandstedt
approved these changes
Jan 13, 2022
woody-apple
approved these changes
Jan 13, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…project-chip#13521) It's only written, never read. The emberAfReadSequentialAttributesAddToResponse function that was one of the writers is unused, so removing that too.
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…project-chip#13521) It's only written, never read. The emberAfReadSequentialAttributesAddToResponse function that was one of the writers is unused, so removing that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only written, never read.
The emberAfReadSequentialAttributesAddToResponse function that was one
of the writers is unused, so removing that too.
Problem
Dead code.
Change overview
Remove dead code.
Testing
No behavior changes.