Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group] Fix group messaging after test were disabled #13505

Merged
merged 4 commits into from
Jan 12, 2022
Merged

[Group] Fix group messaging after test were disabled #13505

merged 4 commits into from
Jan 12, 2022

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • Group messaging tests were disabled in master which caused subsequent PRs to break group messaging without anyone realising it

Change overview

  • Enabled group messaging test with extra documentation for the test
  • Fix group messaging

Testing

  • Manual testing
  • Automated testing to confirm group messaging was fixed
  • Automated testing to confirm no regressions were caused

bzbarsky-apple
bzbarsky-apple approved these changes Jan 12, 2022
View reviewed changes
src/app/CommandHandler.cpp Show resolved Hide resolved
examples/chip-tool/commands/common/CommandInvoker.h Show resolved Hide resolved
src/transport/GroupSession.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR #13505: Size comparison from 34e4032 to 4bea3ec

Increases (5 builds for k32w, qpg, telink)
platform target config section 34e4032 4bea3ec change % change
k32w light k32w061+release (read/write) 656636 656948 312 0.0
.text 572160 572472 312 0.1
lock k32w061+release (read/write) 660980 661232 252 0.0
.text 576188 576440 252 0.0
qpg lighting-app qpg6105+debug (read only) 534716 534976 260 0.0
.text 529396 529656 260 0.0
lock-app qpg6105+debug (read only) 506636 506896 260 0.1
.text 501316 501576 260 0.1
telink lighting-app tlsr9518adk80d (read/write) 836102 836498 396 0.0
text 583852 584158 306 0.1
Full report (6 builds for k32w, qpg, telink)
platform target config section 34e4032 4bea3ec change % change
k32w light k32w061+release (read/write) 656636 656948 312 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572160 572472 312 0.1
lock k32w061+release (read/write) 660980 661232 252 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576188 576440 252 0.0
qpg lighting-app qpg6105+debug (read only) 534716 534976 260 0.0
(read/write) 146940 146940 0 0.0
.bss 89024 89024 0 0.0
.data 1008 1008 0 0.0
.text 529396 529656 260 0.0
lock-app qpg6105+debug (read only) 506636 506896 260 0.1
(read/write) 146936 146936 0 0.0
.bss 88160 88160 0 0.0
.data 956 956 0 0.0
.text 501316 501576 260 0.1
persistent-storage-app qpg6105+debug (read only) 106832 106832 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101512 101512 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836102 836498 396 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583852 584158 306 0.1

@mkardous-silabs mkardous-silabs mentioned this pull request Jan 12, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR #13505: Size comparison from 34e4032 to 762a1d1

Increases above 0.2%:

platform target config section 34e4032 762a1d1 change % change
linux chip-tool-ipv6only arm64 .data.rel.ro 227000 227816 816 0.4
Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 34e4032 762a1d1 change % change
efr32 lighting-app BRD4161A (read only) 830532 831188 656 0.1
.text 830524 831180 656 0.1
BRD4161A+rpc (read only) 817936 818592 656 0.1
.text 817928 818584 656 0.1
window-app BRD4161A (read only) 804476 805068 592 0.1
.text 804468 805060 592 0.1
esp32 all-clusters-app c3devkit (read only) 908118 908432 314 0.0
(read/write) 1315962 1316058 96 0.0
.flash.rodata 178016 178112 96 0.1
.flash.text 908118 908432 314 0.0
m5stack (read only) 956875 957171 296 0.0
(read/write) 448128 448216 88 0.0
.flash.rodata 207296 207384 88 0.0
.flash.text 951491 951787 296 0.0
k32w light k32w061+release (read/write) 656636 656948 312 0.0
.text 572160 572472 312 0.1
lock k32w061+release (read/write) 660980 661232 252 0.0
.text 576188 576440 252 0.0
linux chip-tool-ipv6only arm64 (read only) 7207756 7215132 7376 0.1
(read/write) 345073 345921 848 0.2
.data.rel.ro 227000 227816 816 0.4
.got 58416 58440 24 0.0
.rodata 392228 392436 208 0.1
.text 6083172 6089444 6272 0.1
thermostat-no-ble arm64 (read only) 2038540 2039564 1024 0.1
(read/write) 145505 145601 96 0.1
.data.rel.ro 72912 73008 96 0.1
.rodata 129628 129756 128 0.1
.text 1694608 1695264 656 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2345840 2346192 352 0.0
.text 1308416 1308768 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330808 2331152 344 0.0
.text 1293408 1293752 344 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2304032 2304376 344 0.0
.text 1266632 1266976 344 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2054232 2054392 160 0.0
.text 1016832 1016992 160 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939571 939919 348 0.0
rodata 108448 108540 92 0.1
text 634268 634524 256 0.0
nrf52840dk_nrf52840+rpc (read/write) 925039 925383 344 0.0
rodata 100900 100988 88 0.1
text 629624 629880 256 0.0
nrf52840dongle_nrf52840 (read/write) 990247 990595 348 0.0
rodata 113200 113292 92 0.1
text 666468 666724 256 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849430 849774 344 0.0
rodata 101624 101712 88 0.1
text 551192 551448 256 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911843 912191 348 0.0
rodata 103720 103812 92 0.1
text 612260 612516 256 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821882 822226 344 0.0
rodata 96948 97036 88 0.1
text 529224 529480 256 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913123 913467 344 0.0
rodata 103936 104024 88 0.1
text 613520 613776 256 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909923 910271 348 0.0
rodata 103192 103284 92 0.1
text 611012 611268 256 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798607 168 0.0
rodata 78284 78372 88 0.1
text 533880 533964 84 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711426 172 0.0
rodata 72584 72676 92 0.1
text 451560 451644 84 0.0
p6 all-clusters-app default (read/write) 2399688 2400256 568 0.0
.text 1357952 1358520 568 0.0
light-app default (read/write) 2325376 2325960 584 0.0
.text 1283640 1284224 584 0.0
lock-app default (read/write) 2297600 2298184 584 0.0
.text 1255864 1256448 584 0.0
qpg lighting-app qpg6105+debug (read only) 534716 534976 260 0.0
.text 529396 529656 260 0.0
lock-app qpg6105+debug (read only) 506636 506896 260 0.1
.text 501316 501576 260 0.1
telink lighting-app tlsr9518adk80d (read/write) 836102 836498 396 0.0
text 583852 584158 306 0.1
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 34e4032 762a1d1 change % change
efr32 lighting-app BRD4161A (read only) 830532 831188 656 0.1
(read/write) 127300 127300 0 0.0
.bss 125420 125420 0 0.0
.data 1880 1880 0 0.0
.text 830524 831180 656 0.1
BRD4161A+rpc (read only) 817936 818592 656 0.1
(read/write) 143964 143964 0 0.0
.bss 141980 141980 0 0.0
.data 1980 1980 0 0.0
.text 817928 818584 656 0.1
window-app BRD4161A (read only) 804476 805068 592 0.1
(read/write) 126004 126004 0 0.0
.bss 124168 124168 0 0.0
.data 1836 1836 0 0.0
.text 804468 805060 592 0.1
esp32 all-clusters-app c3devkit (read only) 908118 908432 314 0.0
(read/write) 1315962 1316058 96 0.0
.dram0.bss 70176 70176 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178016 178112 96 0.1
.flash.text 908118 908432 314 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 956875 957171 296 0.0
(read/write) 448128 448216 88 0.0
.dram0.bss 74640 74640 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 207296 207384 88 0.0
.flash.text 951491 951787 296 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656636 656948 312 0.0
.bss 76824 76824 0 0.0
.data 1852 1852 0 0.0
.text 572160 572472 312 0.1
lock k32w061+release (read/write) 660980 661232 252 0.0
.bss 77120 77120 0 0.0
.data 1872 1872 0 0.0
.text 576188 576440 252 0.0
linux chip-tool-ipv6only arm64 (read only) 7207756 7215132 7376 0.1
(read/write) 345073 345921 848 0.2
.bss 54865 54865 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 227000 227816 816 0.4
.dynamic 560 560 0 0.0
.got 58416 58440 24 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 392228 392436 208 0.1
.text 6083172 6089444 6272 0.1
thermostat-no-ble arm64 (read only) 2038540 2039564 1024 0.1
(read/write) 145505 145601 96 0.1
.bss 64737 64737 0 0.0
.data 880 880 0 0.0
.data.rel.ro 72912 73008 96 0.1
.dynamic 560 560 0 0.0
.got 4040 4040 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129628 129756 128 0.1
.text 1694608 1695264 656 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2345840 2346192 352 0.0
.bss 188876 188876 0 0.0
.data 5320 5320 0 0.0
.text 1308416 1308768 352 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330808 2331152 344 0.0
.bss 180416 180416 0 0.0
.data 5552 5552 0 0.0
.text 1293408 1293752 344 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304032 2304376 344 0.0
.bss 179456 179456 0 0.0
.data 5544 5544 0 0.0
.text 1266632 1266976 344 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054232 2054392 160 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016832 1016992 160 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 939571 939919 348 0.0
bss 119284 119284 0 0.0
rodata 108448 108540 92 0.1
text 634268 634524 256 0.0
nrf52840dk_nrf52840+rpc (read/write) 925039 925383 344 0.0
bss 116328 116328 0 0.0
rodata 100900 100988 88 0.1
text 629624 629880 256 0.0
nrf52840dongle_nrf52840 (read/write) 990247 990595 348 0.0
bss 122128 122128 0 0.0
rodata 113200 113292 92 0.1
text 666468 666724 256 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849430 849774 344 0.0
bss 116072 116072 0 0.0
rodata 101624 101712 88 0.1
text 551192 551448 256 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911843 912191 348 0.0
bss 118472 118472 0 0.0
rodata 103720 103812 92 0.1
text 612260 612516 256 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821882 822226 344 0.0
bss 115288 115288 0 0.0
rodata 96948 97036 88 0.1
text 529224 529480 256 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913123 913467 344 0.0
bss 118232 118232 0 0.0
rodata 103936 104024 88 0.1
text 613520 613776 256 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909923 910271 348 0.0
bss 118260 118260 0 0.0
rodata 103192 103284 92 0.1
text 611012 611268 256 0.0
shell nrf52840dk_nrf52840 (read/write) 798439 798607 168 0.0
bss 109776 109776 0 0.0
rodata 78284 78372 88 0.1
text 533880 533964 84 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711254 711426 172 0.0
bss 107664 107664 0 0.0
rodata 72584 72676 92 0.1
text 451560 451644 84 0.0
p6 all-clusters-app default (read/write) 2399688 2400256 568 0.0
.bss 117148 117148 0 0.0
.data 2592 2592 0 0.0
.text 1357952 1358520 568 0.0
light-app default (read/write) 2325376 2325960 584 0.0
.bss 105728 105728 0 0.0
.data 2384 2384 0 0.0
.text 1283640 1284224 584 0.0
lock-app default (read/write) 2297600 2298184 584 0.0
.bss 104608 104608 0 0.0
.data 2344 2344 0 0.0
.text 1255864 1256448 584 0.0
qpg lighting-app qpg6105+debug (read only) 534716 534976 260 0.0
(read/write) 146940 146940 0 0.0
.bss 89024 89024 0 0.0
.data 1008 1008 0 0.0
.text 529396 529656 260 0.0
lock-app qpg6105+debug (read only) 506636 506896 260 0.1
(read/write) 146936 146936 0 0.0
.bss 88160 88160 0 0.0
.data 956 956 0 0.0
.text 501316 501576 260 0.1
persistent-storage-app qpg6105+debug (read only) 106832 106832 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101512 101512 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 836102 836498 396 0.0
bss 86976 86976 0 0.0
noinit 37160 37160 0 0.0
text 583852 584158 306 0.1

@bzbarsky-apple bzbarsky-apple merged commit 325b46c into project-chip:master Jan 12, 2022
@mkardous-silabs mkardous-silabs deleted the fix/group_messaging branch January 12, 2022 21:07
mkardous-silabs added a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 13, 2022
@mkardous-silabs
[Group] Fix group messaging after test were disabled (project-chip#13505
9200f92 
)

* Fix Group Messaging

* generated files

* zap generation error

* comment clean up
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@mkardous-silabs @selissia
[Group] Fix group messaging after test were disabled (project-chip#13505
510673e 
)

* Fix Group Messaging

* generated files

* zap generation error

* comment clean up
step0035 pushed a commit to hank820/connectedhomeip that referenced this pull request Feb 8, 2022
@mkardous-silabs @step0035
[Group] Fix group messaging after test were disabled (project-chip#13505
5f1becb 
)

* Fix Group Messaging

* generated files

* zap generation error

* comment clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples openthread platform review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkardous-silabs @tcarmelveilleux @bzbarsky-apple @jepenven-silabs