Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ObjectPool leaks in InteractionModelEngine #12702

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix ObjectPool leaks in InteractionModelEngine #12702

merged 1 commit into from
Dec 8, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Fixes #12504 ObjectPool leaks in InteractionModelEngine

Change overview

Call ReleaseAll() in InteractionModelEngine::Shutdown();
since the comments there indicate that was the intent.

Testing

CI; no changes to external functionality.

@kpschoedel
Fix ObjectPool leaks in InteractionModelEngine
aa3d709 
#### Problem

Fixes project-chip#12504 ObjectPool leaks in InteractionModelEngine

#### Change overview

Call `ReleaseAll()` in `InteractionModelEngine::Shutdown()`;
since the comments there indicate that was the intent.

#### Testing

CI; no changes to external functionality.
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12702: Size comparison from 9364cc6 to aa3d709

Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9364cc6 aa3d7095 change % change
efr32 lighting-app BRD4161A (read only) 793664 793760 96 0.0
.text 793656 793752 96 0.0
BRD4161A+rpc (read only) 821696 821776 80 0.0
.text 821688 821768 80 0.0
lock-app BRD4161A (read only) 768276 768372 96 0.0
.text 768268 768364 96 0.0
window-app BRD4161A (read only) 770544 770640 96 0.0
.text 770536 770632 96 0.0
esp32 all-clusters-app c3devkit (read only) 850778 850828 50 0.0
.flash.text 850778 850828 50 0.0
m5stack (read only) 954087 954123 36 0.0
.flash.text 948703 948739 36 0.0
k32w lighting-app k32w061+se05x+release (read/write) 729108 729156 48 0.0
.text 642152 642200 48 0.0
lock-app k32w061+debug (read/write) 619692 619740 48 0.0
.text 542104 542152 48 0.0
shell k32w061+debug (read/write) 685624 685672 48 0.0
.text 596428 596476 48 0.0
linux all-clusters-app debug (read only) 1883233 1883377 144 0.0
.text 1582242 1582386 144 0.0
bridge-app debug+rpc (read only) 1444581 1444725 144 0.0
.text 1216229 1216373 144 0.0
chip-tool debug (read only) 6689229 6689293 64 0.0
.text 5944677 5944741 64 0.0
lighting-app debug+rpc (read only) 1732329 1732473 144 0.0
.text 1445330 1445474 144 0.0
ota-provider-app debug (read only) 1408993 1409137 144 0.0
.text 1179538 1179682 144 0.0
ota-requestor-app debug (read only) 1513745 1513889 144 0.0
.text 1267666 1267810 144 0.0
tv-app debug (read only) 2040977 2041041 64 0.0
.text 1709826 1709890 64 0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2297960 2298024 64 0.0
.text 1260560 1260624 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2270944 2271008 64 0.0
.text 1233544 1233608 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 893479 893543 64 0.0
text 604192 604248 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 856487 856535 48 0.0
text 578920 578976 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 819422 819470 48 0.0
text 534564 534620 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 865915 865963 48 0.0
text 583448 583500 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 792102 792166 64 0.0
text 513912 513968 56 0.0
pump-app nrf52840dk_nrf52840 (read/write) 870767 870831 64 0.0
text 586964 587020 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864007 864055 48 0.0
text 582184 582236 52 0.0
p6 all-clusters-app default (read/write) 2343984 2344064 80 0.0
.text 1302248 1302328 80 0.0
light-app default (read/write) 2280048 2280144 96 0.0
.text 1238312 1238408 96 0.0
lock-app default (read/write) 2256136 2256232 96 0.0
.text 1214400 1214496 96 0.0
qpg lighting-app qpg6100+debug (read only) 510796 510844 48 0.0
.text 505476 505524 48 0.0
lock-app qpg6100+debug (read only) 484980 485036 56 0.0
.text 479660 479716 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 796546 796594 48 0.0
text 556254 556304 50 0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9364cc6 aa3d7095 change % change
efr32 lighting-app BRD4161A (read only) 793664 793760 96 0.0
(read/write) 120552 120552 0 0.0
.bss 118728 118728 0 0.0
.data 1820 1820 0 0.0
.text 793656 793752 96 0.0
BRD4161A+rpc (read only) 821696 821776 80 0.0
(read/write) 138856 138856 0 0.0
.bss 136928 136928 0 0.0
.data 1928 1928 0 0.0
.text 821688 821768 80 0.0
lock-app BRD4161A (read only) 768276 768372 96 0.0
(read/write) 118484 118484 0 0.0
.bss 116704 116704 0 0.0
.data 1780 1780 0 0.0
.text 768268 768364 96 0.0
window-app BRD4161A (read only) 770544 770640 96 0.0
(read/write) 118688 118688 0 0.0
.bss 116904 116904 0 0.0
.data 1784 1784 0 0.0
.text 770536 770632 96 0.0
esp32 all-clusters-app c3devkit (read only) 850778 850828 50 0.0
(read/write) 1233154 1233154 0 0.0
.dram0.bss 61104 61104 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 170432 170432 0 0.0
.flash.text 850778 850828 50 0.0
.iram0.text 62028 62028 0 0.0
m5stack (read only) 954087 954123 36 0.0
(read/write) 442956 442956 0 0.0
.dram0.bss 68456 68456 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 208664 208664 0 0.0
.flash.text 948703 948739 36 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 729108 729156 48 0.0
.bss 79304 79304 0 0.0
.data 1852 1852 0 0.0
.text 642152 642200 48 0.0
lock-app k32w061+debug (read/write) 619692 619740 48 0.0
.bss 69968 69968 0 0.0
.data 1820 1820 0 0.0
.text 542104 542152 48 0.0
shell k32w061+debug (read/write) 685624 685672 48 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596428 596476 48 0.0
linux all-clusters-app debug (read only) 1883233 1883377 144 0.0
(read/write) 128800 128800 0 0.0
.bss 54032 54032 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68096 68096 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155492 155492 0 0.0
.text 1582242 1582386 144 0.0
bridge-app debug+rpc (read only) 1444581 1444725 144 0.0
(read/write) 74992 74992 0 0.0
.bss 36464 36464 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31728 31728 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123308 123308 0 0.0
.text 1216229 1216373 144 0.0
chip-tool debug (read only) 6689229 6689293 64 0.0
(read/write) 201632 201632 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160280 160280 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335625 335625 0 0.0
.text 5944677 5944741 64 0.0
lighting-app debug+rpc (read only) 1732329 1732473 144 0.0
(read/write) 108056 108056 0 0.0
.bss 42160 42160 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 59248 59248 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144188 144188 0 0.0
.text 1445330 1445474 144 0.0
ota-provider-app debug (read only) 1408993 1409137 144 0.0
(read/write) 72968 72968 0 0.0
.bss 38976 38976 0 0.0
.data 896 896 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124718 124718 0 0.0
.text 1179538 1179682 144 0.0
ota-requestor-app debug (read only) 1513745 1513889 144 0.0
(read/write) 78016 78016 0 0.0
.bss 42144 42144 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29688 29688 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137439 137439 0 0.0
.text 1267666 1267810 144 0.0
shell debug (read only) 828593 828593 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85970 85970 0 0.0
.text 635522 635522 0 0.0
tv-app debug (read only) 2040977 2041041 64 0.0
(read/write) 321400 321400 0 0.0
.bss 248504 248504 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64336 64336 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176292 176292 0 0.0
.text 1709826 1709890 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2310904 2310904 0 0.0
.bss 184452 184452 0 0.0
.data 5232 5232 0 0.0
.heap 846760 846760 0 0.0
.text 1273480 1273480 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2297960 2298024 64 0.0
.bss 173256 173256 0 0.0
.data 5488 5488 0 0.0
.heap 857704 857704 0 0.0
.text 1260560 1260624 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270944 2271008 64 0.0
.bss 172304 172304 0 0.0
.data 5488 5488 0 0.0
.heap 858656 858656 0 0.0
.text 1233544 1233608 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047992 2047992 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010592 1010592 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 893479 893543 64 0.0
bss 113732 113732 0 0.0
rodata 99984 99984 0 0.0
text 604192 604248 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 856487 856535 48 0.0
bss 110080 110080 0 0.0
rodata 91280 91280 0 0.0
text 578920 578976 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 819422 819470 48 0.0
bss 115108 115108 0 0.0
rodata 95240 95240 0 0.0
text 534564 534620 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 865915 865963 48 0.0
bss 110996 110996 0 0.0
rodata 96100 96100 0 0.0
text 583448 583500 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 792102 792166 64 0.0
bss 112404 112404 0 0.0
rodata 91392 91392 0 0.0
text 513912 513968 56 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 870767 870831 64 0.0
bss 110908 110908 0 0.0
rodata 97456 97456 0 0.0
text 586964 587020 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864007 864055 48 0.0
bss 110784 110784 0 0.0
rodata 95592 95592 0 0.0
text 582184 582236 52 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523268 523268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443908 443908 0 0.0
p6 all-clusters-app default (read/write) 2343984 2344064 80 0.0
.bss 110676 110676 0 0.0
.data 2512 2512 0 0.0
.heap 920152 920152 0 0.0
.text 1302248 1302328 80 0.0
light-app default (read/write) 2280048 2280144 96 0.0
.bss 98448 98448 0 0.0
.data 2328 2328 0 0.0
.heap 932568 932568 0 0.0
.text 1238312 1238408 96 0.0
lock-app default (read/write) 2256136 2256232 96 0.0
.bss 97328 97328 0 0.0
.data 2288 2288 0 0.0
.heap 933728 933728 0 0.0
.text 1214400 1214496 96 0.0
qpg lighting-app qpg6100+debug (read only) 510796 510844 48 0.0
(read/write) 122332 122332 0 0.0
.bss 80176 80176 0 0.0
.data 956 956 0 0.0
.text 505476 505524 48 0.0
lock-app qpg6100+debug (read only) 484980 485036 56 0.0
(read/write) 122336 122336 0 0.0
.bss 79312 79312 0 0.0
.data 912 912 0 0.0
.text 479660 479716 56 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 796546 796594 48 0.0
bss 80312 80312 0 0.0
noinit 37160 37160 0 0.0
text 556254 556304 50 0.0

@andy31415
Copy link
Contributor

fast track: has several checkmarks, change up for sufficient time for cross timezone review

@andy31415 andy31415 merged commit 0aedea7 into project-chip:master Dec 8, 2021
@kpschoedel kpschoedel deleted the x12504-ime branch December 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ObjectPool leaks in InteractionModelEngine
4 participants
@kpschoedel @andy31415 @yunhanw-google @woody-apple