Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access control cluster server improvements #12690

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Access control cluster server improvements #12690

merged 5 commits into from
Dec 8, 2021

Conversation

mlepage-google
Copy link
Contributor

Problem

Various cleanup needs to occur.

Change overview

Housekeeping in access control cluster server code.

  • move implementation into anonymous namespace
  • handle more errors during list encode
  • move extension attribute storage to external (still not implemented)
  • move cluster revision storage to external

Testing

Regen, restyle, full build, unit tests.

@mlepage-google
Access control cluster server improvements
4155b51 
- move implementation into anonymous namespace
- handle more errors during list encode
- move extension attribute storage to external (still not implemented)
- move cluster revision storage to external
@mlepage-google mlepage-google mentioned this pull request Dec 7, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

PR #12690: Size comparison from 051685b to 4155b51

Increases above 0.2%:

platform target config section 051685b 4155b51 change % change
linux all-clusters-app debug (read only) 1907689 1917777 10088 0.5
.rodata 156277 157141 864 0.6
.text 1605570 1614818 9248 0.6
Increases (2 builds for linux, p6)
platform target config section 051685b 4155b51 change % change
linux all-clusters-app debug (read only) 1907689 1917777 10088 0.5
(read/write) 128896 128928 32 0.0
.bss 54032 54064 32 0.1
.data.rel.ro 68192 68208 16 0.0
.rodata 156277 157141 864 0.6
.text 1605570 1614818 9248 0.6
p6 all-clusters-app default (read/write) 2353392 2355696 2304 0.1
.text 1311656 1313960 2304 0.2
Full report (15 builds for efr32, linux, p6)
platform target config section 051685b 4155b51 change % change
efr32 lighting-app BRD4161A (read only) 798156 798156 0 0.0
(read/write) 120548 120548 0 0.0
.bss 118720 118720 0 0.0
.data 1828 1828 0 0.0
.text 798148 798148 0 0.0
lock-app BRD4161A (read only) 772832 772832 0 0.0
(read/write) 118488 118488 0 0.0
.bss 116696 116696 0 0.0
.data 1788 1788 0 0.0
.text 772824 772824 0 0.0
window-app BRD4161A (read only) 775104 775104 0 0.0
(read/write) 118688 118688 0 0.0
.bss 116896 116896 0 0.0
.data 1792 1792 0 0.0
.text 775096 775096 0 0.0
lighting-app BRD4161A+rpc (read only) 826116 826116 0 0.0
(read/write) 138856 138856 0 0.0
.bss 136920 136920 0 0.0
.data 1936 1936 0 0.0
.text 826108 826108 0 0.0
linux all-clusters-app debug (read only) 1907689 1917777 10088 0.5
(read/write) 128896 128928 32 0.0
.bss 54032 54064 32 0.1
.data 1216 1216 0 0.0
.data.rel.ro 68192 68208 16 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 157141 864 0.6
.text 1605570 1614818 9248 0.6
chip-tool debug (read only) 6687597 6687597 0 0.0
(read/write) 201728 201728 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160376 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335721 0 0.0
.text 5942613 5942613 0 0.0
ota-provider-app debug (read only) 1411953 1411953 0 0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181794 1181794 0 0.0
ota-requestor-app debug (read only) 1516705 1516705 0 0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269922 1269922 0 0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2056201 2056201 0 0.0
(read/write) 320504 320504 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 176828 0 0.0
.text 1724178 1724178 0 0.0
bridge-app debug+rpc (read only) 1456485 1456485 0 0.0
(read/write) 75088 75088 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31824 31824 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 123932 0 0.0
.text 1227173 1227173 0 0.0
lighting-app debug+rpc (read only) 1742289 1742289 0 0.0
(read/write) 108152 108152 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59344 59344 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 144529 0 0.0
.text 1454610 1454610 0 0.0
p6 all-clusters-app default (read/write) 2353392 2355696 2304 0.1
.bss 110668 110668 0 0.0
.data 2520 2520 0 0.0
.heap 920152 920152 0 0.0
.text 1311656 1313960 2304 0.2
light-app default (read/write) 2284536 2284536 0 0.0
.bss 98440 98440 0 0.0
.data 2336 2336 0 0.0
.heap 932568 932568 0 0.0
.text 1242800 1242800 0 0.0
lock-app default (read/write) 2260688 2260688 0 0.0
.bss 97320 97320 0 0.0
.data 2296 2296 0 0.0
.heap 933728 933728 0 0.0
.text 1218952 1218952 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

PR #12690: Size comparison from 051685b to 1c321cb

Decreases (3 builds for k32w, qpg, telink)
platform target config section 051685b 1c321cb change % change
k32w lighting-app k32w061+se05x+release (read/write) 732484 730716 -1768 -0.2
.text 645528 643760 -1768 -0.3
qpg lighting-app qpg6100+debug (read only) 514144 512388 -1756 -0.3
.bss 80168 80160 -8 -0.0
.text 508824 507068 -1756 -0.3
telink lighting-app tlsr9518adk80d (read/write) 799870 797814 -2056 -0.3
text 559130 557304 -1826 -0.3
Full report (7 builds for k32w, qpg, telink)
platform target config section 051685b 1c321cb change % change
k32w lock-app k32w061+debug (read/write) 623164 623164 0 0.0
.bss 69960 69960 0 0.0
.data 1828 1828 0 0.0
.text 545576 545576 0 0.0
shell k32w061+debug (read/write) 689084 689084 0 0.0
.bss 81596 81596 0 0.0
.data 1800 1800 0 0.0
.text 599888 599888 0 0.0
lighting-app k32w061+se05x+release (read/write) 732484 730716 -1768 -0.2
.bss 79296 79296 0 0.0
.data 1860 1860 0 0.0
.text 645528 643760 -1768 -0.3
qpg lighting-app qpg6100+debug (read only) 514144 512388 -1756 -0.3
(read/write) 122332 122332 0 0.0
.bss 80168 80160 -8 -0.0
.data 964 964 0 0.0
.text 508824 507068 -1756 -0.3
lock-app qpg6100+debug (read only) 488448 488448 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 483128 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 797814 -2056 -0.3
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 557304 -1826 -0.3

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12690: Size comparison from 051685b to 1e2b34c

Increases (5 builds for esp32, linux, mbed, p6)
platform target config section 051685b 1e2b34c change % change
esp32 all-clusters-app c3devkit (read only) 856796 856906 110 0.0
.flash.text 856796 856906 110 0.0
m5stack (read only) 960115 960359 244 0.0
.flash.text 954731 954975 244 0.0
linux all-clusters-app debug (read only) 1907689 1908753 1064 0.1
.data.rel.ro 68192 68208 16 0.0
.text 1605570 1606658 1088 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2317160 2317352 192 0.0
.heap 846760 846768 8 0.0
.text 1279736 1279928 192 0.0
p6 all-clusters-app default (read/write) 2353392 2353624 232 0.0
.text 1311656 1311888 232 0.0
Decreases (3 builds for esp32, mbed)
platform target config section 051685b 1e2b34c change % change
esp32 all-clusters-app c3devkit (read/write) 1298938 1298922 -16 -0.0
.dram0.bss 61096 61088 -8 -0.0
m5stack (read/write) 443244 443236 -8 -0.0
.dram0.bss 68448 68440 -8 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 184444 184436 -8 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 1e2b34c change % change
efr32 lighting-app BRD4161A (read only) 798156 798156 0 0.0
(read/write) 120548 120548 0 0.0
.bss 118720 118720 0 0.0
.data 1828 1828 0 0.0
.text 798148 798148 0 0.0
BRD4161A+rpc (read only) 826116 826116 0 0.0
(read/write) 138856 138856 0 0.0
.bss 136920 136920 0 0.0
.data 1936 1936 0 0.0
.text 826108 826108 0 0.0
lock-app BRD4161A (read only) 772832 772832 0 0.0
(read/write) 118488 118488 0 0.0
.bss 116696 116696 0 0.0
.data 1788 1788 0 0.0
.text 772824 772824 0 0.0
window-app BRD4161A (read only) 775104 775104 0 0.0
(read/write) 118688 118688 0 0.0
.bss 116896 116896 0 0.0
.data 1792 1792 0 0.0
.text 775096 775096 0 0.0
esp32 all-clusters-app c3devkit (read only) 856796 856906 110 0.0
(read/write) 1298938 1298922 -16 -0.0
.dram0.bss 61096 61088 -8 -0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170664 170664 0 0.0
.flash.text 856796 856906 110 0.0
.iram0.text 62028 62028 0 0.0
m5stack (read only) 960115 960359 244 0.0
(read/write) 443244 443236 -8 -0.0
.dram0.bss 68448 68440 -8 -0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208952 208952 0 0.0
.flash.text 954731 954975 244 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732484 732484 0 0.0
.bss 79296 79296 0 0.0
.data 1860 1860 0 0.0
.text 645528 645528 0 0.0
lock-app k32w061+debug (read/write) 623164 623164 0 0.0
.bss 69960 69960 0 0.0
.data 1828 1828 0 0.0
.text 545576 545576 0 0.0
shell k32w061+debug (read/write) 689084 689084 0 0.0
.bss 81596 81596 0 0.0
.data 1800 1800 0 0.0
.text 599888 599888 0 0.0
linux all-clusters-app debug (read only) 1907689 1908753 1064 0.1
(read/write) 128896 128896 0 0.0
.bss 54032 54032 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 68192 68208 16 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 156277 0 0.0
.text 1605570 1606658 1088 0.1
bridge-app debug+rpc (read only) 1456485 1456485 0 0.0
(read/write) 75088 75088 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31824 31824 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 123932 0 0.0
.text 1227173 1227173 0 0.0
chip-tool debug (read only) 6687597 6687597 0 0.0
(read/write) 201728 201728 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160376 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335721 0 0.0
.text 5942613 5942613 0 0.0
lighting-app debug+rpc (read only) 1742289 1742289 0 0.0
(read/write) 108152 108152 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59344 59344 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 144529 0 0.0
.text 1454610 1454610 0 0.0
ota-provider-app debug (read only) 1411953 1411953 0 0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181794 1181794 0 0.0
ota-requestor-app debug (read only) 1516705 1516705 0 0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269922 1269922 0 0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2056201 2056201 0 0.0
(read/write) 320504 320504 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64432 64432 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 176828 0 0.0
.text 1724178 1724178 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317160 2317352 192 0.0
.bss 184444 184436 -8 -0.0
.data 5240 5240 0 0.0
.heap 846760 846768 8 0.0
.text 1279736 1279928 192 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300992 2300992 0 0.0
.bss 173248 173248 0 0.0
.data 5496 5496 0 0.0
.heap 857704 857704 0 0.0
.text 1263592 1263592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274032 2274032 0 0.0
.bss 172296 172296 0 0.0
.data 5496 5496 0 0.0
.heap 858656 858656 0 0.0
.text 1236632 1236632 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048008 2048008 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010608 1010608 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 896707 0 0.0
bss 113724 113724 0 0.0
rodata 100308 100308 0 0.0
text 607112 607112 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859643 859643 0 0.0
bss 110072 110072 0 0.0
rodata 91500 91500 0 0.0
text 581848 581848 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822638 822638 0 0.0
bss 115100 115100 0 0.0
rodata 95568 95568 0 0.0
text 537480 537480 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869275 869275 0 0.0
bss 110988 110988 0 0.0
rodata 96428 96428 0 0.0
text 586468 586468 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795458 795458 0 0.0
bss 112396 112396 0 0.0
rodata 91716 91716 0 0.0
text 516932 516932 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874027 874027 0 0.0
bss 110900 110900 0 0.0
rodata 97780 97780 0 0.0
text 589884 589884 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 867235 0 0.0
bss 110776 110776 0 0.0
rodata 95916 95916 0 0.0
text 585092 585092 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781643 781643 0 0.0
bss 109552 109552 0 0.0
rodata 74296 74296 0 0.0
text 523284 523284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696718 0 0.0
bss 110532 110532 0 0.0
rodata 68936 68936 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2353392 2353624 232 0.0
.bss 110668 110668 0 0.0
.data 2520 2520 0 0.0
.heap 920152 920152 0 0.0
.text 1311656 1311888 232 0.0
light-app default (read/write) 2284536 2284536 0 0.0
.bss 98440 98440 0 0.0
.data 2336 2336 0 0.0
.heap 932568 932568 0 0.0
.text 1242800 1242800 0 0.0
lock-app default (read/write) 2260688 2260688 0 0.0
.bss 97320 97320 0 0.0
.data 2296 2296 0 0.0
.heap 933728 933728 0 0.0
.text 1218952 1218952 0 0.0
qpg lighting-app qpg6100+debug (read only) 514144 514144 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80168 80168 0 0.0
.data 964 964 0 0.0
.text 508824 508824 0 0.0
lock-app qpg6100+debug (read only) 488448 488448 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79304 79304 0 0.0
.data 920 920 0 0.0
.text 483128 483128 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 799870 0 0.0
bss 80304 80304 0 0.0
noinit 37160 37160 0 0.0
text 559130 559130 0 0.0

@mlepage-google
Fix iteration in ACL read
239fd7f 
Sentinel error is expected when iteration ends.
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12690: Size comparison from 051685b to 239fd7f

Increases above 0.2%:

platform target config section 051685b 239fd7f change % change
linux shell debug .rodata 85714 85970 256 0.3
tv-app debug (read/write) 320504 321400 896 0.3
.bss 247480 248504 1024 0.4
Increases (26 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 239fd7f change % change
efr32 lighting-app BRD4161A (read/write) 120548 120552 4 0.0
.bss 118720 118728 8 0.0
BRD4161A+rpc .bss 136920 136928 8 0.0
lock-app BRD4161A .bss 116696 116704 8 0.0
window-app BRD4161A .bss 116896 116904 8 0.0
k32w lighting-app k32w061+se05x+release .bss 79296 79304 8 0.0
lock-app k32w061+debug .bss 69960 69968 8 0.0
shell k32w061+debug .bss 81596 81604 8 0.0
linux chip-tool debug (read only) 6687597 6689229 1632 0.0
.text 5942613 5944677 2064 0.0
shell debug (read only) 827345 828593 1248 0.2
.got 3520 3528 8 0.2
.rodata 85714 85970 256 0.3
.text 634530 635522 992 0.2
tv-app debug (read/write) 320504 321400 896 0.3
.bss 247480 248504 1024 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846760 846768 8 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 173248 173256 8 0.0
lock-app CY8CPROTO_062_4343W+release .bss 172296 172304 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 113724 113732 8 0.0
nrf52840dk_nrf52840+rpc bss 110072 110080 8 0.0
nrf5340dk_nrf5340_cpuapp bss 115100 115108 8 0.0
lock-app nrf52840dk_nrf52840 bss 110988 110996 8 0.0
nrf5340dk_nrf5340_cpuapp bss 112396 112404 8 0.0
pump-app nrf52840dk_nrf52840 bss 110900 110908 8 0.0
pump-controller-app nrf52840dk_nrf52840 bss 110776 110784 8 0.0
p6 all-clusters-app default .bss 110668 110676 8 0.0
light-app default .bss 98440 98448 8 0.0
lock-app default .bss 97320 97328 8 0.0
qpg lighting-app qpg6100+debug .bss 80168 80176 8 0.0
lock-app qpg6100+debug .bss 79304 79312 8 0.0
telink lighting-app tlsr9518adk80d bss 80304 80312 8 0.0
Decreases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 239fd7f change % change
efr32 lighting-app BRD4161A (read only) 798156 793664 -4492 -0.6
.data 1828 1820 -8 -0.4
.text 798148 793656 -4492 -0.6
BRD4161A+rpc (read only) 826116 821696 -4420 -0.5
.data 1936 1928 -8 -0.4
.text 826108 821688 -4420 -0.5
lock-app BRD4161A (read only) 772832 768276 -4556 -0.6
(read/write) 118488 118484 -4 -0.0
.data 1788 1780 -8 -0.4
.text 772824 768268 -4556 -0.6
window-app BRD4161A (read only) 775104 770544 -4560 -0.6
.data 1792 1784 -8 -0.4
.text 775096 770536 -4560 -0.6
esp32 all-clusters-app c3devkit (read only) 856796 850916 -5880 -0.7
(read/write) 1298938 1233154 -65784 -5.1
.dram0.data 14132 14124 -8 -0.1
.flash.rodata 170664 170432 -232 -0.1
.flash.text 856796 850916 -5880 -0.7
m5stack (read only) 960115 954347 -5768 -0.6
(read/write) 443244 443020 -224 -0.1
.dram0.data 34056 34048 -8 -0.0
.flash.rodata 208952 208736 -216 -0.1
.flash.text 954731 948963 -5768 -0.6
k32w lighting-app k32w061+se05x+release (read/write) 732484 729108 -3376 -0.5
.data 1860 1852 -8 -0.4
.text 645528 642152 -3376 -0.5
lock-app k32w061+debug (read/write) 623164 619692 -3472 -0.6
.data 1828 1820 -8 -0.4
.text 545576 542104 -3472 -0.6
shell k32w061+debug (read/write) 689084 685624 -3460 -0.5
.data 1800 1792 -8 -0.4
.text 599888 596428 -3460 -0.6
linux all-clusters-app debug (read only) 1907689 1884473 -23216 -1.2
(read/write) 128896 128800 -96 -0.1
.data 1216 1200 -16 -1.3
.data.rel.ro 68192 68112 -80 -0.1
.rodata 156277 155492 -785 -0.5
.text 1605570 1583506 -22064 -1.4
bridge-app debug+rpc (read only) 1456485 1444581 -11904 -0.8
(read/write) 75088 74992 -96 -0.1
.data 1728 1712 -16 -0.9
.data.rel.ro 31824 31728 -96 -0.3
.rodata 123932 123308 -624 -0.5
.text 1227173 1216229 -10944 -0.9
chip-tool debug (read/write) 201728 201632 -96 -0.0
.data.rel.ro 160376 160280 -96 -0.1
.rodata 335721 335625 -96 -0.0
lighting-app debug+rpc (read only) 1742289 1732329 -9960 -0.6
(read/write) 108152 108056 -96 -0.1
.data 1280 1264 -16 -1.2
.data.rel.ro 59344 59248 -96 -0.2
.rodata 144529 144188 -341 -0.2
.text 1454610 1445330 -9280 -0.6
ota-provider-app debug (read only) 1411953 1408993 -2960 -0.2
(read/write) 73096 72968 -128 -0.2
.data 928 896 -32 -3.4
.data.rel.ro 28024 27928 -96 -0.3
.rodata 125086 124718 -368 -0.3
.text 1181794 1179538 -2256 -0.2
ota-requestor-app debug (read only) 1516705 1513745 -2960 -0.2
(read/write) 78144 78016 -128 -0.2
.data 992 960 -32 -3.2
.data.rel.ro 29784 29688 -96 -0.3
.rodata 137807 137439 -368 -0.3
.text 1269922 1267666 -2256 -0.2
shell debug (read/write) 60640 60608 -32 -0.1
.data.rel.ro 39032 39000 -32 -0.1
tv-app debug (read only) 2056201 2040977 -15224 -0.7
.data 2768 2736 -32 -1.2
.data.rel.ro 64432 64336 -96 -0.1
.rodata 176828 176292 -536 -0.3
.text 1724178 1709826 -14352 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2317160 2311096 -6064 -0.3
.data 5240 5232 -8 -0.2
.text 1279736 1273672 -6064 -0.5
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300992 2297960 -3032 -0.1
.data 5496 5488 -8 -0.1
.text 1263592 1260560 -3032 -0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2274032 2270944 -3088 -0.1
.data 5496 5488 -8 -0.1
.text 1236632 1233544 -3088 -0.2
shell CY8CPROTO_062_4343W+release (read/write) 2048008 2047992 -16 -0.0
.text 1010608 1010592 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 893479 -3228 -0.4
rodata 100308 99984 -324 -0.3
text 607112 604192 -2920 -0.5
nrf52840dk_nrf52840+rpc (read/write) 859643 856487 -3156 -0.4
rodata 91500 91280 -220 -0.2
text 581848 578920 -2928 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 822638 819422 -3216 -0.4
rodata 95568 95240 -328 -0.3
text 537480 534564 -2916 -0.5
lock-app nrf52840dk_nrf52840 (read/write) 869275 865915 -3360 -0.4
rodata 96428 96100 -328 -0.3
text 586468 583448 -3020 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 795458 792102 -3356 -0.4
rodata 91716 91392 -324 -0.4
text 516932 513912 -3020 -0.6
pump-app nrf52840dk_nrf52840 (read/write) 874027 870767 -3260 -0.4
rodata 97780 97456 -324 -0.3
text 589884 586964 -2920 -0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 864007 -3228 -0.4
rodata 95916 95592 -324 -0.3
text 585092 582184 -2908 -0.5
shell nrf52840dk_nrf52840 (read/write) 781643 781611 -32 -0.0
rodata 74296 74280 -16 -0.0
text 523284 523268 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696686 -32 -0.0
rodata 68936 68920 -16 -0.0
text 443924 443908 -16 -0.0
p6 all-clusters-app default (read/write) 2353392 2344224 -9168 -0.4
.data 2520 2512 -8 -0.3
.text 1311656 1302488 -9168 -0.7
light-app default (read/write) 2284536 2280048 -4488 -0.2
.data 2336 2328 -8 -0.3
.text 1242800 1238312 -4488 -0.4
lock-app default (read/write) 2260688 2256136 -4552 -0.2
.data 2296 2288 -8 -0.3
.text 1218952 1214400 -4552 -0.4
qpg lighting-app qpg6100+debug (read only) 514144 510796 -3348 -0.7
.data 964 956 -8 -0.8
.text 508824 505476 -3348 -0.7
lock-app qpg6100+debug (read only) 488448 484980 -3468 -0.7
.data 920 912 -8 -0.9
.text 483128 479660 -3468 -0.7
telink lighting-app tlsr9518adk80d (read/write) 799870 796546 -3324 -0.4
text 559130 556254 -2876 -0.5
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 051685b 239fd7f change % change
efr32 lighting-app BRD4161A (read only) 798156 793664 -4492 -0.6
(read/write) 120548 120552 4 0.0
.bss 118720 118728 8 0.0
.data 1828 1820 -8 -0.4
.text 798148 793656 -4492 -0.6
BRD4161A+rpc (read only) 826116 821696 -4420 -0.5
(read/write) 138856 138856 0 0.0
.bss 136920 136928 8 0.0
.data 1936 1928 -8 -0.4
.text 826108 821688 -4420 -0.5
lock-app BRD4161A (read only) 772832 768276 -4556 -0.6
(read/write) 118488 118484 -4 -0.0
.bss 116696 116704 8 0.0
.data 1788 1780 -8 -0.4
.text 772824 768268 -4556 -0.6
window-app BRD4161A (read only) 775104 770544 -4560 -0.6
(read/write) 118688 118688 0 0.0
.bss 116896 116904 8 0.0
.data 1792 1784 -8 -0.4
.text 775096 770536 -4560 -0.6
esp32 all-clusters-app c3devkit (read only) 856796 850916 -5880 -0.7
(read/write) 1298938 1233154 -65784 -5.1
.dram0.bss 61096 61096 0 0.0
.dram0.data 14132 14124 -8 -0.1
.flash.rodata 170664 170432 -232 -0.1
.flash.text 856796 850916 -5880 -0.7
.iram0.text 62028 62028 0 0.0
m5stack (read only) 960115 954347 -5768 -0.6
(read/write) 443244 443020 -224 -0.1
.dram0.bss 68448 68448 0 0.0
.dram0.data 34056 34048 -8 -0.0
.flash.rodata 208952 208736 -216 -0.1
.flash.text 954731 948963 -5768 -0.6
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732484 729108 -3376 -0.5
.bss 79296 79304 8 0.0
.data 1860 1852 -8 -0.4
.text 645528 642152 -3376 -0.5
lock-app k32w061+debug (read/write) 623164 619692 -3472 -0.6
.bss 69960 69968 8 0.0
.data 1828 1820 -8 -0.4
.text 545576 542104 -3472 -0.6
shell k32w061+debug (read/write) 689084 685624 -3460 -0.5
.bss 81596 81604 8 0.0
.data 1800 1792 -8 -0.4
.text 599888 596428 -3460 -0.6
linux all-clusters-app debug (read only) 1907689 1884473 -23216 -1.2
(read/write) 128896 128800 -96 -0.1
.bss 54032 54032 0 0.0
.data 1216 1200 -16 -1.3
.data.rel.ro 68192 68112 -80 -0.1
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 156277 155492 -785 -0.5
.text 1605570 1583506 -22064 -1.4
bridge-app debug+rpc (read only) 1456485 1444581 -11904 -0.8
(read/write) 75088 74992 -96 -0.1
.bss 36464 36464 0 0.0
.data 1728 1712 -16 -0.9
.data.rel.ro 31824 31728 -96 -0.3
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123932 123308 -624 -0.5
.text 1227173 1216229 -10944 -0.9
chip-tool debug (read only) 6687597 6689229 1632 0.0
(read/write) 201728 201632 -96 -0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160376 160280 -96 -0.1
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335721 335625 -96 -0.0
.text 5942613 5944677 2064 0.0
lighting-app debug+rpc (read only) 1742289 1732329 -9960 -0.6
(read/write) 108152 108056 -96 -0.1
.bss 42160 42160 0 0.0
.data 1280 1264 -16 -1.2
.data.rel.ro 59344 59248 -96 -0.2
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144529 144188 -341 -0.2
.text 1454610 1445330 -9280 -0.6
ota-provider-app debug (read only) 1411953 1408993 -2960 -0.2
(read/write) 73096 72968 -128 -0.2
.bss 38976 38976 0 0.0
.data 928 896 -32 -3.4
.data.rel.ro 28024 27928 -96 -0.3
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 124718 -368 -0.3
.text 1181794 1179538 -2256 -0.2
ota-requestor-app debug (read only) 1516705 1513745 -2960 -0.2
(read/write) 78144 78016 -128 -0.2
.bss 42144 42144 0 0.0
.data 992 960 -32 -3.2
.data.rel.ro 29784 29688 -96 -0.3
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137439 -368 -0.3
.text 1269922 1267666 -2256 -0.2
shell debug (read only) 827345 828593 1248 0.2
(read/write) 60640 60608 -32 -0.1
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39000 -32 -0.1
.dynamic 592 592 0 0.0
.got 3520 3528 8 0.2
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85970 256 0.3
.text 634530 635522 992 0.2
tv-app debug (read only) 2056201 2040977 -15224 -0.7
(read/write) 320504 321400 896 0.3
.bss 247480 248504 1024 0.4
.data 2768 2736 -32 -1.2
.data.rel.ro 64432 64336 -96 -0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176828 176292 -536 -0.3
.text 1724178 1709826 -14352 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2317160 2311096 -6064 -0.3
.bss 184444 184444 0 0.0
.data 5240 5232 -8 -0.2
.heap 846760 846768 8 0.0
.text 1279736 1273672 -6064 -0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300992 2297960 -3032 -0.1
.bss 173248 173256 8 0.0
.data 5496 5488 -8 -0.1
.heap 857704 857704 0 0.0
.text 1263592 1260560 -3032 -0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274032 2270944 -3088 -0.1
.bss 172296 172304 8 0.0
.data 5496 5488 -8 -0.1
.heap 858656 858656 0 0.0
.text 1236632 1233544 -3088 -0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048008 2047992 -16 -0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010608 1010592 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896707 893479 -3228 -0.4
bss 113724 113732 8 0.0
rodata 100308 99984 -324 -0.3
text 607112 604192 -2920 -0.5
nrf52840dk_nrf52840+rpc (read/write) 859643 856487 -3156 -0.4
bss 110072 110080 8 0.0
rodata 91500 91280 -220 -0.2
text 581848 578920 -2928 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 822638 819422 -3216 -0.4
bss 115100 115108 8 0.0
rodata 95568 95240 -328 -0.3
text 537480 534564 -2916 -0.5
lock-app nrf52840dk_nrf52840 (read/write) 869275 865915 -3360 -0.4
bss 110988 110996 8 0.0
rodata 96428 96100 -328 -0.3
text 586468 583448 -3020 -0.5
nrf5340dk_nrf5340_cpuapp (read/write) 795458 792102 -3356 -0.4
bss 112396 112404 8 0.0
rodata 91716 91392 -324 -0.4
text 516932 513912 -3020 -0.6
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874027 870767 -3260 -0.4
bss 110900 110908 8 0.0
rodata 97780 97456 -324 -0.3
text 589884 586964 -2920 -0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 867235 864007 -3228 -0.4
bss 110776 110784 8 0.0
rodata 95916 95592 -324 -0.3
text 585092 582184 -2908 -0.5
shell nrf52840dk_nrf52840 (read/write) 781643 781611 -32 -0.0
bss 109552 109552 0 0.0
rodata 74296 74280 -16 -0.0
text 523284 523268 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696686 -32 -0.0
bss 110532 110532 0 0.0
rodata 68936 68920 -16 -0.0
text 443924 443908 -16 -0.0
p6 all-clusters-app default (read/write) 2353392 2344224 -9168 -0.4
.bss 110668 110676 8 0.0
.data 2520 2512 -8 -0.3
.heap 920152 920152 0 0.0
.text 1311656 1302488 -9168 -0.7
light-app default (read/write) 2284536 2280048 -4488 -0.2
.bss 98440 98448 8 0.0
.data 2336 2328 -8 -0.3
.heap 932568 932568 0 0.0
.text 1242800 1238312 -4488 -0.4
lock-app default (read/write) 2260688 2256136 -4552 -0.2
.bss 97320 97328 8 0.0
.data 2296 2288 -8 -0.3
.heap 933728 933728 0 0.0
.text 1218952 1214400 -4552 -0.4
qpg lighting-app qpg6100+debug (read only) 514144 510796 -3348 -0.7
(read/write) 122332 122332 0 0.0
.bss 80168 80176 8 0.0
.data 964 956 -8 -0.8
.text 508824 505476 -3348 -0.7
lock-app qpg6100+debug (read only) 488448 484980 -3468 -0.7
(read/write) 122336 122336 0 0.0
.bss 79304 79312 8 0.0
.data 920 912 -8 -0.9
.text 483128 479660 -3468 -0.7
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799870 796546 -3324 -0.4
bss 80304 80312 8 0.0
noinit 37160 37160 0 0.0
text 559130 556254 -2876 -0.5

@andy31415
Copy link
Contributor

fast track: small change, created and approved by domain owners, change up sufficient time for cross timezone review.

@andy31415 andy31415 merged commit 5489b55 into project-chip:master Dec 8, 2021
@mlepage-google mlepage-google deleted the access-control-server-improvements branch December 8, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlepage-google @andy31415 @emargolis @woody-apple