Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up concrete command path #12684

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Clean up concrete command path #12684

merged 2 commits into from
Dec 7, 2021

Conversation

mlepage-google
Copy link
Contributor

Problem

Messy handling of ConcreteCommandPath in CommandHandler::ProcessCommandDataIB.

Change overview

Clean up handling of ConcreteCommandPath in CommandHandler::ProcessCommandDataIB.
Strictly a refactor.

Testing

Build, unit tests.

@mlepage-google
Clean up concrete command path
ae762f4 
Streamline ConcreteCommandPath handling in CommandHandler::ProcessCommandDataIB.
@boring-cyborg boring-cyborg bot added the app label Dec 7, 2021
bzbarsky-apple
bzbarsky-apple approved these changes Dec 7, 2021
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12684: Size comparison from e98e43f to ae762f4

Decreases (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section e98e43f ae762f4b change % change
efr32 lighting-app BRD4161A (read only) 797516 797468 -48 -0.0
.text 797508 797460 -48 -0.0
BRD4161A+rpc (read only) 825476 825428 -48 -0.0
.text 825468 825420 -48 -0.0
lock-app BRD4161A (read only) 772176 772128 -48 -0.0
.text 772168 772120 -48 -0.0
window-app BRD4161A (read only) 774464 774400 -64 -0.0
.text 774456 774392 -64 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 732016 731936 -80 -0.0
.text 645080 645000 -80 -0.0
lock-app k32w061+debug (read/write) 622676 622612 -64 -0.0
.text 545108 545044 -64 -0.0
shell k32w061+debug (read/write) 688596 688532 -64 -0.0
.text 599420 599356 -64 -0.0
linux all-clusters-app debug (read only) 1905417 1905289 -128 -0.0
.text 1603746 1603618 -128 -0.0
bridge-app debug+rpc (read only) 1454245 1454117 -128 -0.0
.text 1225349 1225221 -128 -0.0
chip-tool debug (read only) 6684613 6684485 -128 -0.0
.text 5940357 5940229 -128 -0.0
lighting-app debug+rpc (read only) 1740065 1739937 -128 -0.0
.text 1452802 1452674 -128 -0.0
ota-provider-app debug (read only) 1411921 1411793 -128 -0.0
.text 1181762 1181634 -128 -0.0
ota-requestor-app debug (read only) 1516673 1516545 -128 -0.0
.text 1269890 1269762 -128 -0.0
tv-app debug (read only) 2053977 2053849 -128 -0.0
.text 1722370 1722242 -128 -0.0
p6 all-clusters-app default (read/write) 2352736 2352688 -48 -0.0
.text 1311000 1310952 -48 -0.0
light-app default (read/write) 2283896 2283848 -48 -0.0
.text 1242160 1242112 -48 -0.0
lock-app default (read/write) 2260032 2259984 -48 -0.0
.text 1218296 1218248 -48 -0.0
qpg lighting-app qpg6100+debug (read only) 513692 513628 -64 -0.0
.text 508372 508308 -64 -0.0
lock-app qpg6100+debug (read only) 487980 487908 -72 -0.0
.text 482660 482588 -72 -0.0
telink lighting-app tlsr9518adk80d (read/write) 799342 799270 -72 -0.0
text 558734 558668 -66 -0.0
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section e98e43f ae762f4b change % change
efr32 lighting-app BRD4161A (read only) 797516 797468 -48 -0.0
(read/write) 120520 120520 0 0.0
.bss 118696 118696 0 0.0
.data 1824 1824 0 0.0
.text 797508 797460 -48 -0.0
BRD4161A+rpc (read only) 825476 825428 -48 -0.0
(read/write) 138828 138828 0 0.0
.bss 136896 136896 0 0.0
.data 1932 1932 0 0.0
.text 825468 825420 -48 -0.0
lock-app BRD4161A (read only) 772176 772128 -48 -0.0
(read/write) 118456 118456 0 0.0
.bss 116672 116672 0 0.0
.data 1784 1784 0 0.0
.text 772168 772120 -48 -0.0
window-app BRD4161A (read only) 774464 774400 -64 -0.0
(read/write) 118664 118664 0 0.0
.bss 116872 116872 0 0.0
.data 1788 1788 0 0.0
.text 774456 774392 -64 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 732016 731936 -80 -0.0
.bss 79280 79280 0 0.0
.data 1856 1856 0 0.0
.text 645080 645000 -80 -0.0
lock-app k32w061+debug (read/write) 622676 622612 -64 -0.0
.bss 69944 69944 0 0.0
.data 1824 1824 0 0.0
.text 545108 545044 -64 -0.0
shell k32w061+debug (read/write) 688596 688532 -64 -0.0
.bss 81580 81580 0 0.0
.data 1796 1796 0 0.0
.text 599420 599356 -64 -0.0
linux all-clusters-app debug (read only) 1905417 1905289 -128 -0.0
(read/write) 128704 128704 0 0.0
.bss 54000 54000 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 68048 68048 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155925 155925 0 0.0
.text 1603746 1603618 -128 -0.0
bridge-app debug+rpc (read only) 1454245 1454117 -128 -0.0
(read/write) 74928 74928 0 0.0
.bss 36400 36400 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31712 31712 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123612 123612 0 0.0
.text 1225349 1225221 -128 -0.0
chip-tool debug (read only) 6684613 6684485 -128 -0.0
(read/write) 201536 201536 0 0.0
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160168 160168 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335497 335497 0 0.0
.text 5940357 5940229 -128 -0.0
lighting-app debug+rpc (read only) 1740065 1739937 -128 -0.0
(read/write) 107960 107960 0 0.0
.bss 42096 42096 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59216 59216 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144209 144209 0 0.0
.text 1452802 1452674 -128 -0.0
ota-provider-app debug (read only) 1411921 1411793 -128 -0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181762 1181634 -128 -0.0
ota-requestor-app debug (read only) 1516673 1516545 -128 -0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269890 1269762 -128 -0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2053977 2053849 -128 -0.0
(read/write) 320312 320312 0 0.0
.bss 247416 247416 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64304 64304 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176508 176508 0 0.0
.text 1722370 1722242 -128 -0.0
p6 all-clusters-app default (read/write) 2352736 2352688 -48 -0.0
.bss 110652 110652 0 0.0
.data 2512 2512 0 0.0
.heap 920176 920176 0 0.0
.text 1311000 1310952 -48 -0.0
light-app default (read/write) 2283896 2283848 -48 -0.0
.bss 98416 98416 0 0.0
.data 2328 2328 0 0.0
.heap 932600 932600 0 0.0
.text 1242160 1242112 -48 -0.0
lock-app default (read/write) 2260032 2259984 -48 -0.0
.bss 97296 97296 0 0.0
.data 2296 2296 0 0.0
.heap 933752 933752 0 0.0
.text 1218296 1218248 -48 -0.0
qpg lighting-app qpg6100+debug (read only) 513692 513628 -64 -0.0
(read/write) 122336 122336 0 0.0
.bss 80144 80144 0 0.0
.data 960 960 0 0.0
.text 508372 508308 -64 -0.0
lock-app qpg6100+debug (read only) 487980 487908 -72 -0.0
(read/write) 122332 122332 0 0.0
.bss 79280 79280 0 0.0
.data 916 916 0 0.0
.text 482660 482588 -72 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799342 799270 -72 -0.0
bss 80284 80284 0 0.0
noinit 37160 37160 0 0.0
text 558734 558668 -66 -0.0

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12684: Size comparison from e98e43f to 47d97ad

Increases above 0.2%:

platform target config section e98e43f 47d97ad change % change
linux bridge-app debug+rpc .data.rel.ro 31712 31824 112 0.4
.rodata 123612 123932 320 0.3
p6 all-clusters-app default .data 2512 2520 8 0.3
light-app default .data 2328 2336 8 0.3
qpg lighting-app qpg6100+debug .data 960 964 4 0.4
lock-app qpg6100+debug .data 916 920 4 0.4
Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e98e43f 47d97ad change % change
efr32 lighting-app BRD4161A (read only) 797516 798108 592 0.1
(read/write) 120520 120548 28 0.0
.bss 118696 118720 24 0.0
.data 1824 1828 4 0.2
.text 797508 798100 592 0.1
BRD4161A+rpc (read only) 825476 826068 592 0.1
(read/write) 138828 138856 28 0.0
.bss 136896 136920 24 0.0
.data 1932 1936 4 0.2
.text 825468 826060 592 0.1
lock-app BRD4161A (read only) 772176 772768 592 0.1
(read/write) 118456 118488 32 0.0
.bss 116672 116696 24 0.0
.data 1784 1788 4 0.2
.text 772168 772760 592 0.1
window-app BRD4161A (read only) 774464 775056 592 0.1
(read/write) 118664 118688 24 0.0
.bss 116872 116896 24 0.0
.data 1788 1792 4 0.2
.text 774456 775048 592 0.1
esp32 all-clusters-app c3devkit (read only) 856402 856724 322 0.0
(read/write) 1298786 1298938 152 0.0
.dram0.bss 61072 61096 24 0.0
.flash.rodata 170544 170664 120 0.1
.flash.text 856402 856724 322 0.0
m5stack (read only) 959771 960047 276 0.0
(read/write) 443104 443244 140 0.0
.dram0.bss 68424 68448 24 0.0
.flash.rodata 208836 208952 116 0.1
.flash.text 954387 954663 276 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732016 732420 404 0.1
.bss 79280 79296 16 0.0
.data 1856 1860 4 0.2
.text 645080 645464 384 0.1
lock-app k32w061+debug (read/write) 622676 623084 408 0.1
.bss 69944 69960 16 0.0
.data 1824 1828 4 0.2
.text 545108 545496 388 0.1
shell k32w061+debug (read/write) 688596 689004 408 0.1
.bss 81580 81596 16 0.0
.data 1796 1800 4 0.2
.text 599420 599808 388 0.1
linux all-clusters-app debug (read only) 1905417 1907561 2144 0.1
(read/write) 128704 128896 192 0.1
.bss 54000 54032 32 0.1
.data.rel.ro 68048 68192 144 0.2
.rodata 155925 156277 352 0.2
.text 1603746 1605442 1696 0.1
bridge-app debug+rpc (read only) 1454245 1456357 2112 0.1
(read/write) 74928 75088 160 0.2
.bss 36400 36464 64 0.2
.data.rel.ro 31712 31824 112 0.4
.rodata 123612 123932 320 0.3
.text 1225349 1227045 1696 0.1
chip-tool debug (read only) 6684613 6687469 2856 0.0
(read/write) 201536 201728 192 0.1
.data.rel.ro 160168 160376 208 0.1
.rodata 335497 335721 224 0.1
.text 5940357 5942485 2128 0.0
lighting-app debug+rpc (read only) 1740065 1742161 2096 0.1
(read/write) 107960 108152 192 0.2
.bss 42096 42160 64 0.2
.data.rel.ro 59216 59344 128 0.2
.rodata 144209 144529 320 0.2
.text 1452802 1454482 1680 0.1
tv-app debug (read only) 2053977 2056073 2096 0.1
(read/write) 320312 320504 192 0.1
.bss 247416 247480 64 0.0
.data.rel.ro 64304 64432 128 0.2
.rodata 176508 176828 320 0.2
.text 1722370 1724050 1680 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2316600 2317056 456 0.0
.bss 184428 184444 16 0.0
.text 1279176 1279632 456 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300424 2300888 464 0.0
.bss 173232 173248 16 0.0
.text 1263024 1263488 464 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2273464 2273928 464 0.0
.bss 172272 172296 24 0.0
.text 1236064 1236528 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896243 896643 400 0.0
bss 113704 113724 20 0.0
rodata 100196 100308 112 0.1
text 606776 607056 280 0.0
nrf52840dk_nrf52840+rpc (read/write) 859195 859579 384 0.0
bss 110052 110072 20 0.0
rodata 91388 91500 112 0.1
text 581516 581792 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822190 822590 400 0.0
bss 115080 115100 20 0.0
rodata 95456 95568 112 0.1
text 537144 537424 280 0.1
lock-app nrf52840dk_nrf52840 (read/write) 868795 869211 416 0.0
bss 110968 110988 20 0.0
rodata 96316 96428 112 0.1
text 586136 586412 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 794978 795394 416 0.1
bss 112376 112396 20 0.0
rodata 91604 91716 112 0.1
text 516596 516876 280 0.1
pump-app nrf52840dk_nrf52840 (read/write) 873547 873963 416 0.0
bss 110880 110900 20 0.0
rodata 97668 97780 112 0.1
text 589548 589828 280 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 866787 867187 400 0.0
bss 110756 110776 20 0.0
rodata 95804 95916 112 0.1
text 584760 585036 276 0.0
p6 all-clusters-app default (read/write) 2352736 2353344 608 0.0
.bss 110652 110668 16 0.0
.data 2512 2520 8 0.3
.text 1311000 1311608 608 0.0
light-app default (read/write) 2283896 2284488 592 0.0
.bss 98416 98440 24 0.0
.data 2328 2336 8 0.3
.text 1242160 1242752 592 0.0
lock-app default (read/write) 2260032 2260640 608 0.0
.bss 97296 97320 24 0.0
.text 1218296 1218904 608 0.0
qpg lighting-app qpg6100+debug (read only) 513692 514080 388 0.1
.bss 80144 80168 24 0.0
.data 960 964 4 0.4
.text 508372 508760 388 0.1
lock-app qpg6100+debug (read only) 487980 488376 396 0.1
(read/write) 122332 122336 4 0.0
.bss 79280 79304 24 0.0
.data 916 920 4 0.4
.text 482660 483056 396 0.1
telink lighting-app tlsr9518adk80d (read/write) 799342 799798 456 0.1
bss 80284 80304 20 0.0
text 558734 559064 330 0.1
Decreases (9 builds for linux, mbed, p6, qpg)
platform target config section e98e43f 47d97ad change % change
linux ota-provider-app debug (read only) 1411921 1411825 -96 -0.0
.text 1181762 1181666 -96 -0.0
ota-requestor-app debug (read only) 1516673 1516577 -96 -0.0
.text 1269890 1269794 -96 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846776 846760 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 857720 857704 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 858680 858656 -24 -0.0
p6 all-clusters-app default .heap 920176 920152 -24 -0.0
light-app default .heap 932600 932568 -32 -0.0
lock-app default .heap 933752 933728 -24 -0.0
qpg lighting-app qpg6100+debug (read/write) 122336 122332 -4 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e98e43f 47d97ad change % change
efr32 lighting-app BRD4161A (read only) 797516 798108 592 0.1
(read/write) 120520 120548 28 0.0
.bss 118696 118720 24 0.0
.data 1824 1828 4 0.2
.text 797508 798100 592 0.1
BRD4161A+rpc (read only) 825476 826068 592 0.1
(read/write) 138828 138856 28 0.0
.bss 136896 136920 24 0.0
.data 1932 1936 4 0.2
.text 825468 826060 592 0.1
lock-app BRD4161A (read only) 772176 772768 592 0.1
(read/write) 118456 118488 32 0.0
.bss 116672 116696 24 0.0
.data 1784 1788 4 0.2
.text 772168 772760 592 0.1
window-app BRD4161A (read only) 774464 775056 592 0.1
(read/write) 118664 118688 24 0.0
.bss 116872 116896 24 0.0
.data 1788 1792 4 0.2
.text 774456 775048 592 0.1
esp32 all-clusters-app c3devkit (read only) 856402 856724 322 0.0
(read/write) 1298786 1298938 152 0.0
.dram0.bss 61072 61096 24 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170544 170664 120 0.1
.flash.text 856402 856724 322 0.0
.iram0.text 62028 62028 0 0.0
m5stack (read only) 959771 960047 276 0.0
(read/write) 443104 443244 140 0.0
.dram0.bss 68424 68448 24 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208836 208952 116 0.1
.flash.text 954387 954663 276 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 732016 732420 404 0.1
.bss 79280 79296 16 0.0
.data 1856 1860 4 0.2
.text 645080 645464 384 0.1
lock-app k32w061+debug (read/write) 622676 623084 408 0.1
.bss 69944 69960 16 0.0
.data 1824 1828 4 0.2
.text 545108 545496 388 0.1
shell k32w061+debug (read/write) 688596 689004 408 0.1
.bss 81580 81596 16 0.0
.data 1796 1800 4 0.2
.text 599420 599808 388 0.1
linux all-clusters-app debug (read only) 1905417 1907561 2144 0.1
(read/write) 128704 128896 192 0.1
.bss 54000 54032 32 0.1
.data 1216 1216 0 0.0
.data.rel.ro 68048 68192 144 0.2
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155925 156277 352 0.2
.text 1603746 1605442 1696 0.1
bridge-app debug+rpc (read only) 1454245 1456357 2112 0.1
(read/write) 74928 75088 160 0.2
.bss 36400 36464 64 0.2
.data 1728 1728 0 0.0
.data.rel.ro 31712 31824 112 0.4
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123612 123932 320 0.3
.text 1225349 1227045 1696 0.1
chip-tool debug (read only) 6684613 6687469 2856 0.0
(read/write) 201536 201728 192 0.1
.bss 34664 34664 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160168 160376 208 0.1
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335497 335721 224 0.1
.text 5940357 5942485 2128 0.0
lighting-app debug+rpc (read only) 1740065 1742161 2096 0.1
(read/write) 107960 108152 192 0.2
.bss 42096 42160 64 0.2
.data 1280 1280 0 0.0
.data.rel.ro 59216 59344 128 0.2
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144209 144529 320 0.2
.text 1452802 1454482 1680 0.1
ota-provider-app debug (read only) 1411921 1411825 -96 -0.0
(read/write) 73096 73096 0 0.0
.bss 38976 38976 0 0.0
.data 928 928 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 125086 125086 0 0.0
.text 1181762 1181666 -96 -0.0
ota-requestor-app debug (read only) 1516673 1516577 -96 -0.0
(read/write) 78144 78144 0 0.0
.bss 42144 42144 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29784 29784 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137807 137807 0 0.0
.text 1269890 1269794 -96 -0.0
shell debug (read only) 827345 827345 0 0.0
(read/write) 60640 60640 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39032 39032 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85714 85714 0 0.0
.text 634530 634530 0 0.0
tv-app debug (read only) 2053977 2056073 2096 0.1
(read/write) 320312 320504 192 0.1
.bss 247416 247480 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64304 64432 128 0.2
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176508 176828 320 0.2
.text 1722370 1724050 1680 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316600 2317056 456 0.0
.bss 184428 184444 16 0.0
.data 5240 5240 0 0.0
.heap 846776 846760 -16 -0.0
.text 1279176 1279632 456 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300424 2300888 464 0.0
.bss 173232 173248 16 0.0
.data 5496 5496 0 0.0
.heap 857720 857704 -16 -0.0
.text 1263024 1263488 464 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273464 2273928 464 0.0
.bss 172272 172296 24 0.0
.data 5496 5496 0 0.0
.heap 858680 858656 -24 -0.0
.text 1236064 1236528 464 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048008 2048008 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010608 1010608 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896243 896643 400 0.0
bss 113704 113724 20 0.0
rodata 100196 100308 112 0.1
text 606776 607056 280 0.0
nrf52840dk_nrf52840+rpc (read/write) 859195 859579 384 0.0
bss 110052 110072 20 0.0
rodata 91388 91500 112 0.1
text 581516 581792 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822190 822590 400 0.0
bss 115080 115100 20 0.0
rodata 95456 95568 112 0.1
text 537144 537424 280 0.1
lock-app nrf52840dk_nrf52840 (read/write) 868795 869211 416 0.0
bss 110968 110988 20 0.0
rodata 96316 96428 112 0.1
text 586136 586412 276 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 794978 795394 416 0.1
bss 112376 112396 20 0.0
rodata 91604 91716 112 0.1
text 516596 516876 280 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 873547 873963 416 0.0
bss 110880 110900 20 0.0
rodata 97668 97780 112 0.1
text 589548 589828 280 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 866787 867187 400 0.0
bss 110756 110776 20 0.0
rodata 95804 95916 112 0.1
text 584760 585036 276 0.0
shell nrf52840dk_nrf52840 (read/write) 781643 781643 0 0.0
bss 109552 109552 0 0.0
rodata 74296 74296 0 0.0
text 523284 523284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696718 696718 0 0.0
bss 110532 110532 0 0.0
rodata 68936 68936 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2352736 2353344 608 0.0
.bss 110652 110668 16 0.0
.data 2512 2520 8 0.3
.heap 920176 920152 -24 -0.0
.text 1311000 1311608 608 0.0
light-app default (read/write) 2283896 2284488 592 0.0
.bss 98416 98440 24 0.0
.data 2328 2336 8 0.3
.heap 932600 932568 -32 -0.0
.text 1242160 1242752 592 0.0
lock-app default (read/write) 2260032 2260640 608 0.0
.bss 97296 97320 24 0.0
.data 2296 2296 0 0.0
.heap 933752 933728 -24 -0.0
.text 1218296 1218904 608 0.0
qpg lighting-app qpg6100+debug (read only) 513692 514080 388 0.1
(read/write) 122336 122332 -4 -0.0
.bss 80144 80168 24 0.0
.data 960 964 4 0.4
.text 508372 508760 388 0.1
lock-app qpg6100+debug (read only) 487980 488376 396 0.1
(read/write) 122332 122336 4 0.0
.bss 79280 79304 24 0.0
.data 916 920 4 0.4
.text 482660 483056 396 0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799342 799798 456 0.1
bss 80284 80304 20 0.0
noinit 37160 37160 0 0.0
text 558734 559064 330 0.1

@mlepage-google mlepage-google mentioned this pull request Dec 7, 2021
Merged
@andy31415
Copy link
Contributor

fast track: a lot of checkmarks on this one.

@andy31415 andy31415 merged commit 2ece989 into project-chip:master Dec 7, 2021
@mlepage-google mlepage-google deleted the refactor-concrete-command-path branch December 7, 2021 20:13
@mlepage-google mlepage-google mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees

@bzbarsky-apple bzbarsky-apple

Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mlepage-google @andy31415 @tcarmelveilleux @mrjerryjohns @yunhanw-google @woody-apple @bzbarsky-apple