Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodules #1262

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Add submodules #1262

merged 1 commit into from
Jun 25, 2020

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jun 25, 2020

As we start to add other build systems, we should have a way to sync the
project without depending on makefiles. Use git submodules for this.

This also avoids an issue with branch based dependency management
where it's not possible to fully recreate historical versions, which necessarily
includes the state of dependencies. Tracking prior versions is the main
purpose of source control.

As we start to add other build systems, we should have a way to sync the
project without depending on make. Use git submodules for this.

This also avoids an issue with branch based subrepository management
where it's not possible to recreate historical states of the project,
which necessarily includes the state of dependencies. Tracking and
recreating prior versions is the main purpose of source control.
@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .dram0.bss 0 8
chip-wifi-echo.elf .dram0.data -8 -8
Full report output
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.dram0.bss,8,0
[Unmapped],0,8
.dram0.data,-8,-8


@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize


@woody-apple
Copy link
Contributor

@rwalker-apple ?

@woody-apple woody-apple merged commit 4d762b6 into project-chip:master Jun 25, 2020
@gerickson
Copy link
Contributor

The reason that submodules were not employed in the first place is that if you were to make dist a CHIP repo and then attempt to use it, you'd find that there is no git repository against which the git submodules can operate. Do we have a proposed solution for that?

@mspang
Copy link
Contributor Author

mspang commented Jun 26, 2020

Couldn't "make dist" just ship the .gitmodules and use it from bootstrap? And while we are in git, we can use it natively.

Is it expected to be a common use case to go the "make dist" route without using a separate package manager to provide the dependencies?

@gerickson
Copy link
Contributor

Couldn't "make dist" just ship the .gitmodules and use it from bootstrap? And while we are in git, we can use it natively.

Is it expected to be a common use case to go the "make dist" route without using a separate package manager to provide the dependencies?

Just like with most open source packages today, if I were wanting to kick the tires on CHIP, I'd take a named archive distribution, download it, and start playing with it, as-is. Only if I found a bug or wanted to start getting deeper than kicking the tires would I bother with a repo clone.

@mspang mspang deleted the for-chip/submodules branch April 2, 2021 00:36
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 25, 2023
…provision_mg24_error to RC_2.2.0-1.2

Auto-Merge: Pull request project-chip#1262: [AUTO] Provision mg24 error bugfix

Merge in WMN_TOOLS/matter from bugfix/provision_mg24_error to RC_2.2.0-1.2

Squashed commit of the following:

commit 6595432c7a1983ecf453731c6c22c08fd73874c8
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Wed Oct 18 15:20:06 2023 -0400

    Fixes MG24 invalid header error during provisioning.
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
…provision_mg24_error to RC_2.2.0-1.2

Auto-Merge: Pull request project-chip#1262: [AUTO] Provision mg24 error bugfix

Merge in WMN_TOOLS/matter from bugfix/provision_mg24_error to RC_2.2.0-1.2

Squashed commit of the following:

commit 6595432c7a1983ecf453731c6c22c08fd73874c8
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Wed Oct 18 15:20:06 2023 -0400

    Fixes MG24 invalid header error during provisioning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants