-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submodules #1262
Add submodules #1262
Conversation
As we start to add other build systems, we should have a way to sync the project without depending on make. Use git submodules for this. This also avoids an issue with branch based subrepository management where it's not possible to recreate historical states of the project, which necessarily includes the state of dependencies. Tracking and recreating prior versions is the main purpose of source control.
Size increase report for "Build Examples [nRF]"
Full report output
|
Size increase report for "Build Examples [ESP32]"
Full report output
|
Size increase report for "Build Examples [main-build]"
Full report output
|
The reason that submodules were not employed in the first place is that if you were to |
Couldn't "make dist" just ship the .gitmodules and use it from bootstrap? And while we are in git, we can use it natively. Is it expected to be a common use case to go the "make dist" route without using a separate package manager to provide the dependencies? |
Just like with most open source packages today, if I were wanting to kick the tires on CHIP, I'd take a named archive distribution, download it, and start playing with it, as-is. Only if I found a bug or wanted to start getting deeper than kicking the tires would I bother with a repo clone. |
…provision_mg24_error to RC_2.2.0-1.2 Auto-Merge: Pull request project-chip#1262: [AUTO] Provision mg24 error bugfix Merge in WMN_TOOLS/matter from bugfix/provision_mg24_error to RC_2.2.0-1.2 Squashed commit of the following: commit 6595432c7a1983ecf453731c6c22c08fd73874c8 Author: Ricardo Casallas <ricardo.casallas@silabs.com> Date: Wed Oct 18 15:20:06 2023 -0400 Fixes MG24 invalid header error during provisioning.
…provision_mg24_error to RC_2.2.0-1.2 Auto-Merge: Pull request project-chip#1262: [AUTO] Provision mg24 error bugfix Merge in WMN_TOOLS/matter from bugfix/provision_mg24_error to RC_2.2.0-1.2 Squashed commit of the following: commit 6595432c7a1983ecf453731c6c22c08fd73874c8 Author: Ricardo Casallas <ricardo.casallas@silabs.com> Date: Wed Oct 18 15:20:06 2023 -0400 Fixes MG24 invalid header error during provisioning.
As we start to add other build systems, we should have a way to sync the
project without depending on makefiles. Use git submodules for this.
This also avoids an issue with branch based dependency management
where it's not possible to fully recreate historical versions, which necessarily
includes the state of dependencies. Tracking prior versions is the main
purpose of source control.