-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove weak keyword from OT uart process implemented for efr32 platform #12565
Merged
jmartinez-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:serialPort
Dec 6, 2021
Merged
Remove weak keyword from OT uart process implemented for efr32 platform #12565
jmartinez-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:serialPort
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
December 3, 2021 20:12
pullapprove
bot
requested review from
hawk248,
jelderton,
jepenven-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
December 3, 2021 20:12
Only affects efr32 platforms -- the PR can be fast tracked |
PR #12565: Size comparison from 3a339bc to 620bc1b Increases above 0.2%:
Increases (4 builds for efr32)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Dec 5, 2021
rcasallas-silabs
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The PR #12411 updated ot-efr32 submodule and broke the serial port on efr32 platform
Change overview
OT-efr32 submodule update added in some weak empty functions that overwrote the already weak functions implementation that linked ot uart proces to efr32 uart implementation.
I do not recall why those functions for efr32 needed to be weak in the first place but it isn't the case anymore.
Testing
Build and succesfully used thread cli on efr32 platform.