Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove weak keyword from OT uart process implemented for efr32 platform #12565

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Remove weak keyword from OT uart process implemented for efr32 platform #12565

merged 1 commit into from
Dec 6, 2021

Conversation

jmartinez-silabs
Copy link
Member

Problem

The PR #12411 updated ot-efr32 submodule and broke the serial port on efr32 platform

Change overview

OT-efr32 submodule update added in some weak empty functions that overwrote the already weak functions implementation that linked ot uart proces to efr32 uart implementation.

I do not recall why those functions for efr32 needed to be weak in the first place but it isn't the case anymore.

Testing

Build and succesfully used thread cli on efr32 platform.

@jmartinez-silabs
Copy link
Member Author

jmartinez-silabs commented Dec 3, 2021 •
edited
Loading

Only affects efr32 platforms -- the PR can be fast tracked

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12565: Size comparison from 3a339bc to 620bc1b

Increases above 0.2%:

platform target config section 3a339bc 620bc1b change % change
efr32 lighting-app BRD4161A (read only) 751784 791648 39864 5.3
(read/write) 120032 120648 616 0.5
.bss 118200 118816 616 0.5
.text 751776 791640 39864 5.3
BRD4161A+rpc (read only) 780440 819624 39184 5.0
(read/write) 138336 138952 616 0.4
.bss 136400 137016 616 0.5
.text 780432 819616 39184 5.0
lock-app BRD4161A (read only) 726592 766484 39892 5.5
(read/write) 117968 118580 612 0.5
.bss 116176 116792 616 0.5
.text 726584 766476 39892 5.5
window-app BRD4161A (read only) 729096 768956 39860 5.5
(read/write) 118168 118784 616 0.5
.bss 116376 116992 616 0.5
.text 729088 768948 39860 5.5
Increases (4 builds for efr32)
platform target config section 3a339bc 620bc1b change % change
efr32 lighting-app BRD4161A (read only) 751784 791648 39864 5.3
(read/write) 120032 120648 616 0.5
.bss 118200 118816 616 0.5
.text 751776 791640 39864 5.3
BRD4161A+rpc (read only) 780440 819624 39184 5.0
(read/write) 138336 138952 616 0.4
.bss 136400 137016 616 0.5
.text 780432 819616 39184 5.0
lock-app BRD4161A (read only) 726592 766484 39892 5.5
(read/write) 117968 118580 612 0.5
.bss 116176 116792 616 0.5
.text 726584 766476 39892 5.5
window-app BRD4161A (read only) 729096 768956 39860 5.5
(read/write) 118168 118784 616 0.5
.bss 116376 116992 616 0.5
.text 729088 768948 39860 5.5
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3a339bc 620bc1b change % change
efr32 lighting-app BRD4161A (read only) 751784 791648 39864 5.3
(read/write) 120032 120648 616 0.5
.bss 118200 118816 616 0.5
.data 1828 1828 0 0.0
.text 751776 791640 39864 5.3
BRD4161A+rpc (read only) 780440 819624 39184 5.0
(read/write) 138336 138952 616 0.4
.bss 136400 137016 616 0.5
.data 1936 1936 0 0.0
.text 780432 819616 39184 5.0
lock-app BRD4161A (read only) 726592 766484 39892 5.5
(read/write) 117968 118580 612 0.5
.bss 116176 116792 616 0.5
.data 1788 1788 0 0.0
.text 726584 766476 39892 5.5
window-app BRD4161A (read only) 729096 768956 39860 5.5
(read/write) 118168 118784 616 0.5
.bss 116376 116992 616 0.5
.data 1792 1792 0 0.0
.text 729088 768948 39860 5.5
esp32 all-clusters-app c3devkit (read only) 847594 847594 0 0.0
(read/write) 1222714 1222714 0 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167848 167848 0 0.0
.flash.text 847594 847594 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918067 918067 0 0.0
(read/write) 421672 421672 0 0.0
.dram0.bss 60728 60728 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195648 195648 0 0.0
.flash.text 912683 912683 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1848137 1848137 0 0.0
(read/write) 123216 123216 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 66976 66976 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 149589 149589 0 0.0
.text 1555490 1555490 0 0.0
bridge-app debug+rpc (read only) 1431021 1431021 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205077 0 0.0
chip-tool debug (read only) 6593069 6593069 0 0.0
(read/write) 199400 199400 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158168 158168 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307512 307512 0 0.0
.text 5881573 5881573 0 0.0
lighting-app debug+rpc (read only) 1716161 1716161 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431810 0 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029745 2029745 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700786 1700786 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306704 2306704 0 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269280 1269280 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232824 1232824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817626 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863655 863655 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581544 581544 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511972 511972 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339080 2339080 0 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1297344 1297344 0 0.0
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2256048 2256048 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214312 1214312 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 484124 484124 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478804 478804 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit d8e38d7 into project-chip:master Dec 6, 2021
@jmartinez-silabs jmartinez-silabs deleted the serialPort branch December 6, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
efr32 fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinez-silabs @msandstedt @rcasallas-silabs