Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manufacturer code arrays from endpoint_config. #12535

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Remove manufacturer code arrays from endpoint_config. #12535

merged 1 commit into from
Dec 6, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

We're storing the full MEI for cluster and attribute ids, so all this
manufacturer code stuff is dead code. There's a lot more to remove,
but this is a start.

Problem

Various dead code.

Change overview

Remove it.

Testing

No behavior changes expected.

@bzbarsky-apple
Remove manufacturer code arrays from endpoint_config.
975745b 
We're storing the full MEI for cluster and attribute ids, so all this
manufacturer code stuff is dead code.  There's a lot more to remove,
but this is a start.
@boring-cyborg boring-cyborg bot added the app label Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12535: Size comparison from a484e4c to 975745b

Decreases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a484e4c 975745b change % change
efr32 lighting-app BRD4161A (read only) 751584 751320 -264 -0.0
.text 751576 751312 -264 -0.0
BRD4161A+rpc (read only) 780256 779976 -280 -0.0
.text 780248 779968 -280 -0.0
lock-app BRD4161A (read only) 725440 725160 -280 -0.0
.text 725432 725152 -280 -0.0
window-app BRD4161A (read only) 728752 728488 -264 -0.0
.text 728744 728480 -264 -0.0
esp32 all-clusters-app c3devkit (read only) 847862 847588 -274 -0.0
.flash.text 847862 847588 -274 -0.0
m5stack (read only) 918451 918195 -256 -0.0
.flash.text 913067 912811 -256 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 728752 728608 -144 -0.0
.text 641788 641644 -144 -0.0
lock-app k32w061+debug (read/write) 617736 617592 -144 -0.0
.text 540368 540224 -144 -0.0
shell k32w061+debug (read/write) 683636 683492 -144 -0.0
.text 594640 594496 -144 -0.0
linux all-clusters-app debug (read only) 1848393 1847865 -528 -0.0
.text 1557026 1556498 -528 -0.0
bridge-app debug+rpc (read only) 1426541 1426013 -528 -0.0
.text 1201045 1200517 -528 -0.0
chip-tool debug (read only) 6621845 6621317 -528 -0.0
.text 5903669 5903141 -528 -0.0
lighting-app debug+rpc (read only) 1711049 1710489 -560 -0.0
.rodata 140657 140625 -32 -0.0
.text 1427746 1427218 -528 -0.0
ota-provider-app debug (read only) 1386681 1386153 -528 -0.0
.text 1160546 1160018 -528 -0.0
ota-requestor-app debug (read only) 1490489 1489961 -528 -0.0
.text 1248018 1247490 -528 -0.0
tv-app debug (read only) 2020753 2020225 -528 -0.0
.text 1692690 1692162 -528 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2309264 2309136 -128 -0.0
.text 1271840 1271712 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2295656 2295464 -192 -0.0
.text 1258256 1258064 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2268688 2268560 -128 -0.0
.text 1231288 1231160 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891503 891359 -144 -0.0
text 602792 602640 -152 -0.0
nrf52840dk_nrf52840+rpc (read/write) 854879 854719 -160 -0.0
text 577788 577636 -152 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817414 817254 -160 -0.0
text 533128 532980 -148 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 862359 862215 -144 -0.0
text 581044 580892 -152 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788514 788370 -144 -0.0
text 511472 511324 -148 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 868375 868231 -144 -0.0
text 585108 584960 -148 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861439 861295 -144 -0.0
text 580168 580020 -148 -0.0
p6 all-clusters-app default (read/write) 2339544 2339280 -264 -0.0
.text 1297808 1297544 -264 -0.0
light-app default (read/write) 2278920 2278640 -280 -0.0
.text 1237184 1236904 -280 -0.0
lock-app default (read/write) 2254256 2253992 -264 -0.0
.text 1212520 1212256 -264 -0.0
qpg lighting-app qpg6100+debug (read only) 510544 510384 -160 -0.0
.text 505224 505064 -160 -0.0
lock-app qpg6100+debug (read only) 483352 483208 -144 -0.0
.text 478032 477888 -144 -0.0
telink lighting-app tlsr9518adk80d (read/write) 794594 794314 -280 -0.0
text 554576 554296 -280 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a484e4c 975745b change % change
efr32 lighting-app BRD4161A (read only) 751584 751320 -264 -0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751576 751312 -264 -0.0
BRD4161A+rpc (read only) 780256 779976 -280 -0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780248 779968 -280 -0.0
lock-app BRD4161A (read only) 725440 725160 -280 -0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725432 725152 -280 -0.0
window-app BRD4161A (read only) 728752 728488 -264 -0.0
(read/write) 118160 118160 0 0.0
.bss 116368 116368 0 0.0
.data 1792 1792 0 0.0
.text 728744 728480 -264 -0.0
esp32 all-clusters-app c3devkit (read only) 847862 847588 -274 -0.0
(read/write) 1223826 1223826 0 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167744 167744 0 0.0
.flash.text 847862 847588 -274 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918451 918195 -256 -0.0
(read/write) 422804 422804 0 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195548 195548 0 0.0
.flash.text 913067 912811 -256 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728752 728608 -144 -0.0
.bss 79304 79304 0 0.0
.data 1860 1860 0 0.0
.text 641788 641644 -144 -0.0
lock-app k32w061+debug (read/write) 617736 617592 -144 -0.0
.bss 69744 69744 0 0.0
.data 1824 1824 0 0.0
.text 540368 540224 -144 -0.0
shell k32w061+debug (read/write) 683636 683492 -144 -0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594640 594496 -144 -0.0
linux all-clusters-app debug (read only) 1848393 1847865 -528 -0.0
(read/write) 124520 124520 0 0.0
.bss 50896 50896 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 148501 148501 0 0.0
.text 1557026 1556498 -528 -0.0
bridge-app debug+rpc (read only) 1426541 1426013 -528 -0.0
(read/write) 74584 74584 0 0.0
.bss 36240 36240 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31528 31528 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 120620 120620 0 0.0
.text 1201045 1200517 -528 -0.0
chip-tool debug (read only) 6621845 6621317 -528 -0.0
(read/write) 202280 202280 0 0.0
.bss 34504 34504 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161112 161112 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307608 307608 0 0.0
.text 5903669 5903141 -528 -0.0
lighting-app debug+rpc (read only) 1711049 1710489 -560 -0.0
(read/write) 107616 107616 0 0.0
.bss 41936 41936 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59024 59024 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 140657 140625 -32 -0.0
.text 1427746 1427218 -528 -0.0
ota-provider-app debug (read only) 1386681 1386153 -528 -0.0
(read/write) 72816 72816 0 0.0
.bss 38816 38816 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121448 121448 0 0.0
.text 1160546 1160018 -528 -0.0
ota-requestor-app debug (read only) 1490489 1489961 -528 -0.0
(read/write) 76784 76784 0 0.0
.bss 40960 40960 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 133776 133776 0 0.0
.text 1248018 1247490 -528 -0.0
shell debug (read only) 819625 819625 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3512 3512 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83570 83570 0 0.0
.text 629314 629314 0 0.0
tv-app debug (read only) 2020753 2020225 -528 -0.0
(read/write) 320000 320000 0 0.0
.bss 247224 247224 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64200 64200 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173608 173608 0 0.0
.text 1692690 1692162 -528 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309264 2309136 -128 -0.0
.bss 179628 179628 0 0.0
.data 5184 5184 0 0.0
.heap 851632 851632 0 0.0
.text 1271840 1271712 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295656 2295464 -192 -0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258256 1258064 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268688 2268560 -128 -0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231288 1231160 -128 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891503 891359 -144 -0.0
bss 113752 113752 0 0.0
rodata 99408 99408 0 0.0
text 602792 602640 -152 -0.0
nrf52840dk_nrf52840+rpc (read/write) 854879 854719 -160 -0.0
bss 110100 110100 0 0.0
rodata 90768 90768 0 0.0
text 577788 577636 -152 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817414 817254 -160 -0.0
bss 115124 115124 0 0.0
rodata 94664 94664 0 0.0
text 533128 532980 -148 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 862359 862215 -144 -0.0
bss 110788 110788 0 0.0
rodata 95144 95144 0 0.0
text 581044 580892 -152 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788514 788370 -144 -0.0
bss 112200 112200 0 0.0
rodata 90436 90436 0 0.0
text 511472 511324 -148 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868375 868231 -144 -0.0
bss 110924 110924 0 0.0
rodata 96880 96880 0 0.0
text 585108 584960 -148 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861439 861295 -144 -0.0
bss 110804 110804 0 0.0
rodata 95016 95016 0 0.0
text 580168 580020 -148 -0.0
shell nrf52840dk_nrf52840 (read/write) 779891 779891 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339544 2339280 -264 -0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297808 1297544 -264 -0.0
light-app default (read/write) 2278920 2278640 -280 -0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237184 1236904 -280 -0.0
lock-app default (read/write) 2254256 2253992 -264 -0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212520 1212256 -264 -0.0
qpg lighting-app qpg6100+debug (read only) 510544 510384 -160 -0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80264 0 0.0
.data 964 964 0 0.0
.text 505224 505064 -160 -0.0
lock-app qpg6100+debug (read only) 483352 483208 -144 -0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79176 0 0.0
.data 916 916 0 0.0
.text 478032 477888 -144 -0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794594 794314 -280 -0.0
bss 80328 80328 0 0.0
noinit 37160 37160 0 0.0
text 554576 554296 -280 -0.1

@bzbarsky-apple
Copy link
Contributor Author

@jmartinez-silabs @jepenven-silabs @LuDuda @Damian-Nordic Please take a look?

@andy31415 andy31415 merged commit 675d9f5 into project-chip:master Dec 6, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-manufacturer-code-arrays branch December 6, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @yunhanw-google @woody-apple @jmartinez-silabs @andy31415