-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Add multicast listening on linux #12342
Merged
jepenven-silabs
merged 10 commits into
project-chip:master
from
jepenven-silabs:add_multicast_capability
Dec 7, 2021
Merged
[Group] Add multicast listening on linux #12342
jepenven-silabs
merged 10 commits into
project-chip:master
from
jepenven-silabs:add_multicast_capability
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12342: Size comparison from 6c3004e to ac1a3d2 Increases above 0.2%:
Increases (23 builds for efr32, esp32, k32w, linux, mbed, qpg)
Full report (25 builds for efr32, esp32, k32w, linux, mbed, qpg)
|
/rebase |
woody-apple
force-pushed
the
add_multicast_capability
branch
from
November 30, 2021 13:56
ac1a3d2
to
bb77351
Compare
Fix this once GroupDataProvider is implemented #Issue 11075connectedhomeip/src/app/server/Server.cpp Lines 116 to 126 in bb77351
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google and
mrjerryjohns
November 30, 2021 14:30
tcarmelveilleux
approved these changes
Dec 2, 2021
kpschoedel
approved these changes
Dec 2, 2021
jepenven-silabs
force-pushed
the
add_multicast_capability
branch
from
December 3, 2021 15:25
abf90db
to
7d3bbce
Compare
/rebase |
woody-apple
force-pushed
the
add_multicast_capability
branch
from
December 3, 2021 16:59
b5a551c
to
ed63f08
Compare
/rebase |
woody-apple
force-pushed
the
add_multicast_capability
branch
from
December 3, 2021 17:58
ed63f08
to
334de06
Compare
PR #12342: Size comparison from fc07dcf to 334de06 Increases above 0.2%:
Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Dec 3, 2021
andy31415
reviewed
Dec 3, 2021
@jepenven-silabs can you address comments so we can proceed forward with this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix issue #11078
Fix issue #3377
Partial fix of #12200
Change overview
Added IPV6 multicast address building in the SessionManager before sending a group message.
Added IPV6 multicast listeners initialization in server.cpp
Testing
Tested with the *.yaml test suite by enabling the remaining step of the TestGroupMessaging.yaml
Disabled the TestGroupMessaging on Darwin CI because of failure to enable IPV6 Multicast listening (out of scope of this PR since CI related)
Todo
Still need to implement listening with LWIP #12327