Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always search on-network #12321

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Always search on-network #12321

merged 5 commits into from
Dec 7, 2021

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Nov 29, 2021

Problem

Nodes that have already been commissioned will always use on-network setup regardless of what is in the setup payload. SetUpCodePairer will only check on-network if it's in the payload.

Change overview

SetUpCodePairer always checks on-network.

Testing

chip-tool and chip-lighting-app with a BLE only qr code.

@cecille
Always search on-network
e0a17f8 
Nodes that have already been commissioned will always use on-network
setup regardless of what is in the setup payload.
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #12321: Size comparison from 7d55d2e to e0a17f8

Decreases (1 build for linux)
platform target config section 7d55d2e e0a17f8 change % change
linux chip-tool debug (read only) 6088629 6088597 -32 -0.0
.text 5406517 5406485 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7d55d2e e0a17f8 change % change
efr32 lighting-app BRD4161A (read only) 762200 762200 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762192 762192 0 0.0
BRD4161A+rpc (read only) 790632 790632 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790624 790624 0 0.0
lock-app BRD4161A (read only) 736144 736144 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736136 736136 0 0.0
window-app BRD4161A (read only) 739208 739208 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739200 739200 0 0.0
esp32 all-clusters-app c3devkit (read only) 836536 836536 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836536 836536 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907919 907919 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902535 902535 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723320 723320 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637272 637272 0 0.0
lock-app k32w061+debug (read/write) 612392 612392 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535932 535932 0 0.0
shell k32w061+debug (read/write) 677712 677712 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590128 590128 0 0.0
linux all-clusters-app debug (read only) 1775081 1775081 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138965 138965 0 0.0
.text 1497746 1497746 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6088629 6088597 -32 -0.0
(read/write) 198808 198808 0 0.0
.bss 40096 40096 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 152000 152000 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 292840 292840 0 0.0
.text 5406517 5406485 -32 -0.0
lighting-app debug+rpc (read only) 1629065 1629065 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131889 131889 0 0.0
.text 1359458 1359458 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406873 1406873 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177330 1177330 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921377 1921377 0 0.0
(read/write) 319072 319072 0 0.0
.bss 250264 250264 0 0.0
.data 1632 1632 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160872 160872 0 0.0
.text 1612162 1612162 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294976 2294976 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257576 1257576 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280256 2280256 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242856 1242856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253336 2253336 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215936 1215936 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875611 875611 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590116 590116 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838187 838187 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564432 564432 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800650 800650 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519580 519580 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846539 846539 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568388 568388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771810 771810 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497940 497940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852511 852511 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572432 572432 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845619 845619 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567512 567512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311304 2311304 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269568 1269568 0 0.0
lock-app default (read/write) 2223120 2223120 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181384 1181384 0 0.0
qpg lighting-app qpg6100+debug (read only) 503096 503096 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497776 497776 0 0.0
lock-app qpg6100+debug (read only) 475804 475804 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470484 470484 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777398 777398 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540724 540724 0 0.0

@pullapprove pullapprove bot requested a review from vijs November 30, 2021 17:15
@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #12321: Size comparison from a7b18b8 to 156fa9f

Decreases (1 build for linux)
platform target config section a7b18b8 156fa9f change % change
linux chip-tool debug (read only) 6272725 6272709 -16 -0.0
.text 5574133 5574117 -16 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a7b18b8 156fa9f change % change
efr32 lighting-app BRD4161A (read only) 763296 763296 0 0.0
(read/write) 119972 119972 0 0.0
.bss 118164 118164 0 0.0
.data 1808 1808 0 0.0
.text 763288 763288 0 0.0
BRD4161A+rpc (read only) 791784 791784 0 0.0
(read/write) 138276 138276 0 0.0
.bss 136364 136364 0 0.0
.data 1908 1908 0 0.0
.text 791776 791776 0 0.0
lock-app BRD4161A (read only) 737176 737176 0 0.0
(read/write) 117684 117684 0 0.0
.bss 115916 115916 0 0.0
.data 1764 1764 0 0.0
.text 737168 737168 0 0.0
window-app BRD4161A (read only) 740264 740264 0 0.0
(read/write) 118116 118116 0 0.0
.bss 116340 116340 0 0.0
.data 1772 1772 0 0.0
.text 740256 740256 0 0.0
esp32 all-clusters-app c3devkit (read only) 837356 837356 0 0.0
(read/write) 1224050 1224050 0 0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166248 166248 0 0.0
.flash.text 837356 837356 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908839 908839 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194100 194100 0 0.0
.flash.text 903455 903455 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724524 724524 0 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638112 638112 0 0.0
lock-app k32w061+debug (read/write) 613524 613524 0 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536708 536708 0 0.0
shell k32w061+debug (read/write) 679304 679304 0 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590932 590932 0 0.0
linux all-clusters-app debug (read only) 1781513 1781513 0 0.0
(read/write) 125192 125192 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65728 65728 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139797 139797 0 0.0
.text 1502098 1502098 0 0.0
bridge-app debug+rpc (read only) 1352565 1352565 0 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113820 113820 0 0.0
.text 1138533 1138533 0 0.0
chip-tool debug (read only) 6272725 6272709 -16 -0.0
(read/write) 197904 197904 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157880 157880 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 295624 295624 0 0.0
.text 5574133 5574117 -16 -0.0
lighting-app debug+rpc (read only) 1632633 1632633 0 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 57072 57072 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132273 132273 0 0.0
.text 1362450 1362450 0 0.0
ota-provider-app debug (read only) 1313009 1313009 0 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115024 115024 0 0.0
.text 1097538 1097538 0 0.0
ota-requestor-app debug (read only) 1412993 1412993 0 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 126848 126848 0 0.0
.text 1182258 1182258 0 0.0
shell debug (read only) 808969 808969 0 0.0
(read/write) 60104 60104 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38528 38528 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79794 79794 0 0.0
.text 623474 623474 0 0.0
tv-app debug (read only) 1927281 1927281 0 0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161448 161448 0 0.0
.text 1617298 1617298 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296632 2296632 0 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259232 1259232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281312 2281312 0 0.0
.bss 172636 172636 0 0.0
.data 5480 5480 0 0.0
.heap 858328 858328 0 0.0
.text 1243912 1243912 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254344 2254344 0 0.0
.bss 171452 171452 0 0.0
.data 5464 5464 0 0.0
.heap 859528 859528 0 0.0
.text 1216944 1216944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2045928 2045928 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008528 1008528 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876807 876807 0 0.0
bss 113136 113136 0 0.0
rodata 97368 97368 0 0.0
text 590764 590764 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 839255 839255 0 0.0
bss 109488 109488 0 0.0
rodata 88632 88632 0 0.0
text 564932 564932 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801842 801842 0 0.0
bss 114512 114512 0 0.0
rodata 92628 92628 0 0.0
text 520220 520220 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847635 847635 0 0.0
bss 110176 110176 0 0.0
rodata 93108 93108 0 0.0
text 569012 569012 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772906 772906 0 0.0
bss 111584 111584 0 0.0
rodata 88396 88396 0 0.0
text 498560 498560 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853679 853679 0 0.0
bss 110312 110312 0 0.0
rodata 94840 94840 0 0.0
text 573080 573080 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846743 846743 0 0.0
bss 110188 110188 0 0.0
rodata 92976 92976 0 0.0
text 568140 568140 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779227 779227 0 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521888 521888 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694274 694274 0 0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442496 442496 0 0.0
p6 all-clusters-app default (read/write) 2318024 2318024 0 0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276288 1276288 0 0.0
lock-app default (read/write) 2229112 2229112 0 0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187376 1187376 0 0.0
qpg lighting-app qpg6100+debug (read only) 496884 496884 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491564 491564 0 0.0
lock-app qpg6100+debug (read only) 469480 469480 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464160 464160 0 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778686 778686 0 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541466 541466 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12321: Size comparison from 89c17fe to adbc1dc

Increases above 0.2%:

platform target config section 89c17fe adbc1dc change % change
efr32 lock-app BRD4161A .data 1784 1788 4 0.2
k32w lock-app k32w061+debug .bss 69752 69976 224 0.3
shell k32w061+debug .bss 81400 81624 224 0.3
linux all-clusters-app debug .init_array 688 696 8 1.2
.rodata 149109 149589 480 0.3
nrfconnect lock-app nrf52840dk_nrf52840 rodata 95324 95704 380 0.4
nrf5340dk_nrf5340_cpuapp rodata 90616 90996 380 0.4
p6 all-clusters-app default .data 2456 2464 8 0.3
qpg lock-app qpg6100+debug .bss 79184 79408 224 0.3
.data 916 920 4 0.4
Increases (15 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section 89c17fe adbc1dc change % change
efr32 lock-app BRD4161A (read only) 725800 726592 792 0.1
(read/write) 117736 117968 232 0.2
.bss 115952 116176 224 0.2
.data 1784 1788 4 0.2
.text 725792 726584 792 0.1
esp32 all-clusters-app c3devkit (read only) 847284 847594 310 0.0
.flash.text 847284 847594 310 0.0
m5stack (read only) 917759 918067 308 0.0
.flash.text 912375 912683 308 0.0
k32w lock-app k32w061+debug (read/write) 617792 618736 944 0.2
.bss 69752 69976 224 0.3
.data 1824 1828 4 0.2
.text 540416 541132 716 0.1
shell k32w061+debug (read/write) 683684 684644 960 0.1
.bss 81400 81624 224 0.3
.data 1796 1800 4 0.2
.text 594688 595420 732 0.1
linux all-clusters-app debug (read only) 1845873 1848137 2264 0.1
.init_array 688 696 8 1.2
.rodata 149109 149589 480 0.3
.text 1553826 1555490 1664 0.1
chip-tool debug .rodata 307384 307512 128 0.0
tv-app debug .bss 247256 247288 32 0.0
.text 1700754 1700786 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2306472 2306704 232 0.0
.heap 851584 852856 1272 0.1
.text 1269048 1269280 232 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2269520 2270224 704 0.0
.bss 172120 172344 224 0.1
.text 1232120 1232824 704 0.1
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 862683 863655 972 0.1
bss 110792 111016 224 0.2
rodata 95324 95704 380 0.4
text 581188 581544 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788838 789794 956 0.1
bss 112204 112428 224 0.2
rodata 90616 90996 380 0.4
text 511620 511972 352 0.1
p6 all-clusters-app default (read/write) 2339024 2339080 56 0.0
.data 2456 2464 8 0.3
.heap 923024 924280 1256 0.1
.text 1297288 1297344 56 0.0
lock-app default (read/write) 2255240 2256048 808 0.0
.bss 97192 97416 224 0.2
.text 1213504 1214312 808 0.1
qpg lock-app qpg6100+debug (read only) 483392 484124 732 0.2
(read/write) 122332 122336 4 0.0
.bss 79184 79408 224 0.3
.data 916 920 4 0.4
.text 478072 478804 732 0.2
Decreases (9 builds for esp32, linux, mbed, p6)
platform target config section 89c17fe adbc1dc change % change
esp32 all-clusters-app c3devkit (read/write) 1224130 1222714 -1416 -0.1
.dram0.bss 56616 55352 -1264 -2.2
.flash.rodata 168000 167848 -152 -0.1
m5stack (read/write) 423092 421672 -1420 -0.3
.dram0.bss 62000 60728 -1272 -2.1
.flash.rodata 195796 195648 -148 -0.1
linux all-clusters-app debug (read/write) 124648 123216 -1432 -1.1
.bss 50928 49680 -1248 -2.5
.data.rel.ro 67184 66976 -208 -0.3
chip-tool debug (read only) 6635109 6593037 -42072 -0.6
(read/write) 201256 199400 -1856 -0.9
.data.rel.ro 160024 158168 -1856 -1.2
.text 5919253 5881541 -37712 -0.6
tv-app debug (read only) 2029761 2029745 -16 -0.0
.data.rel.ro 64200 64168 -32 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179676 178404 -1272 -0.7
lock-app CY8CPROTO_062_4343W+release .heap 858832 858608 -224 -0.0
p6 all-clusters-app default .bss 107860 106596 -1264 -1.2
lock-app default .heap 933856 933632 -224 -0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 89c17fe adbc1dc change % change
efr32 lighting-app BRD4161A (read only) 751784 751784 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751776 751776 0 0.0
BRD4161A+rpc (read only) 780440 780440 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780432 780432 0 0.0
lock-app BRD4161A (read only) 725800 726592 792 0.1
(read/write) 117736 117968 232 0.2
.bss 115952 116176 224 0.2
.data 1784 1788 4 0.2
.text 725792 726584 792 0.1
window-app BRD4161A (read only) 729096 729096 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 729088 729088 0 0.0
esp32 all-clusters-app c3devkit (read only) 847284 847594 310 0.0
(read/write) 1224130 1222714 -1416 -0.1
.dram0.bss 56616 55352 -1264 -2.2
.dram0.data 14052 14052 0 0.0
.flash.rodata 168000 167848 -152 -0.1
.flash.text 847284 847594 310 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 917759 918067 308 0.0
(read/write) 423092 421672 -1420 -0.3
.dram0.bss 62000 60728 -1272 -2.1
.dram0.data 34016 34016 0 0.0
.flash.rodata 195796 195648 -148 -0.1
.flash.text 912375 912683 308 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 617792 618736 944 0.2
.bss 69752 69976 224 0.3
.data 1824 1828 4 0.2
.text 540416 541132 716 0.1
shell k32w061+debug (read/write) 683684 684644 960 0.1
.bss 81400 81624 224 0.3
.data 1796 1800 4 0.2
.text 594688 595420 732 0.1
linux all-clusters-app debug (read only) 1845873 1848137 2264 0.1
(read/write) 124648 123216 -1432 -1.1
.bss 50928 49680 -1248 -2.5
.data 1120 1120 0 0.0
.data.rel.ro 67184 66976 -208 -0.3
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 688 696 8 1.2
.rodata 149109 149589 480 0.3
.text 1553826 1555490 1664 0.1
bridge-app debug+rpc (read only) 1431021 1431021 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121044 121044 0 0.0
.text 1205077 1205077 0 0.0
chip-tool debug (read only) 6635109 6593037 -42072 -0.6
(read/write) 201256 199400 -1856 -0.9
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160024 158168 -1856 -1.2
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307384 307512 128 0.0
.text 5919253 5881541 -37712 -0.6
lighting-app debug+rpc (read only) 1716161 1716161 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 141681 141681 0 0.0
.text 1431810 1431810 0 0.0
ota-provider-app debug (read only) 1391625 1391625 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121800 121800 0 0.0
.text 1165138 1165138 0 0.0
ota-requestor-app debug (read only) 1498297 1498297 0 0.0
(read/write) 76816 76816 0 0.0
.bss 40992 40992 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 134288 134288 0 0.0
.text 1255314 1255314 0 0.0
shell debug (read only) 822041 822041 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83634 83634 0 0.0
.text 631570 631570 0 0.0
tv-app debug (read only) 2029761 2029745 -16 -0.0
(read/write) 320032 320032 0 0.0
.bss 247256 247288 32 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64200 64168 -32 -0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174216 174216 0 0.0
.text 1700754 1700786 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2306472 2306704 232 0.0
.bss 179676 178404 -1272 -0.7
.data 5184 5184 0 0.0
.heap 851584 852856 1272 0.1
.text 1269048 1269280 232 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269520 2270224 704 0.0
.bss 172120 172344 224 0.1
.data 5496 5496 0 0.0
.heap 858832 858608 -224 -0.0
.text 1232120 1232824 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047408 2047408 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010008 1010008 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817626 817626 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533164 533164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862683 863655 972 0.1
bss 110792 111016 224 0.2
rodata 95324 95704 380 0.4
text 581188 581544 356 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788838 789794 956 0.1
bss 112204 112428 224 0.2
rodata 90616 90996 380 0.4
text 511620 511972 352 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585084 585084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580316 580316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779907 779907 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521920 521920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442524 442524 0 0.0
p6 all-clusters-app default (read/write) 2339024 2339080 56 0.0
.bss 107860 106596 -1264 -1.2
.data 2456 2464 8 0.3
.heap 923024 924280 1256 0.1
.text 1297288 1297344 56 0.0
light-app default (read/write) 2279744 2279744 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1238008 1238008 0 0.0
lock-app default (read/write) 2255240 2256048 808 0.0
.bss 97192 97416 224 0.2
.data 2296 2296 0 0.0
.heap 933856 933632 -224 -0.0
.text 1213504 1214312 808 0.1
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 483392 484124 732 0.2
(read/write) 122332 122336 4 0.0
.bss 79184 79408 224 0.3
.data 916 920 4 0.4
.text 478072 478804 732 0.2
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794794 794794 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554586 554586 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this has had enough time for review, and comments are addressed

@andy31415 andy31415 merged commit e98e43f into project-chip:master Dec 7, 2021
@cecille cecille deleted the setupcodepairer_always_onnetwork branch April 1, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple left review comments

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@vijs vijs Awaiting requested review from vijs

Assignees
No one assigned
Labels
controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecille @woody-apple @andy31415 @vivien-apple