Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out E2E build rules into different directories #12303

Merged
merged 38 commits into from
Dec 2, 2021

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Nov 26, 2021

Problem

Trying to follow the CI build rules invokes gn on the same directory several times, which overrides build caches on that directory. This means any change cause significantly more rebuilds

Change overview

  • make build_examples understand a lot of build variants (no-ble, separate event loop, tsan)
  • use these build rules for running linux and darwin E2E tests
  • Update how build targets are selected via matrix (uses build strings instead of bools)

Testing

Using act and also CI will validate
Manually ran some builds and validated gn arguments.

@github-actions
Copy link

github-actions bot commented Nov 26, 2021

PR #12303: Size comparison from 8a2fd0d to 8f4805e

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8a2fd0d 8f4805e change % change
efr32 lighting-app BRD4161A (read only) 762072 762072 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762064 762064 0 0.0
BRD4161A+rpc (read only) 790520 790520 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790512 790512 0 0.0
lock-app BRD4161A (read only) 736032 736032 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736024 736024 0 0.0
window-app BRD4161A (read only) 739096 739096 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739088 739088 0 0.0
esp32 all-clusters-app c3devkit (read only) 836422 836422 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836422 836422 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907835 907835 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902451 902451 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723208 723208 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637160 637160 0 0.0
lock-app k32w061+debug (read/write) 612280 612280 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535820 535820 0 0.0
shell k32w061+debug (read/write) 677600 677600 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590016 590016 0 0.0
linux all-clusters-app debug (read only) 1774185 1774185 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138869 138869 0 0.0
.text 1496946 1496946 0 0.0
bridge-app debug+rpc (read only) 1348509 1348509 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113500 113500 0 0.0
.text 1134917 1134917 0 0.0
chip-tool debug (read only) 6085653 6085653 0 0.0
(read/write) 199920 199920 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151888 151888 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 291816 291816 0 0.0
.text 5404709 5404709 0 0.0
lighting-app debug+rpc (read only) 1628169 1628169 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131793 131793 0 0.0
.text 1358658 1358658 0 0.0
ota-provider-app debug (read only) 1309537 1309537 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114832 114832 0 0.0
.text 1094354 1094354 0 0.0
ota-requestor-app debug (read only) 1405977 1405977 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126304 126304 0 0.0
.text 1176530 1176530 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1918385 1918385 0 0.0
(read/write) 320152 320152 0 0.0
.bss 250232 250232 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159848 159848 0 0.0
.text 1610338 1610338 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294736 2294736 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257336 1257336 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279952 2279952 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242552 1242552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253096 2253096 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215696 1215696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875499 875499 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590008 590008 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838075 838075 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564324 564324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800538 800538 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519472 519472 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846427 846427 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568280 568280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771698 771698 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497832 497832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852399 852399 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572324 572324 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845523 845523 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567408 567408 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311176 2311176 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269440 1269440 0 0.0
lock-app default (read/write) 2222992 2222992 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181256 1181256 0 0.0
qpg lighting-app qpg6100+debug (read only) 502992 502992 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497672 497672 0 0.0
lock-app qpg6100+debug (read only) 475708 475708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470388 470388 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777286 777286 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540616 540616 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

PR #12303: Size comparison from dc10c82 to 4caa376

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dc10c823 4caa376 change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
esp32 all-clusters-app c3devkit (read only) 839114 839114 0 0.0
(read/write) 1225090 1225090 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14036 14036 0 0.0
.flash.rodata 166968 166968 0 0.0
.flash.text 839114 839114 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910791 910791 0 0.0
(read/write) 424312 424312 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194808 194808 0 0.0
.flash.text 905407 905407 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1797065 0 0.0
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1510818 0 0.0
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6528285 0 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 304984 0 0.0
.text 5816693 5816693 0 0.0
lighting-app debug+rpc (read only) 1651097 1651097 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373906 0 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2299376 0 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261976 1261976 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571288 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850459 0 0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694946 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2320840 2320840 0 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1279104 0 0.0
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231984 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190248 0 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@project-chip project-chip deleted a comment from github-actions bot Dec 2, 2021
@andy31415
Copy link
Contributor Author

fast track: this has been up for a while and had some review passes, I just had been fighing with CI for a long time (and it turns out darwin CANNOT run tv tests, but it did not run those before either). Change does not change sdk behaviour only CI.

@andy31415 andy31415 merged commit 2eb4c51 into project-chip:master Dec 2, 2021
@andy31415 andy31415 deleted the more_host_build_variants branch June 14, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants