-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out E2E build rules into different directories #12303
Merged
andy31415
merged 38 commits into
project-chip:master
from
andy31415:more_host_build_variants
Dec 2, 2021
Merged
Separate out E2E build rules into different directories #12303
andy31415
merged 38 commits into
project-chip:master
from
andy31415:more_host_build_variants
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12303: Size comparison from 8a2fd0d to 8f4805e Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
mspang
November 29, 2021 13:09
…follow up later to figure it out
PR #12303: Size comparison from dc10c82 to 4caa376 Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Dec 2, 2021
fast track: this has been up for a while and had some review passes, I just had been fighing with CI for a long time (and it turns out darwin CANNOT run tv tests, but it did not run those before either). Change does not change sdk behaviour only CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Trying to follow the CI build rules invokes gn on the same directory several times, which overrides build caches on that directory. This means any change cause significantly more rebuilds
Change overview
Testing
Using act and also CI will validate
Manually ran some builds and validated gn arguments.