-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable some more string tests. #12281
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-string-tests
Nov 26, 2021
Merged
Enable some more string tests. #12281
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:more-string-tests
Nov 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
November 26, 2021 06:10
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
wbschiller and
woody-apple
November 26, 2021 06:10
PR #12281: Size comparison from 659190d to ed67cc2 Full report (13 builds for efr32, k32w, p6, qpg, telink)
|
The chip-tool yaml test harness was not measuring the length of strings correctly (using length in UTF-16 code units, not in UTF-8 code units). Fixing that lets us enable a few more tests. This also improves notValue failure reporting and removes the operator== on Span that should not exist.
bzbarsky-apple
force-pushed
the
more-string-tests
branch
from
November 26, 2021 06:57
ed67cc2
to
30f67e8
Compare
PR #12281: Size comparison from 659190d to 30f67e8 Increases (1 build for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 26, 2021
andy31415
approved these changes
Nov 26, 2021
fast track: adding test functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chip-tool yaml test harness was not measuring the length of
strings correctly (using length in UTF-16 code units, not in UTF-8
code units). Fixing that lets us enable a few more tests.
This also improves notValue failure reporting and removes the
operator== on Span that should not exist.
Problem
Some tests are disabled.
Change overview
See above.
Testing
The tests now pass.