Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Fix esp32 platform bugs #12082

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Nov 22, 2021

Problem

There are some bugs for ESP32 platform found in TE7. #11822 #11821 #11895 #11896 #11898

Change overview

  1. Fix WiFiDiagnotics read bugs for ESP32 platform.
  2. Add GetNetWorkInterface and ReleaseNetworkInterface function for ESP32 platform
  3. Fix the bugs of identify-cluster for all-clusters-app

Testing

Test manually

  1. The WiFiDiagnotics cluster gets the correct attribute
  2. read network-interfaces command could get the interfaces now
  3. The identify clusters works well.

@github-actions
Copy link

github-actions bot commented Nov 22, 2021

PR #12082: Size comparison from 4bb1e67 to 21abaf2

Increases above 0.2%:

platform target config section 4bb1e67 21abaf2 change % change
esp32 all-clusters-app c3devkit .flash.rodata 164176 164840 664 0.4
m5stack .flash.rodata 192144 192784 640 0.3
Increases (2 builds for esp32)
platform target config section 4bb1e67 21abaf2 change % change
esp32 all-clusters-app c3devkit (read only) 831812 833354 1542 0.2
(read/write) 1221210 1221938 728 0.1
.dram0.bss 57696 57752 56 0.1
.flash.rodata 164176 164840 664 0.4
.flash.text 831812 833354 1542 0.2
m5stack (read only) 902831 904347 1516 0.2
(read/write) 420536 421232 696 0.2
.dram0.bss 63056 63112 56 0.1
.flash.rodata 192144 192784 640 0.3
.flash.text 897447 898963 1516 0.2
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4bb1e67 21abaf2 change % change
efr32 lighting-app BRD4161A (read only) 750704 750704 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750696 750696 0 0.0
BRD4161A+rpc (read only) 738228 738228 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738220 738220 0 0.0
lock-app BRD4161A (read only) 727760 727760 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727752 727752 0 0.0
window-app BRD4161A (read only) 728744 728744 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728736 728736 0 0.0
esp32 all-clusters-app c3devkit (read only) 831812 833354 1542 0.2
(read/write) 1221210 1221938 728 0.1
.dram0.bss 57696 57752 56 0.1
.dram0.data 14092 14092 0 0.0
.flash.rodata 164176 164840 664 0.4
.flash.text 831812 833354 1542 0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 902831 904347 1516 0.2
(read/write) 420536 421232 696 0.2
.dram0.bss 63056 63112 56 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 192144 192784 640 0.3
.flash.text 897447 898963 1516 0.2
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707512 707512 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622588 622588 0 0.0
lock-app k32w061+debug (read/write) 598944 598944 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523548 523548 0 0.0
shell k32w061+debug (read/write) 664320 664320 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577796 577796 0 0.0
linux all-clusters-app debug (read only) 1746153 1746153 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137493 137493 0 0.0
.text 1473026 1473026 0 0.0
bridge-app debug+rpc (read only) 1325965 1325965 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1116533 1116533 0 0.0
chip-tool debug (read only) 4999845 4999845 0 0.0
(read/write) 165960 165960 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118352 118352 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 269738 269738 0 0.0
.text 4419957 4419957 0 0.0
lighting-app debug+rpc (read only) 1595073 1595073 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1330418 1330418 0 0.0
ota-provider-app debug (read only) 1273513 1273513 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1061874 1061874 0 0.0
ota-requestor-app debug (read only) 1369761 1369761 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125448 125448 0 0.0
.text 1143938 1143938 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1887721 1887721 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158373 158373 0 0.0
.text 1583906 1583906 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290128 2290128 0 0.0
.bss 180300 180300 0 0.0
.data 5224 5224 0 0.0
.heap 850920 850920 0 0.0
.text 1252728 1252728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274256 2274256 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236856 1236856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250096 2250096 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212696 1212696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865235 865235 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583176 583176 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827603 827603 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557344 557344 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790274 790274 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512644 512644 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840635 840635 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563268 563268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765922 765922 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492832 492832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846775 846775 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567452 567452 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840335 840335 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562888 562888 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2302984 2302984 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261248 1261248 0 0.0
lock-app default (read/write) 2216200 2216200 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174464 1174464 0 0.0
qpg lighting-app qpg6100+debug (read only) 494272 494272 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488952 488952 0 0.0
lock-app qpg6100+debug (read only) 469236 469236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463916 463916 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768626 768626 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533768 533768 0 0.0

@andy31415
Copy link
Contributor

fast track: platform specific change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants