Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ZAP and set defaultReportable to true for attributes. #12074

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Update ZAP and set defaultReportable to true for attributes. #12074

merged 1 commit into from
Nov 24, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This should cause IS_REPORTABLE to be true for attributes unless the
XML has reportable="false". Still waiting on
project-chip/zap#318 to be fixed to then get
us the behavior we really want.

Problem

Attributes do not default to reportable in ZAP for Matter.

Change overview

Add infrastructure to make the ZAP database have the right state for the attributes; still needs to be properly propagated to the .zap file.

Testing

Checked what the sqlite database has with this fix and verified that attributes are reportable unless reportable="false" is set.

@boring-cyborg boring-cyborg bot added the app label Nov 21, 2021
@github-actions
Copy link

github-actions bot commented Nov 21, 2021 •
edited
Loading

PR #12074: Size comparison from 165ae97 to 59679d7

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 165ae97 59679d7 change % change
efr32 lighting-app BRD4161A (read only) 750704 750704 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750696 750696 0 0.0
BRD4161A+rpc (read only) 738228 738228 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738220 738220 0 0.0
lock-app BRD4161A (read only) 727760 727760 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727752 727752 0 0.0
window-app BRD4161A (read only) 728744 728744 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728736 728736 0 0.0
esp32 all-clusters-app c3devkit (read only) 831812 831812 0 0.0
(read/write) 1221210 1221210 0 0.0
.dram0.bss 57696 57696 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164176 164176 0 0.0
.flash.text 831812 831812 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 902831 902831 0 0.0
(read/write) 420536 420536 0 0.0
.dram0.bss 63056 63056 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192144 192144 0 0.0
.flash.text 897447 897447 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707512 707512 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622588 622588 0 0.0
lock-app k32w061+debug (read/write) 598944 598944 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523548 523548 0 0.0
shell k32w061+debug (read/write) 664320 664320 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577796 577796 0 0.0
linux all-clusters-app debug (read only) 1746153 1746153 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137493 137493 0 0.0
.text 1473026 1473026 0 0.0
bridge-app debug+rpc (read only) 1325965 1325965 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1116533 1116533 0 0.0
chip-tool debug (read only) 4999845 4999845 0 0.0
(read/write) 165960 165960 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118352 118352 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 269738 269738 0 0.0
.text 4419957 4419957 0 0.0
lighting-app debug+rpc (read only) 1595073 1595073 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1330418 1330418 0 0.0
ota-provider-app debug (read only) 1273513 1273513 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1061874 1061874 0 0.0
ota-requestor-app debug (read only) 1369761 1369761 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125448 125448 0 0.0
.text 1143938 1143938 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1887721 1887721 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158373 158373 0 0.0
.text 1583906 1583906 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290128 2290128 0 0.0
.bss 180300 180300 0 0.0
.data 5224 5224 0 0.0
.heap 850920 850920 0 0.0
.text 1252728 1252728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274256 2274256 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236856 1236856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250096 2250096 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212696 1212696 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865235 865235 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583176 583176 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827603 827603 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557344 557344 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790274 790274 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512644 512644 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840635 840635 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563268 563268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765922 765922 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492832 492832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846775 846775 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567452 567452 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840335 840335 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562888 562888 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2302984 2302984 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261248 1261248 0 0.0
lock-app default (read/write) 2216200 2216200 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174464 1174464 0 0.0
qpg lighting-app qpg6100+debug (read only) 494272 494272 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488952 488952 0 0.0
lock-app qpg6100+debug (read only) 469236 469236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463916 463916 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768626 768626 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533768 533768 0 0.0

jmeg-sfy
jmeg-sfy approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jmeg-sfy jmeg-sfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we an action to do on the example Cluster XML ?

@bzbarsky-apple
Update ZAP and set defaultReportable to true for attributes.
b521a1e 
This should cause IS_REPORTABLE to be true for attributes unless the
XML has reportable="false".  Still waiting on
project-chip/zap#318 to be fixed to then get
us the behavior we really want.
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12074: Size comparison from 2e16d32 to b521a1e

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2e16d32 b521a1e change % change
efr32 lighting-app BRD4161A (read only) 751376 751376 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117884 117884 0 0.0
.data 1808 1808 0 0.0
.text 751368 751368 0 0.0
BRD4161A+rpc (read only) 738884 738884 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134388 134388 0 0.0
.data 1932 1932 0 0.0
.text 738876 738876 0 0.0
lock-app BRD4161A (read only) 728448 728448 0 0.0
(read/write) 117476 117476 0 0.0
.bss 115708 115708 0 0.0
.data 1764 1764 0 0.0
.text 728440 728440 0 0.0
window-app BRD4161A (read only) 731896 731896 0 0.0
(read/write) 117836 117836 0 0.0
.bss 116060 116060 0 0.0
.data 1772 1772 0 0.0
.text 731888 731888 0 0.0
esp32 all-clusters-app c3devkit (read only) 833664 833664 0 0.0
(read/write) 1222106 1222106 0 0.0
.dram0.bss 57760 57760 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 164992 164992 0 0.0
.flash.text 833664 833664 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904711 904711 0 0.0
(read/write) 421400 421400 0 0.0
.dram0.bss 63120 63120 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 192936 192936 0 0.0
.flash.text 899327 899327 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707928 707928 0 0.0
.bss 77212 77212 0 0.0
.data 1920 1920 0 0.0
.text 622996 622996 0 0.0
lock-app k32w061+debug (read/write) 599368 599368 0 0.0
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 523956 523956 0 0.0
shell k32w061+debug (read/write) 664744 664744 0 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578204 578204 0 0.0
linux all-clusters-app debug (read only) 1748801 1748801 0 0.0
(read/write) 128688 128688 0 0.0
.bss 58576 58576 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63760 63760 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138549 138549 0 0.0
.text 1473874 1473874 0 0.0
bridge-app debug+rpc (read only) 1328645 1328645 0 0.0
(read/write) 76760 76760 0 0.0
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28608 28608 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113116 113116 0 0.0
.text 1117381 1117381 0 0.0
chip-tool debug (read only) 5875885 5875885 0 0.0
(read/write) 195936 195936 0 0.0
.bss 39896 39896 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148192 148192 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 278778 278778 0 0.0
.text 5216741 5216741 0 0.0
lighting-app debug+rpc (read only) 1597849 1597849 0 0.0
(read/write) 109976 109976 0 0.0
.bss 47216 47216 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56208 56208 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 130833 130833 0 0.0
.text 1331266 1331266 0 0.0
ota-provider-app debug (read only) 1279465 1279465 0 0.0
(read/write) 75376 75376 0 0.0
.bss 44128 44128 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25336 25336 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114903 114903 0 0.0
.text 1065890 1065890 0 0.0
ota-requestor-app debug (read only) 1375729 1375729 0 0.0
(read/write) 79240 79240 0 0.0
.bss 46592 46592 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26664 26664 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126312 126312 0 0.0
.text 1147954 1147954 0 0.0
shell debug (read only) 804577 804577 0 0.0
(read/write) 66160 66160 0 0.0
.bss 23336 23336 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79279 0 0.0
.text 620194 620194 0 0.0
tv-app debug (read only) 1890329 1890329 0 0.0
(read/write) 318832 318832 0 0.0
.bss 249848 249848 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60520 60520 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159389 159389 0 0.0
.text 1584754 1584754 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290672 2290672 0 0.0
.bss 180308 180308 0 0.0
.data 5232 5232 0 0.0
.heap 850904 850904 0 0.0
.text 1253272 1253272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274800 2274800 0 0.0
.bss 172212 172212 0 0.0
.data 5584 5584 0 0.0
.heap 858648 858648 0 0.0
.text 1237400 1237400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250632 2250632 0 0.0
.bss 171092 171092 0 0.0
.data 5576 5576 0 0.0
.heap 859776 859776 0 0.0
.text 1213232 1213232 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050872 2050872 0 0.0
.bss 156280 156280 0 0.0
.data 4976 4976 0 0.0
.heap 875192 875192 0 0.0
.text 1013472 1013472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865667 865667 0 0.0
bss 110616 110616 0 0.0
rodata 95980 95980 0 0.0
text 583444 583444 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 828035 828035 0 0.0
bss 106972 106972 0 0.0
rodata 87164 87164 0 0.0
text 557612 557612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790706 790706 0 0.0
bss 111992 111992 0 0.0
rodata 91236 91236 0 0.0
text 512912 512912 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841099 841099 0 0.0
bss 109640 109640 0 0.0
rodata 92452 92452 0 0.0
text 563540 563540 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766386 766386 0 0.0
bss 111052 111052 0 0.0
rodata 87756 87756 0 0.0
text 493096 493096 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847207 847207 0 0.0
bss 109780 109780 0 0.0
rodata 94160 94160 0 0.0
text 567720 567720 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840799 840799 0 0.0
bss 109676 109676 0 0.0
rodata 92408 92408 0 0.0
text 563160 563160 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778639 778639 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521668 521668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693662 693662 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442276 442276 0 0.0
p6 all-clusters-app default (read/write) 2303656 2303656 0 0.0
.bss 113296 113296 0 0.0
.data 2536 2536 0 0.0
.heap 917512 917512 0 0.0
.text 1261920 1261920 0 0.0
lock-app default (read/write) 2216840 2216840 0 0.0
.bss 100952 100952 0 0.0
.data 2408 2408 0 0.0
.heap 929984 929984 0 0.0
.text 1175104 1175104 0 0.0
qpg lighting-app qpg6100+debug (read only) 494680 494680 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50264 50264 0 0.0
.data 1016 1016 0 0.0
.text 489360 489360 0 0.0
lock-app qpg6100+debug (read only) 469660 469660 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464340 464340 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769042 769042 0 0.0
bss 79136 79136 0 0.0
noinit 37160 37160 0 0.0
text 534004 534004 0 0.0

@woody-apple woody-apple merged commit f4ca9e2 into project-chip:master Nov 24, 2021
@bzbarsky-apple bzbarsky-apple deleted the update-zap branch November 24, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @yunhanw-google @yufengwangca @woody-apple @jmartinez-silabs @jmeg-sfy