-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix distcheck #120
Merged
Merged
Fix distcheck #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
robszewczyk,
tpmanley and
woody-apple
as code owners
March 26, 2020 17:24
BroderickCarlin
approved these changes
Mar 26, 2020
woody-apple
approved these changes
Mar 26, 2020
gerickson
reviewed
Mar 26, 2020
Makefile-Standalone
Outdated
# declaring the interface in time.h but not making the symbol | ||
# available in libSystem.dylib, resulting in a runtime crash. For | ||
# now, suppress use of clock_getttime on OS X by overriding | ||
# running on El Capitan (or earlier) due to issues with clock_gettime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to omit this whitespace change in this PR since it's unrelated to the fix at hand.
gerickson
approved these changes
Mar 26, 2020
Thanks @sagar-apple , LGTM |
pan-apple
previously approved these changes
Mar 26, 2020
mkardous-silabs
referenced
this pull request
in SiliconLabs/watt-sandbox
Oct 6, 2022
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request SiliconLabs#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request SiliconLabs#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request SiliconLabs#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Oct 24, 2022
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request #141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request #130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request #140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
jmartinez-silabs
referenced
this pull request
in SiliconLabs/matter
Feb 24, 2023
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request #141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request #130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request #140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
Thirsrin
pushed a commit
to Thirsrin/connectedhomeip
that referenced
this pull request
Jul 12, 2023
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request project-chip#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request project-chip#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request project-chip#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 5, 2023
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request project-chip#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request project-chip#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request project-chip#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request project-chip#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request project-chip#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request project-chip#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
suveshpratapa
pushed a commit
to suveshpratapa/connectedhomeip
that referenced
this pull request
May 22, 2024
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request project-chip#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request project-chip#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request project-chip#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
mykrupp
pushed a commit
to mykrupp/connectedhomeip
that referenced
this pull request
Jul 18, 2024
Merge in WMN_TOOLS/matter from unify_develop to silabs Squashed commit of the following: commit 13e9430082964ada7ea0478566c9a08f462ec1e9 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 14:19:01 2022 +0000 Pull request project-chip#141: Added MSLA license file Merge in WMN_TOOLS/matter from feature/added_msla_license to unify_develop Squashed commit of the following: commit f458f8544ed79bb5692ec04dbe01db544f650826 Author: Anders Esbensen <Anders.Esbensen@silabs.com> Date: Wed Oct 5 16:00:50 2022 +0200 Added MSLA license file commit 2cdc42127cf9fa9677cdc4fec7768c2360e4af83 Author: Dennis Jensen <Dennis.Jensen@silabs.com> Date: Wed Oct 5 14:06:10 2022 +0000 Pull request project-chip#130: UIC-2300: Node state monitor tests Merge in WMN_TOOLS/matter from feature/UIC-2300_Unit_test_matter_node_state_monitor to unify_develop Squashed commit of the following: commit e0523a5a0536970c1a8d344304f3db3f7cfc0737 Author: Dennis Jensen <dennis.jensen@silabs.com> Date: Wed Sep 28 12:17:28 2022 +0200 UIC-2300: Node state monitor tests Changes: * Testing the node state monitor. * Made the node state monitor more fail safe. * Added a wrapper around ember interface. * Testing the wrapper interface is called properly. commit b7048f3d8cb1e9f833e7748afacc356bfb35da66 Author: Kei Shirakizawa <Kei.Shirakizawa@silabs.com> Date: Wed Oct 5 13:45:02 2022 +0000 Pull request project-chip#140: UIC-2462 contd.: Fix comments for GN files Merge in WMN_TOOLS/matter from feature/UIC-2462-fix-gn-files to unify_develop Squashed commit of the following: commit d996c149eb3b130f9b1e540f3197cd185781e389 Author: Kei Shirakizawa <kei.shirakizawa@silabs.com> Date: Wed Oct 5 15:31:26 2022 +0200 UIC-2462 contd.: Fix comments for GN files ... and 23 more commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
distcheck fails because there's no rule to build lwip/tests.
Summary of Changes
Make sure lwip/tests is included as a SUB_DIR of lwip
fixes #119