Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup darwin usage of strtok and strncpy in DNS implementation #11934

Merged
merged 10 commits into from
Nov 18, 2021
Merged

Cleanup darwin usage of strtok and strncpy in DNS implementation #11934

merged 10 commits into from
Nov 18, 2021

Conversation

andy31415
Copy link
Contributor

Problem

  • Use after free: strtok returns a pointer into a string, so trying to use the falue after a free is wrong
  • unchecked (and unneeded) strdup usage (may return nullptr)
  • replaced strncpy with CopyString (chip implementation guarantees null terminator)

Change overview

  • use CopyString
  • do an in-place change to truncate the type to the first . character.

Testing

Expect CI to validate the changes (I made the changes on a linux machine)

@restyled-io restyled-io bot mentioned this pull request Nov 17, 2021
Closed
bzbarsky-apple
bzbarsky-apple requested changes Nov 17, 2021
View reviewed changes
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11934: Size comparison from e568d70 to 79fbcbf

Full report (17 builds for k32w, linux, p6, qpg, telink)
platform target config section e568d70 79fbcbf change % change
k32w lighting-app k32w061+se05x+release (read/write) 706012 706012 0 0.0
.bss 77196 77196 0 0.0
.data 1912 1912 0 0.0
.text 621104 621104 0 0.0
lock-app k32w061+debug (read/write) 597452 597452 0 0.0
.bss 67708 67708 0 0.0
.data 1880 1880 0 0.0
.text 522064 522064 0 0.0
shell k32w061+debug (read/write) 662796 662796 0 0.0
.bss 78836 78836 0 0.0
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
linux all-clusters-app debug (read only) 1716873 1716873 0 0.0
(read/write) 127200 127200 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135605 135605 0 0.0
.text 1447314 1447314 0 0.0
bridge-app debug+rpc (read only) 1312005 1312005 0 0.0
(read/write) 77392 77392 0 0.0
.bss 42480 42480 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110980 110980 0 0.0
.text 1103621 1103621 0 0.0
chip-tool debug (read only) 4970909 4970909 0 0.0
(read/write) 167304 167304 0 0.0
.bss 40840 40840 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267690 267690 0 0.0
.text 4392709 4392709 0 0.0
lighting-app debug+rpc (read only) 1581137 1581137 0 0.0
(read/write) 110608 110608 0 0.0
.bss 48144 48144 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128625 128625 0 0.0
.text 1317506 1317506 0 0.0
ota-provider-app debug (read only) 1260681 1260681 0 0.0
(read/write) 76040 76040 0 0.0
.bss 45088 45088 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113151 113151 0 0.0
.text 1049938 1049938 0 0.0
ota-requestor-app debug (read only) 1344369 1344369 0 0.0
(read/write) 79776 79776 0 0.0
.bss 47552 47552 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124168 124168 0 0.0
.text 1120226 1120226 0 0.0
shell debug (read only) 797793 797793 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78383 78383 0 0.0
.text 615394 615394 0 0.0
tv-app debug (read only) 1861825 1861825 0 0.0
(read/write) 319352 319352 0 0.0
.bss 250760 250760 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157029 157029 0 0.0
.text 1559666 1559666 0 0.0
p6 all-clusters-app default (read/write) 2296424 2296424 0 0.0
.bss 112304 112304 0 0.0
.data 2520 2520 0 0.0
.heap 918520 918520 0 0.0
.text 1254688 1254688 0 0.0
lock-app default (read/write) 2213896 2213896 0 0.0
.bss 100928 100928 0 0.0
.data 2400 2400 0 0.0
.heap 930016 930016 0 0.0
.text 1172160 1172160 0 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492792 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50216 50216 0 0.0
.data 1008 1008 0 0.0
.text 487472 487472 0 0.0
lock-app qpg6100+debug (read only) 467772 467772 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49160 49160 0 0.0
.data 964 964 0 0.0
.text 462452 462452 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 767062 0 0.0
bss 79104 79104 0 0.0
noinit 37160 37160 0 0.0
text 532258 532258 0 0.0

@restyled-io restyled-io bot mentioned this pull request Nov 17, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11934: Size comparison from e568d70 to 50a9c88

Full report (6 builds for k32w, p6, telink)
platform target config section e568d70 50a9c88 change % change
k32w lighting-app k32w061+se05x+release (read/write) 706012 706012 0 0.0
.bss 77196 77196 0 0.0
.data 1912 1912 0 0.0
.text 621104 621104 0 0.0
lock-app k32w061+debug (read/write) 597452 597452 0 0.0
.bss 67708 67708 0 0.0
.data 1880 1880 0 0.0
.text 522064 522064 0 0.0
shell k32w061+debug (read/write) 662796 662796 0 0.0
.bss 78836 78836 0 0.0
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
p6 all-clusters-app default (read/write) 2296424 2296424 0 0.0
.bss 112304 112304 0 0.0
.data 2520 2520 0 0.0
.heap 918520 918520 0 0.0
.text 1254688 1254688 0 0.0
lock-app default (read/write) 2213896 2213896 0 0.0
.bss 100928 100928 0 0.0
.data 2400 2400 0 0.0
.heap 930016 930016 0 0.0
.text 1172160 1172160 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 767062 0 0.0
bss 79104 79104 0 0.0
noinit 37160 37160 0 0.0
text 532258 532258 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11934: Size comparison from e568d70 to 0c73035

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section e568d70 0c73035 change % change
efr32 lighting-app BRD4161A (read only) 748400 748400 0 0.0
(read/write) 115572 115572 0 0.0
.bss 113772 113772 0 0.0
.data 1800 1800 0 0.0
.text 748392 748392 0 0.0
BRD4161A+rpc (read only) 735932 735932 0 0.0
(read/write) 132200 132200 0 0.0
.bss 130276 130276 0 0.0
.data 1924 1924 0 0.0
.text 735924 735924 0 0.0
lock-app BRD4161A (read only) 725472 725472 0 0.0
(read/write) 113356 113356 0 0.0
.bss 111596 111596 0 0.0
.data 1756 1756 0 0.0
.text 725464 725464 0 0.0
window-app BRD4161A (read only) 726432 726432 0 0.0
(read/write) 113676 113676 0 0.0
.bss 111916 111916 0 0.0
.data 1760 1760 0 0.0
.text 726424 726424 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706012 706012 0 0.0
.bss 77196 77196 0 0.0
.data 1912 1912 0 0.0
.text 621104 621104 0 0.0
lock-app k32w061+debug (read/write) 597452 597452 0 0.0
.bss 67708 67708 0 0.0
.data 1880 1880 0 0.0
.text 522064 522064 0 0.0
shell k32w061+debug (read/write) 662796 662796 0 0.0
.bss 78836 78836 0 0.0
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
linux all-clusters-app debug (read only) 1716873 1716873 0 0.0
(read/write) 127200 127200 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135605 135605 0 0.0
.text 1447314 1447314 0 0.0
bridge-app debug+rpc (read only) 1312005 1312005 0 0.0
(read/write) 77392 77392 0 0.0
.bss 42480 42480 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110980 110980 0 0.0
.text 1103621 1103621 0 0.0
chip-tool debug (read only) 4970909 4970909 0 0.0
(read/write) 167304 167304 0 0.0
.bss 40840 40840 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267690 267690 0 0.0
.text 4392709 4392709 0 0.0
lighting-app debug+rpc (read only) 1581137 1581137 0 0.0
(read/write) 110608 110608 0 0.0
.bss 48144 48144 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128625 128625 0 0.0
.text 1317506 1317506 0 0.0
ota-provider-app debug (read only) 1260681 1260681 0 0.0
(read/write) 76040 76040 0 0.0
.bss 45088 45088 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113151 113151 0 0.0
.text 1049938 1049938 0 0.0
ota-requestor-app debug (read only) 1344369 1344369 0 0.0
(read/write) 79776 79776 0 0.0
.bss 47552 47552 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124168 124168 0 0.0
.text 1120226 1120226 0 0.0
shell debug (read only) 797793 797793 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78383 78383 0 0.0
.text 615394 615394 0 0.0
tv-app debug (read only) 1861825 1861825 0 0.0
(read/write) 319352 319352 0 0.0
.bss 250760 250760 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157029 157029 0 0.0
.text 1559666 1559666 0 0.0
p6 all-clusters-app default (read/write) 2296424 2296424 0 0.0
.bss 112304 112304 0 0.0
.data 2520 2520 0 0.0
.heap 918520 918520 0 0.0
.text 1254688 1254688 0 0.0
lock-app default (read/write) 2213896 2213896 0 0.0
.bss 100928 100928 0 0.0
.data 2400 2400 0 0.0
.heap 930016 930016 0 0.0
.text 1172160 1172160 0 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492792 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50216 50216 0 0.0
.data 1008 1008 0 0.0
.text 487472 487472 0 0.0
lock-app qpg6100+debug (read only) 467772 467772 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49160 49160 0 0.0
.data 964 964 0 0.0
.text 462452 462452 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 767062 0 0.0
bss 79104 79104 0 0.0
noinit 37160 37160 0 0.0
text 532258 532258 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11934: Size comparison from 1359f6e to 5cfbe88

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1359f6e 5cfbe88 change % change
efr32 lighting-app BRD4161A (read only) 748512 748512 0 0.0
(read/write) 115476 115476 0 0.0
.bss 113676 113676 0 0.0
.data 1800 1800 0 0.0
.text 748504 748504 0 0.0
BRD4161A+rpc (read only) 736044 736044 0 0.0
(read/write) 132104 132104 0 0.0
.bss 130180 130180 0 0.0
.data 1924 1924 0 0.0
.text 736036 736036 0 0.0
lock-app BRD4161A (read only) 725584 725584 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111500 111500 0 0.0
.data 1756 1756 0 0.0
.text 725576 725576 0 0.0
window-app BRD4161A (read only) 726560 726560 0 0.0
(read/write) 113580 113580 0 0.0
.bss 111820 111820 0 0.0
.data 1760 1760 0 0.0
.text 726552 726552 0 0.0
esp32 all-clusters-app c3devkit (read only) 827530 827530 0 0.0
(read/write) 1220066 1220066 0 0.0
.dram0.bss 56624 56624 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 827530 827530 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898495 898495 0 0.0
(read/write) 419388 419388 0 0.0
.dram0.bss 61976 61976 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893111 893111 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 705932 705932 0 0.0
.bss 77100 77100 0 0.0
.data 1912 1912 0 0.0
.text 621120 621120 0 0.0
lock-app k32w061+debug (read/write) 597372 597372 0 0.0
.bss 67612 67612 0 0.0
.data 1880 1880 0 0.0
.text 522080 522080 0 0.0
shell k32w061+debug (read/write) 662700 662700 0 0.0
.bss 78740 78740 0 0.0
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
linux all-clusters-app debug (read only) 1718665 1718665 0 0.0
(read/write) 126752 126752 0 0.0
.bss 57328 57328 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136277 136277 0 0.0
.text 1448434 1448434 0 0.0
bridge-app debug+rpc (read only) 1313765 1313765 0 0.0
(read/write) 76944 76944 0 0.0
.bss 42032 42032 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111620 111620 0 0.0
.text 1104741 1104741 0 0.0
chip-tool debug (read only) 4975181 4975181 0 0.0
(read/write) 166856 166856 0 0.0
.bss 40392 40392 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268330 268330 0 0.0
.text 4396341 4396341 0 0.0
lighting-app debug+rpc (read only) 1582849 1582849 0 0.0
(read/write) 110160 110160 0 0.0
.bss 47696 47696 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129201 129201 0 0.0
.text 1318642 1318642 0 0.0
ota-provider-app debug (read only) 1262441 1262441 0 0.0
(read/write) 75592 75592 0 0.0
.bss 44640 44640 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113791 113791 0 0.0
.text 1051058 1051058 0 0.0
ota-requestor-app debug (read only) 1348113 1348113 0 0.0
(read/write) 79328 79328 0 0.0
.bss 47104 47104 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124808 124808 0 0.0
.text 1123330 1123330 0 0.0
shell debug (read only) 798129 798129 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78639 78639 0 0.0
.text 615474 615474 0 0.0
tv-app debug (read only) 1865521 1865521 0 0.0
(read/write) 318904 318904 0 0.0
.bss 250312 250312 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157637 157637 0 0.0
.text 1562754 1562754 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2286616 2286616 0 0.0
.bss 179220 179220 0 0.0
.data 5216 5216 0 0.0
.heap 852008 852008 0 0.0
.text 1249216 1249216 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272552 2272552 0 0.0
.bss 172084 172084 0 0.0
.data 5576 5576 0 0.0
.heap 858784 858784 0 0.0
.text 1235152 1235152 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248456 2248456 0 0.0
.bss 170972 170972 0 0.0
.data 5568 5568 0 0.0
.heap 859904 859904 0 0.0
.text 1211056 1211056 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863591 863591 0 0.0
bss 110496 110496 0 0.0
rodata 95784 95784 0 0.0
text 581696 581696 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 825991 825991 0 0.0
bss 106852 106852 0 0.0
rodata 86968 86968 0 0.0
text 555864 555864 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788634 788634 0 0.0
bss 111872 111872 0 0.0
rodata 91044 91044 0 0.0
text 511168 511168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839007 839007 0 0.0
bss 109520 109520 0 0.0
rodata 92256 92256 0 0.0
text 561788 561788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764310 764310 0 0.0
bss 110932 110932 0 0.0
rodata 87560 87560 0 0.0
text 491352 491352 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845115 845115 0 0.0
bss 109660 109660 0 0.0
rodata 93964 93964 0 0.0
text 565972 565972 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838707 838707 0 0.0
bss 109556 109556 0 0.0
rodata 92212 92212 0 0.0
text 561408 561408 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2296552 2296552 0 0.0
.bss 112208 112208 0 0.0
.data 2520 2520 0 0.0
.heap 918616 918616 0 0.0
.text 1254816 1254816 0 0.0
lock-app default (read/write) 2214024 2214024 0 0.0
.bss 100832 100832 0 0.0
.data 2400 2400 0 0.0
.heap 930112 930112 0 0.0
.text 1172288 1172288 0 0.0
qpg lighting-app qpg6100+debug (read only) 492800 492800 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50176 50176 0 0.0
.data 1008 1008 0 0.0
.text 487480 487480 0 0.0
lock-app qpg6100+debug (read only) 467780 467780 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49120 49120 0 0.0
.data 964 964 0 0.0
.text 462460 462460 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 766926 766926 0 0.0
bss 79008 79008 0 0.0
noinit 37160 37160 0 0.0
text 532224 532224 0 0.0

bzbarsky-apple
bzbarsky-apple previously requested changes Nov 18, 2021
View reviewed changes
src/platform/Darwin/DnssdImpl.cpp Outdated Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple linked an issue Nov 18, 2021 that may be closed by this pull request
Use after free in DnssdImpl.cpp darwin code. #11884
Closed
@andy31415 andy31415 dismissed bzbarsky-apple’s stale review November 18, 2021 11:58

Code review comment applied.

@github-actions
Copy link

github-actions bot commented Nov 18, 2021 •
edited
Loading

PR #11934: Size comparison from 02d8a1a to 911fb50

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 02d8a1a 911fb50 change % change
efr32 lighting-app BRD4161A (read only) 749456 749456 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749448 749448 0 0.0
BRD4161A+rpc (read only) 736988 736988 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 736980 736980 0 0.0
lock-app BRD4161A (read only) 726528 726528 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 726520 726520 0 0.0
window-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727496 727496 0 0.0
esp32 all-clusters-app c3devkit (read only) 828296 828296 0 0.0
(read/write) 1220130 1220130 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 828296 828296 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899319 899319 0 0.0
(read/write) 419452 419452 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893935 893935 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706636 706636 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621760 621760 0 0.0
lock-app k32w061+debug (read/write) 598076 598076 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522720 522720 0 0.0
shell k32w061+debug (read/write) 663420 663420 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 576968 576968 0 0.0
linux all-clusters-app debug (read only) 1724201 1724201 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136341 136341 0 0.0
.text 1453906 1453906 0 0.0
bridge-app debug+rpc (read only) 1319301 1319301 0 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111684 111684 0 0.0
.text 1110213 1110213 0 0.0
chip-tool debug (read only) 4980557 4980557 0 0.0
(read/write) 166920 166920 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268362 268362 0 0.0
.text 4401685 4401685 0 0.0
lighting-app debug+rpc (read only) 1588385 1588385 0 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129265 129265 0 0.0
.text 1324114 1324114 0 0.0
ota-provider-app debug (read only) 1267993 1267993 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113855 113855 0 0.0
.text 1056546 1056546 0 0.0
ota-requestor-app debug (read only) 1353665 1353665 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124872 124872 0 0.0
.text 1128818 1128818 0 0.0
shell debug (read only) 798209 798209 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 615490 615490 0 0.0
tv-app debug (read only) 1870881 1870881 0 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157669 157669 0 0.0
.text 1568082 1568082 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287384 2287384 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1249984 1249984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273320 2273320 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1235920 1235920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249160 2249160 0 0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1211760 1211760 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864295 864295 0 0.0
bss 110560 110560 0 0.0
rodata 95784 95784 0 0.0
text 582344 582344 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826695 826695 0 0.0
bss 106916 106916 0 0.0
rodata 86968 86968 0 0.0
text 556512 556512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789354 789354 0 0.0
bss 111936 111936 0 0.0
rodata 91044 91044 0 0.0
text 511816 511816 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839727 839727 0 0.0
bss 109584 109584 0 0.0
rodata 92256 92256 0 0.0
text 562436 562436 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765014 765014 0 0.0
bss 110996 110996 0 0.0
rodata 87560 87560 0 0.0
text 492000 492000 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845835 845835 0 0.0
bss 109724 109724 0 0.0
rodata 93964 93964 0 0.0
text 566620 566620 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839427 839427 0 0.0
bss 109620 109620 0 0.0
rodata 92212 92212 0 0.0
text 562056 562056 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2297480 2297480 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1255744 1255744 0 0.0
lock-app default (read/write) 2214968 2214968 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173232 1173232 0 0.0
qpg lighting-app qpg6100+debug (read only) 493472 493472 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488152 488152 0 0.0
lock-app qpg6100+debug (read only) 468452 468452 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463132 463132 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767742 767742 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 532972 532972 0 0.0

@andy31415
Copy link
Contributor Author

fast track: CI passes (finally) and was checked by platform owner.

@andy31415 andy31415 merged commit 4d341d4 into project-chip:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
darwin fast track platform review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use after free in DnssdImpl.cpp darwin code.
2 participants
@andy31415 @bzbarsky-apple