Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size reports: Fix parent SHA race #11841

Merged
merged 4 commits into from
Nov 16, 2021

Commits on Nov 16, 2021

  1. Size reports: Fix parent SHA race

    #### Problem
    
    For a GitHub PR, the actual parent may be different from the commit
    given by `github.event.pull_request.base.sha` (see
    actions/checkout#27). In this case, size
    reports incorrectly include changes from commit(s) between the purported
    and actual parent.
    
    #### Change overview
    
    Extract the actual parent from the PR merge commit subject.
    
    #### Testing
    
    Manually checked externally
        https://github.com/kpschoedel/actiontest/runs/4226639507
    Actual confirmation can only happen on live CI runs.
    kpschoedel committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c61e299 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7435659 View commit details
    Browse the repository at this point in the history
  3. Use test instead of [[

    kpschoedel committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3a5c80d View commit details
    Browse the repository at this point in the history
  4. POSIX test

    kpschoedel committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    d17272d View commit details
    Browse the repository at this point in the history