Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to find if an endpoint of given index contains the ZCL server. #11753

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add API to find if an endpoint of given index contains the ZCL server. #11753

merged 1 commit into from
Nov 15, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Currently, we only have the API to find if an endpoint contains the ZCL server from its endpointID.

Change overview

Add API to find if an endpoint of given index contains the ZCL server.

Testing

How was this tested? (at least one bullet point required)

  • currently, no unit test for util functions in app, test manually by repalcing the endpointID with endpointIndex

@boring-cyborg boring-cyborg bot added the app label Nov 12, 2021
@github-actions
Copy link

github-actions bot commented Nov 12, 2021 •
edited
Loading

PR #11753: Size comparison from ea10a5d to e4b469c

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ea10a5d e4b469c change % change
efr32 lighting-app BRD4161A (read only) 748808 748808 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 748800 748800 0 0.0
BRD4161A+rpc (read only) 736372 736372 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 736364 736364 0 0.0
lock-app BRD4161A (read only) 725648 725648 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 725640 725640 0 0.0
window-app BRD4161A (read only) 726560 726560 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 726552 726552 0 0.0
esp32 all-clusters-app c3devkit (read only) 825666 825666 0 0.0
(read/write) 1224066 1224066 0 0.0
.dram0.bss 57016 57016 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 167704 167704 0 0.0
.flash.text 825666 825666 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896459 896459 0 0.0
(read/write) 422224 422224 0 0.0
.dram0.bss 62112 62112 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 194732 194732 0 0.0
.flash.text 891075 891075 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701740 701740 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 616524 616524 0 0.0
lock-app k32w061+debug (read/write) 592956 592956 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517252 517252 0 0.0
shell k32w061+debug (read/write) 658640 658640 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572176 572176 0 0.0
linux all-clusters-app debug (read only) 1713393 1713393 0 0.0
(read/write) 126304 126304 0 0.0
.bss 57680 57680 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140117 140117 0 0.0
.text 1439250 1439250 0 0.0
bridge-app debug+rpc (read only) 1307461 1307461 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111764 111764 0 0.0
.text 1098725 1098725 0 0.0
chip-tool debug (read only) 4662317 4662317 0 0.0
(read/write) 163976 163976 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 115024 115024 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 259730 259730 0 0.0
.text 4100501 4100501 0 0.0
lighting-app debug+rpc (read only) 1574201 1574201 0 0.0
(read/write) 110192 110192 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129745 129745 0 0.0
.text 1309762 1309762 0 0.0
ota-provider-app debug (read only) 1262729 1262729 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113255 113255 0 0.0
.text 1052626 1052626 0 0.0
ota-requestor-app debug (read only) 1347545 1347545 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1124034 1124034 0 0.0
shell debug (read only) 788969 788969 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 609170 609170 0 0.0
tv-app debug (read only) 1853257 1853257 0 0.0
(read/write) 407896 407896 0 0.0
.bss 339752 339752 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156973 156973 0 0.0
.text 1551202 1551202 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291040 2291040 0 0.0
.bss 179612 179612 0 0.0
.data 5216 5216 0 0.0
.heap 851616 851616 0 0.0
.text 1253640 1253640 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273856 2273856 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1236456 1236456 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249552 2249552 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212152 1212152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864247 864247 0 0.0
bss 110964 110964 0 0.0
rodata 97080 97080 0 0.0
text 580580 580580 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826619 826619 0 0.0
bss 107316 107316 0 0.0
rodata 88268 88268 0 0.0
text 554752 554752 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789286 789286 0 0.0
bss 112336 112336 0 0.0
rodata 92336 92336 0 0.0
text 510048 510048 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839463 839463 0 0.0
bss 109988 109988 0 0.0
rodata 93144 93144 0 0.0
text 560880 560880 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764778 764778 0 0.0
bss 111400 111400 0 0.0
rodata 88452 88452 0 0.0
text 490440 490440 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845559 845559 0 0.0
bss 110128 110128 0 0.0
rodata 94856 94856 0 0.0
text 565044 565044 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839335 839335 0 0.0
bss 110024 110024 0 0.0
rodata 93144 93144 0 0.0
text 560616 560616 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775483 775483 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520008 520008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690538 690538 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440616 440616 0 0.0
p6 all-clusters-app default (read/write) 2299576 2299576 0 0.0
.bss 112608 112608 0 0.0
.data 2520 2520 0 0.0
.heap 918216 918216 0 0.0
.text 1257840 1257840 0 0.0
lock-app default (read/write) 2213616 2213616 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1171880 1171880 0 0.0
qpg lighting-app qpg6100+debug (read only) 493352 493352 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488032 488032 0 0.0
lock-app qpg6100+debug (read only) 468096 468096 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 462776 462776 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 666566 666566 0 0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 461088 461088 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but shouldn't we also use it in the place where we wanted to use it?

@yufengwangca
Copy link
Contributor Author

Looks good, but shouldn't we also use it in the place where we wanted to use it?

I will use it in my following PRs, in my previous PRs, EndpointID is still needed for other cases, so we still need to get the EndpointID anyway.

@woody-apple
Copy link
Contributor

@msandstedt ?

@yufengwangca yufengwangca merged commit eb40a4c into project-chip:master Nov 15, 2021
@yufengwangca yufengwangca deleted the pr/attribute/api branch November 15, 2021 20:10
@bzbarsky-apple
Copy link
Contributor

I will use it in my following PRs, in my previous PRs, EndpointID is still needed for other cases

That's not the problem; the problem is then using the endpointid to look up the cluster info, which does a linear scan to find the index.... @yufengwangca

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yufengwangca
Add API to find if an endpoint of given index contains the ZCL server. (
6d0b52d 
project-chip#11753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yufengwangca @woody-apple @bzbarsky-apple @andy31415 @saurabhst