Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap allocation to lib/support/Pool.h #11698

Merged
merged 6 commits into from
Nov 19, 2021
Merged

Add heap allocation to lib/support/Pool.h #11698

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be9c07f
Add heap allocation to lib/support/Pool.h
kpschoedel Nov 10, 2021
ca2f2ed
Revisions
kpschoedel Nov 12, 2021
0c9ab88
Merge remote-tracking branch 'origin/master' into x7715-pool-heap
kpschoedel Nov 16, 2021
9d158a2
do not free objects on pool destruction
kpschoedel Nov 16, 2021
b21add7
restyle
kpschoedel Nov 16, 2021
3758224
docs plus cleanup on outer iteration
kpschoedel Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restyle
  • Loading branch information
@kpschoedel
kpschoedel committed Nov 16, 2021
commit b21add7157996af46fd86f7d2686d84eadffd796
6 changes: 4 additions & 2 deletions src/lib/support/Pool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ class BitMapObjectPool : public internal::StaticAllocatorBitmap, public internal
{
public:
BitMapObjectPool() : StaticAllocatorBitmap(mData.mMemory, mUsage, N, sizeof(T)) {}
~BitMapObjectPool() {
~BitMapObjectPool()
{
// ReleaseAll();
}

Expand Down Expand Up @@ -241,7 +242,8 @@ class HeapObjectPool : public internal::Statistics, public internal::PoolCommon<
{
public:
HeapObjectPool() {}
~HeapObjectPool() {
~HeapObjectPool()
{
// TODO(#11880): Release all active objects (or verify that none are active) when destroying the pool.
// ReleaseAll();
}
Expand Down