Setting up PullApprove #1168
Merged
Setting up PullApprove #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk and
saurabhst
as code owners
saurabhst
approved these changes
Jun 18, 2020
|
Note: I've reached out to support. Something is clearly wrong here. The base examples seem to fail... |
andy31415
approved these changes
Jun 18, 2020
gerickson
approved these changes
Jun 18, 2020
anush-apple
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For a while we've been trying to have more granular review requirements (docs, bug fixes, and different reviewers). This is pulling in PullApprove, that will allow us both flexibility here, as well as documenting how the review process works.