Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Diagnostics]: Add event definitions for diagnostic clusters #11610

Merged
merged 2 commits into from
Nov 11, 2021
Merged

[Diagnostics]: Add event definitions for diagnostic clusters #11610

merged 2 commits into from
Nov 11, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Add event definitions for diagnostic clusters

Testing

How was this tested? (at least one bullet point required)

  • Only event type definition, no source code change

@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11610: Size comparison from be75489 to 465c0d5

Increases (2 builds for esp32, linux)
platform target config section be75489 465c0d5 change % change
esp32 all-clusters-app m5stack (read only) 910135 910227 92 0.0
.flash.text 910135 910227 92 0.0
linux chip-tool debug (read only) 4613893 4614053 160 0.0
.rodata 240496 240656 160 0.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section be75489 465c0d5 change % change
efr32 lighting-app BRD4161A (read only) 742140 742140 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742132 742132 0 0.0
BRD4161A+rpc (read only) 729664 729664 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 729656 729656 0 0.0
lock-app BRD4161A (read only) 721420 721420 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 721412 721412 0 0.0
window-app BRD4161A (read only) 722316 722316 0 0.0
(read/write) 114408 114408 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 722308 722308 0 0.0
esp32 all-clusters-app c3devkit (read only) 878758 878758 0 0.0
(read/write) 1305904 1305904 0 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197776 197776 0 0.0
.flash.text 878758 878758 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910135 910227 92 0.0
(read/write) 423228 423228 0 0.0
.dram0.bss 60928 60928 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204044 204044 0 0.0
.flash.text 910135 910227 92 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698920 698920 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613212 613212 0 0.0
lock-app k32w061+debug (read/write) 591632 591632 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 515428 515428 0 0.0
shell k32w061+debug (read/write) 657288 657288 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 570316 570316 0 0.0
linux all-clusters-app debug (read only) 1696881 1696881 0 0.0
(read/write) 126144 126144 0 0.0
.bss 57776 57776 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62096 62096 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138837 138837 0 0.0
.text 1425106 1425106 0 0.0
bridge-app debug+rpc (read only) 1296349 1296349 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110676 110676 0 0.0
.text 1089781 1089781 0 0.0
chip-tool debug (read only) 4613893 4614053 160 0.0
(read/write) 134760 134760 0 0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 101232 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240496 240656 160 0.1
.text 4102149 4102149 0 0.0
lighting-app debug+rpc (read only) 1556041 1556041 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1294370 1294370 0 0.0
ota-provider-app debug (read only) 1257817 1257817 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112352 112352 0 0.0
.text 1049218 1049218 0 0.0
ota-requestor-app debug (read only) 1342377 1342377 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123368 123368 0 0.0
.text 1120210 1120210 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1840633 1840633 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59432 59432 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155592 155592 0 0.0
.text 1541122 1541122 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288808 2288808 0 0.0
.bss 179396 179396 0 0.0
.data 5216 5216 0 0.0
.heap 851832 851832 0 0.0
.text 1251408 1251408 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270240 2270240 0 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1232840 1232840 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2247896 2247896 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1210496 1210496 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048152 0 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010752 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861431 861431 0 0.0
bss 111460 111460 0 0.0
rodata 96472 96472 0 0.0
text 577860 577860 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823775 823775 0 0.0
bss 107812 107812 0 0.0
rodata 87648 87648 0 0.0
text 552008 552008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786454 786454 0 0.0
bss 112832 112832 0 0.0
rodata 91728 91728 0 0.0
text 507332 507332 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838123 838123 0 0.0
bss 110492 110492 0 0.0
rodata 92844 92844 0 0.0
text 559344 559344 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763418 763418 0 0.0
bss 111904 111904 0 0.0
rodata 88148 88148 0 0.0
text 488908 488908 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844231 844231 0 0.0
bss 110632 110632 0 0.0
rodata 94552 94552 0 0.0
text 563504 563504 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110528 110528 0 0.0
rodata 92840 92840 0 0.0
text 559080 559080 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775703 775703 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519736 519736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690758 690758 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440344 440344 0 0.0
p6 all-clusters-app default (read/write) 2296800 2296800 0 0.0
.bss 112408 112408 0 0.0
.data 2520 2520 0 0.0
.heap 918416 918416 0 0.0
.text 1255064 1255064 0 0.0
lock-app default (read/write) 2211416 2211416 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1169680 1169680 0 0.0
qpg lighting-app qpg6100+debug (read only) 490220 490220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 484900 484900 0 0.0
lock-app qpg6100+debug (read only) 466432 466432 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461112 461112 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662998 662998 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458304 458304 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Nov 10, 2021
View reviewed changes
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/software-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/thread-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
src/app/zap-templates/zcl/data-model/chip/wifi-network-diagnostics-cluster.xml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11610: Size comparison from 0528ce0 to e55b8b0

Increases (1 build for linux)
platform target config section 0528ce0 e55b8b0 change % change
linux chip-tool debug (read only) 4667837 4667933 96 0.0
.rodata 248074 248170 96 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0528ce0 e55b8b0 change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730040 730040 0 0.0
(read/write) 132900 132900 0 0.0
.bss 131004 131004 0 0.0
.data 1896 1896 0 0.0
.text 730032 730032 0 0.0
lock-app BRD4161A (read only) 721764 721764 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721756 721756 0 0.0
window-app BRD4161A (read only) 722676 722676 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722668 722668 0 0.0
esp32 all-clusters-app c3devkit (read only) 879114 879114 0 0.0
(read/write) 1305968 1305968 0 0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197824 197824 0 0.0
.flash.text 879114 879114 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910619 910619 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 204100 0 0.0
.flash.text 910619 910619 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699396 699396 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613676 613676 0 0.0
lock-app k32w061+debug (read/write) 592132 592132 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515908 515908 0 0.0
shell k32w061+debug (read/write) 657760 657760 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570776 570776 0 0.0
linux all-clusters-app debug (read only) 1698921 1698921 0 0.0
(read/write) 126432 126432 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62256 62256 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426370 1426370 0 0.0
bridge-app debug+rpc (read only) 1298741 1298741 0 0.0
(read/write) 77264 77264 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27928 27928 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091365 1091365 0 0.0
chip-tool debug (read only) 4667837 4667933 96 0.0
(read/write) 135264 135264 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101608 101608 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 248074 248170 96 0.0
.text 4147461 4147461 0 0.0
lighting-app debug+rpc (read only) 1558113 1558113 0 0.0
(read/write) 110376 110376 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55328 55328 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128369 0 0.0
.text 1295634 1295634 0 0.0
ota-provider-app debug (read only) 1259977 1259977 0 0.0
(read/write) 75624 75624 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050562 1050562 0 0.0
ota-requestor-app debug (read only) 1345049 1345049 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123728 123728 0 0.0
.text 1121970 1121970 0 0.0
shell debug (read only) 788441 788441 0 0.0
(read/write) 65608 65608 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609026 609026 0 0.0
tv-app debug (read only) 1842905 1842905 0 0.0
(read/write) 408216 408216 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542674 1542674 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289248 2289248 0 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251848 1251848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270688 0 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248344 2248344 0 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1210944 1210944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048296 2048296 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010896 1010896 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861907 861907 0 0.0
bss 111476 111476 0 0.0
rodata 96532 96532 0 0.0
text 578272 578272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824267 824267 0 0.0
bss 107828 107828 0 0.0
rodata 87708 87708 0 0.0
text 552444 552444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786946 786946 0 0.0
bss 112848 112848 0 0.0
rodata 91788 91788 0 0.0
text 507740 507740 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838615 838615 0 0.0
bss 110508 110508 0 0.0
rodata 92904 92904 0 0.0
text 559756 559756 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763926 763926 0 0.0
bss 111920 111920 0 0.0
rodata 88208 88208 0 0.0
text 489316 489316 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844707 844707 0 0.0
bss 110648 110648 0 0.0
rodata 94612 94612 0 0.0
text 563916 563916 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838467 838467 0 0.0
bss 110544 110544 0 0.0
rodata 92900 92900 0 0.0
text 559492 559492 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775955 775955 0 0.0
bss 109288 109288 0 0.0
rodata 72152 72152 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110272 110272 0 0.0
rodata 66796 66796 0 0.0
text 440512 440512 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211760 2211760 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170024 1170024 0 0.0
qpg lighting-app qpg6100+debug (read only) 490672 490672 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485352 485352 0 0.0
lock-app qpg6100+debug (read only) 466900 466900 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461580 461580 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663418 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458654 458654 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yufengwangca yufengwangca merged commit 3da4fe6 into project-chip:master Nov 11, 2021
@yufengwangca yufengwangca deleted the pr/software/event branch November 11, 2021 22:12
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yufengwangca
[Diagnostics]: Add event definitions for diagnostic clusters (project…
0b4b98a 
…-chip#11610)

* Add event definitions for diagnostic clusters

* Run codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add events to application clusters XML files
5 participants
@yufengwangca @saurabhst @emargolis @woody-apple @bzbarsky-apple