Remove unused Microseconds from System::Clock #11450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
mspang and
pan-apple
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
|
PR #11450: Size comparison from 29747a2 to 52b4426 Decreases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 4, 2021
|
/rebase |
#### Problem `System::Clock` has microsecond-resolution code, but nothing actually uses it. #### Change overview Remove it. #### Testing CI; no change to functionality. Microsecond unit tests removed.
woody-apple
force-pushed
the
x10062-clock-type-8-microseconds
branch
from
52b4426
to
1851d62
Compare
|
PR #11450: Size comparison from f36b141 to 1851d62 Increases (1 build for esp32)
Decreases (27 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 4, 2021
msandstedt
approved these changes
Nov 5, 2021
andy31415
approved these changes
Nov 5, 2021
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Nov 5, 2021
This reverts commit 11c32e8.
andy31415
added a commit
that referenced
this pull request
Nov 5, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
#### Problem `System::Clock` has microsecond-resolution code, but nothing actually uses it. #### Change overview Remove it. #### Testing CI; no change to functionality. Microsecond unit tests removed.
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
System::Clockhas microsecond-resolution code, but nothing actuallyuses it.
Change overview
Remove it.
Testing
CI; no change to functionality.
Microsecond unit tests removed.