Remove atomic

src/inet/TCPEndPoint.cpp

@@ -2748,13 +2748,6 @@ CHIP_ERROR TCPEndPoint::DoClose(CHIP_ERROR err, bool suppressCallback)
         }
 
         // Decrement the ref count that was added when the connection started (in Connect()) or listening started (in Listen()).
-        //
-        // When using LwIP, post a callback to Release() rather than calling it directly. Since up-calls
-        // from LwIP are delivered as events (via the LwIP* methods), we must ensure that all events have been
-        // cleared from the queue before the end point gets freed, otherwise we'll end up accessing freed memory.
-        // We achieve this by first preventing further up-calls from LwIP (via the call to tcp_abort() above)
-        // and then queuing the Release() call to happen after all existing events have been processed.
-        //
         if (oldState != State::kReady && oldState != State::kBound)
         {
             Release();

src/inet/TCPEndPoint.h

@@ -67,7 +67,7 @@ class TCPEndPointDeletor
  *  endpoints (SOCK_STREAM sockets on Linux and BSD-derived systems) or LwIP
  *  TCP protocol control blocks, as the system is configured accordingly.
  */
-class DLL_EXPORT TCPEndPoint : public EndPointBasis, public AtomicReferenceCounted<TCPEndPoint, TCPEndPointDeletor>
+class DLL_EXPORT TCPEndPoint : public EndPointBasis, public ReferenceCounted<TCPEndPoint, TCPEndPointDeletor>
 {
     friend class InetLayer;
     friend class ::chip::Transport::TCPTest;

src/inet/UDPEndPoint.h

@@ -60,7 +60,7 @@ class UDPEndPointDeletor
  *  endpoints (SOCK_DGRAM sockets on Linux and BSD-derived systems) or LwIP
  *  UDP protocol control blocks, as the system is configured accordingly.
  */
-class DLL_EXPORT UDPEndPoint : public EndPointBasis, public AtomicReferenceCounted<UDPEndPoint, UDPEndPointDeletor>
+class DLL_EXPORT UDPEndPoint : public EndPointBasis, public ReferenceCounted<UDPEndPoint, UDPEndPointDeletor>
 {
 public:
     UDPEndPoint() = default;

src/lib/core/ReferenceCounted.h

@@ -81,46 +81,4 @@ class ReferenceCounted
     count_type mRefCount = kInitRefCount;
 };
 
-/// An variant of ReferenceCounted, with atomic counter.
-template <class Subclass, class Deletor = DeleteDeletor<Subclass>, int kInitRefCount = 1>
-class AtomicReferenceCounted
-{
-public:
-    using count_type = uint32_t;
-
-    AtomicReferenceCounted() : mRefCount(kInitRefCount) {}
-
-    /** Adds one to the usage count of this class */
-    Subclass * Retain()
-    {
-        if (mRefCount == std::numeric_limits<count_type>::max())
-        {
-            abort();
-        }
-        ++mRefCount;
-
-        return static_cast<Subclass *>(this);
-    }
-
-    /** Release usage of this class */
-    void Release()
-    {
-        if (mRefCount == 0)
-        {
-            abort();
-        }
-
-        if (--mRefCount == 0)
-        {
-            Deletor::Release(static_cast<Subclass *>(this));
-        }
-    }
-
-    /** Get the current reference counter value */
-    count_type GetReferenceCount() const { return mRefCount.load(); }
-
-private:
-    std::atomic<count_type> mRefCount;
-};
-
 } // namespace chip