Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename System::Clock::Zero to System::Clock::kZero #11327

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Rename System::Clock::Zero to System::Clock::kZero #11327

merged 1 commit into from
Nov 2, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

System::Clock::Zero is a constants that doesn't follow the usual
convention of being named with a leading k.

Requested in PR #11238 review.

Change overview

Rename System::Clock::Zero to System::Clock::kZero.

Testing

CI; no changes to functionality.

@kpschoedel
Rename System::Clock::Zero to System::Clock::kZero
76e70a8 
#### Problem

`System::Clock::Zero` is a constants that doesn't follow the usual
convention of being named with a leading `k`.

Requested in PR project-chip#11238 review.

#### Change overview

Rename `System::Clock::Zero` to `System::Clock::kZero`.

#### Testing

CI; no changes to functionality.
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11327: Size comparison from 8ae5b65 to 76e70a8

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8ae5b65 76e70a8 change % change
efr32 lighting-app BRD4161A (read only) 736548 736548 0 0.0
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736540 736540 0 0.0
BRD4161A+rpc (read only) 723988 723988 0 0.0
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 723980 723980 0 0.0
lock-app BRD4161A (read only) 715828 715828 0 0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 715820 715820 0 0.0
window-app BRD4161A (read only) 716728 716728 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 716720 716720 0 0.0
esp32 all-clusters-app c3devkit (read only) 880486 880486 0 0.0
(read/write) 1307776 1307776 0 0.0
.dram0.bss 58592 58592 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199488 199488 0 0.0
.flash.text 880486 880486 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911507 911507 0 0.0
(read/write) 427544 427544 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208192 208192 0 0.0
.flash.text 911507 911507 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699048 699048 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613492 613492 0 0.0
lock-app k32w061+debug (read/write) 591356 591356 0 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515320 515320 0 0.0
shell k32w061+debug (read/write) 424748 424748 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359084 359084 0 0.0
linux all-clusters-app debug (read only) 1689169 1689169 0 0.0
(read/write) 119664 119664 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139285 139285 0 0.0
.text 1416514 1416514 0 0.0
bridge-app debug+rpc (read only) 1282077 1282077 0 0.0
(read/write) 68488 68488 0 0.0
.bss 35024 35024 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110852 110852 0 0.0
.text 1075669 1075669 0 0.0
chip-tool debug (read only) 4324637 4324637 0 0.0
(read/write) 123936 123936 0 0.0
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98744 98744 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218512 218512 0 0.0
.text 3840709 3840709 0 0.0
lighting-app debug+rpc (read only) 1541433 1541433 0 0.0
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1279762 1279762 0 0.0
ota-provider-app debug (read only) 1241929 1241929 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111784 111784 0 0.0
.text 1034066 1034066 0 0.0
ota-requestor-app debug (read only) 1309225 1309225 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 122752 122752 0 0.0
.text 1088754 1088754 0 0.0
shell debug (read only) 785809 785809 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77551 77551 0 0.0
.text 606770 606770 0 0.0
tv-app debug (read only) 1789321 1789321 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154584 154584 0 0.0
.text 1492546 1492546 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292664 0 0.0
.bss 179956 179956 0 0.0
.data 5224 5224 0 0.0
.heap 851264 851264 0 0.0
.text 1255264 1255264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271608 2271608 0 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234208 1234208 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249328 2249328 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211928 1211928 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048392 2048392 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1010992 1010992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860983 860983 0 0.0
bss 111312 111312 0 0.0
rodata 96536 96536 0 0.0
text 577512 577512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 821807 821807 0 0.0
bss 107552 107552 0 0.0
rodata 87312 87312 0 0.0
text 550688 550688 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786010 786010 0 0.0
bss 112688 112688 0 0.0
rodata 91780 91780 0 0.0
text 506980 506980 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837675 837675 0 0.0
bss 110348 110348 0 0.0
rodata 92892 92892 0 0.0
text 558992 558992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762986 762986 0 0.0
bss 111756 111756 0 0.0
rodata 88196 88196 0 0.0
text 488552 488552 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843783 843783 0 0.0
bss 110484 110484 0 0.0
rodata 94600 94600 0 0.0
text 563172 563172 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837547 837547 0 0.0
bss 110384 110384 0 0.0
rodata 92892 92892 0 0.0
text 558728 558728 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775867 775867 0 0.0
bss 109104 109104 0 0.0
rodata 72400 72400 0 0.0
text 519772 519772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690922 690922 0 0.0
bss 110084 110084 0 0.0
rodata 67044 67044 0 0.0
text 440372 440372 0 0.0
p6 lock-app default (read/write) 2167688 2167688 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125952 1125952 0 0.0
qpg lighting-app qpg6100+debug (read only) 490328 490328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485008 485008 0 0.0
lock-app qpg6100+debug (read only) 466668 466668 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461348 461348 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662382 0 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457774 457774 0 0.0

@andy31415
Copy link
Contributor

fast track: trivial change (rename for refactor)

@andy31415 andy31415 merged commit eddd4f7 into project-chip:master Nov 2, 2021
@kpschoedel kpschoedel deleted the x10062-clock-type-6-zero branch November 4, 2021 14:48
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kpschoedel
Rename System::Clock::Zero to System::Clock::kZero (project-chip#11327)
711d85b 
#### Problem

`System::Clock::Zero` is a constants that doesn't follow the usual
convention of being named with a leading `k`.

Requested in PR project-chip#11238 review.

#### Change overview

Rename `System::Clock::Zero` to `System::Clock::kZero`.

#### Testing

CI; no changes to functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app esp32 examples fast track lib linux platform review - pending system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @andy31415 @woody-apple