-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InetLayer/SystemLayer use C++11 singleton patter instead of global variable #11184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
October 29, 2021 09:55
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 29, 2021 09:55
PR #11184: Size comparison from 1e27d92 to 3909c3d Increases (32 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (14 builds for efr32, k32w, mbed, p6, qpg)
Full report (35 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11184: Size comparison from 1e27d92 to d8ad5c1 Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (15 builds for efr32, esp32, k32w, mbed, p6, qpg)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
kpschoedel
requested changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to retain a straightforward way to mock System::Layer
.
kpschoedel
approved these changes
Nov 1, 2021
PR #11184: Size comparison from 3947eba to 72f9faa Increases (5 builds for k32w, p6, telink)
Decreases (4 builds for k32w, p6)
Full report (5 builds for k32w, p6, telink)
|
PR #11184: Size comparison from 3947eba to 24c0f2b Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (15 builds for efr32, esp32, k32w, mbed, p6, qpg)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 1, 2021
emargolis
approved these changes
Nov 1, 2021
mspang
reviewed
Nov 2, 2021
woody-apple
approved these changes
Nov 2, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…riable (project-chip#11184) * InetLayer/SystemLayer use C++11 singleton patter instead of global variable * Add mock for SystemLayer * Remove NDEBUG guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The constructor order of global variables are not controllable
Change overview
use C++11 singleton patter for InetLayer/SystemLayer
Testing
Verified by unit-tests