Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InetLayer/SystemLayer use C++11 singleton patter instead of global variable #11184

Merged
merged 3 commits into from
Nov 2, 2021
Merged

InetLayer/SystemLayer use C++11 singleton patter instead of global variable #11184

merged 3 commits into from
Nov 2, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Oct 29, 2021 •
edited
Loading

Problem

The constructor order of global variables are not controllable

Change overview

use C++11 singleton patter for InetLayer/SystemLayer

Testing

Verified by unit-tests

@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11184: Size comparison from 1e27d92 to 3909c3d

Increases (32 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 3909c3d change % change
efr32 lighting-app BRD4161A (read only) 738120 738152 32 0.0
(read/write) 115428 115436 8 0.0
.bss 113676 113684 8 0.0
.text 738112 738144 32 0.0
BRD4161A+rpc (read only) 725560 725592 32 0.0
.bss 130180 130188 8 0.0
.text 725552 725584 32 0.0
lock-app BRD4161A (read only) 717400 717448 48 0.0
(read/write) 113244 113252 8 0.0
.bss 111532 111540 8 0.0
.text 717392 717440 48 0.0
window-app BRD4161A (read only) 718304 718336 32 0.0
.bss 111852 111860 8 0.0
.text 718296 718328 32 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701716 60 0.0
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593664 52 0.0
.bss 69172 69180 8 0.0
.text 516776 516824 48 0.0
shell k32w061+debug (read/write) 425252 425336 84 0.0
.bss 63256 63264 8 0.0
.text 359620 359700 80 0.0
linux all-clusters-app debug (read only) 1655073 1655153 80 0.0
(read/write) 119104 119136 32 0.0
.bss 51376 51408 32 0.1
.text 1384738 1384818 80 0.0
bridge-app debug+rpc (read only) 1283341 1283421 80 0.0
(read/write) 85160 85192 32 0.0
.bss 51856 51888 32 0.1
.text 1076981 1077061 80 0.0
chip-tool debug (read only) 4266229 4266293 64 0.0
(read/write) 122176 122208 32 0.0
.bss 17680 17712 32 0.2
.text 3788725 3788789 64 0.0
lighting-app debug+rpc (read only) 1542281 1542361 80 0.0
(read/write) 102000 102032 32 0.0
.bss 41208 41240 32 0.1
.text 1280658 1280738 80 0.0
ota-provider-app debug (read only) 1239849 1239929 80 0.0
(read/write) 67872 67904 32 0.0
.bss 37440 37472 32 0.1
.text 1032466 1032546 80 0.0
ota-requestor-app debug (read only) 1301465 1301545 80 0.0
(read/write) 76616 76648 32 0.0
.bss 45216 45248 32 0.1
.text 1076226 1076306 80 0.0
shell debug (read only) 787153 787217 64 0.0
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1775041 112 0.0
(read/write) 289624 289656 32 0.0
.bss 223280 223312 32 0.0
.text 1478178 1478290 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291400 2291464 64 0.0
.heap 850632 850640 8 0.0
.text 1254000 1254064 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275608 2275736 128 0.0
.heap 858056 858064 8 0.0
.text 1238208 1238336 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2253328 2253392 64 0.0
.text 1215928 1215992 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048976 2049040 64 0.0
.heap 875272 875280 8 0.0
.text 1011576 1011640 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 863583 48 0.0
bss 112132 112136 4 0.0
text 577960 578016 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 824363 824411 48 0.0
bss 108372 108376 4 0.0
text 551136 551192 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788526 788622 96 0.0
bss 113504 113508 4 0.0
text 507428 507484 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840211 840291 80 0.0
bss 111168 111172 4 0.0
text 559444 559496 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765506 765586 80 0.0
bss 112576 112580 4 0.0
text 489004 489056 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 844959 48 0.0
bss 111304 111308 4 0.0
text 562656 562708 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840279 80 0.0
bss 111200 111204 4 0.0
text 559288 559340 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776499 64 0.0
bss 109072 109076 4 0.0
text 520236 520296 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691538 48 0.0
bss 110056 110060 4 0.0
text 440848 440896 48 0.0
p6 lock-app default (read/write) 2169744 2169792 48 0.0
.bss 67168 67176 8 0.0
.text 1128008 1128056 48 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491272 48 0.0
.text 485904 485952 48 0.0
lock-app qpg6100+debug (read only) 467556 467604 48 0.0
(read/write) 114140 114144 4 0.0
.text 462236 462284 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665298 96 0.0
bss 69944 69952 8 0.0
text 458454 458550 96 0.0
Decreases (14 builds for efr32, k32w, mbed, p6, qpg)
platform target config section 1e27d92 3909c3d change % change
efr32 lighting-app BRD4161A .data 1752 1748 -4 -0.2
BRD4161A+rpc .data 1852 1848 -4 -0.2
lock-app BRD4161A .data 1712 1708 -4 -0.2
window-app BRD4161A .data 1716 1712 -4 -0.2
k32w lighting-app k32w061+se05x+release .data 1900 1896 -4 -0.2
lock-app k32w061+debug .data 1864 1860 -4 -0.2
shell k32w061+debug .data 672 668 -4 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5192 5184 -8 -0.2
lighting-app CY8CPROTO_062_4343W+release .data 5568 5560 -8 -0.1
shell CY8CPROTO_062_4343W+release .data 4968 4960 -8 -0.2
p6 lock-app default .data 2416 2408 -8 -0.3
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
.data 1000 996 -4 -0.4
lock-app qpg6100+debug .data 956 952 -4 -0.4
persistent-storage-app qpg6100+debug (read only) 155236 152620 -2616 -1.7
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 149916 147300 -2616 -1.7
Full report (35 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 3909c3d change % change
efr32 lighting-app BRD4161A (read only) 738120 738152 32 0.0
(read/write) 115428 115436 8 0.0
.bss 113676 113684 8 0.0
.data 1752 1748 -4 -0.2
.text 738112 738144 32 0.0
BRD4161A+rpc (read only) 725560 725592 32 0.0
(read/write) 132036 132036 0 0.0
.bss 130180 130188 8 0.0
.data 1852 1848 -4 -0.2
.text 725552 725584 32 0.0
lock-app BRD4161A (read only) 717400 717448 48 0.0
(read/write) 113244 113252 8 0.0
.bss 111532 111540 8 0.0
.data 1712 1708 -4 -0.2
.text 717392 717440 48 0.0
window-app BRD4161A (read only) 718304 718336 32 0.0
(read/write) 113572 113572 0 0.0
.bss 111852 111860 8 0.0
.data 1716 1712 -4 -0.2
.text 718296 718328 32 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701716 60 0.0
.bss 78688 78688 0 0.0
.data 1900 1896 -4 -0.2
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593664 52 0.0
.bss 69172 69180 8 0.0
.data 1864 1860 -4 -0.2
.text 516776 516824 48 0.0
shell k32w061+debug (read/write) 425252 425336 84 0.0
.bss 63256 63264 8 0.0
.data 672 668 -4 -0.6
.text 359620 359700 80 0.0
linux all-clusters-app debug (read only) 1655073 1655153 80 0.0
(read/write) 119104 119136 32 0.0
.bss 51376 51408 32 0.1
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138069 0 0.0
.text 1384738 1384818 80 0.0
bridge-app debug+rpc (read only) 1283341 1283421 80 0.0
(read/write) 85160 85192 32 0.0
.bss 51856 51888 32 0.1
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111044 0 0.0
.text 1076981 1077061 80 0.0
chip-tool debug (read only) 4266229 4266293 64 0.0
(read/write) 122176 122208 32 0.0
.bss 17680 17712 32 0.2
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 214704 0 0.0
.text 3788725 3788789 64 0.0
lighting-app debug+rpc (read only) 1542281 1542361 80 0.0
(read/write) 102000 102032 32 0.0
.bss 41208 41240 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129169 0 0.0
.text 1280658 1280738 80 0.0
ota-provider-app debug (read only) 1239849 1239929 80 0.0
(read/write) 67872 67904 32 0.0
.bss 37440 37472 32 0.1
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111208 0 0.0
.text 1032466 1032546 80 0.0
ota-requestor-app debug (read only) 1301465 1301545 80 0.0
(read/write) 76616 76648 32 0.0
.bss 45216 45248 32 0.1
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 127424 0 0.0
.text 1076226 1076306 80 0.0
shell debug (read only) 787153 787217 64 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1775041 112 0.0
(read/write) 289624 289656 32 0.0
.bss 223280 223312 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 154488 0 0.0
.text 1478178 1478290 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291400 2291464 64 0.0
.bss 180620 180620 0 0.0
.data 5192 5184 -8 -0.2
.heap 850632 850640 8 0.0
.text 1254000 1254064 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275608 2275736 128 0.0
.bss 172820 172820 0 0.0
.data 5568 5560 -8 -0.1
.heap 858056 858064 8 0.0
.text 1238208 1238336 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253328 2253392 64 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215928 1215992 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2049040 64 0.0
.bss 156208 156208 0 0.0
.data 4968 4960 -8 -0.2
.heap 875272 875280 8 0.0
.text 1011576 1011640 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 863583 48 0.0
bss 112132 112136 4 0.0
rodata 97816 97816 0 0.0
text 577960 578016 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 824363 824411 48 0.0
bss 108372 108376 4 0.0
rodata 88596 88596 0 0.0
text 551136 551192 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788526 788622 96 0.0
bss 113504 113508 4 0.0
rodata 93056 93056 0 0.0
text 507428 507484 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840211 840291 80 0.0
bss 111168 111172 4 0.0
rodata 94172 94172 0 0.0
text 559444 559496 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765506 765586 80 0.0
bss 112576 112580 4 0.0
rodata 89476 89476 0 0.0
text 489004 489056 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 844959 48 0.0
bss 111304 111308 4 0.0
rodata 95416 95416 0 0.0
text 562656 562708 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840279 80 0.0
bss 111200 111204 4 0.0
rodata 94192 94192 0 0.0
text 559288 559340 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776499 64 0.0
bss 109072 109076 4 0.0
rodata 72536 72536 0 0.0
text 520236 520296 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691538 48 0.0
bss 110056 110060 4 0.0
rodata 67180 67180 0 0.0
text 440848 440896 48 0.0
p6 lock-app default (read/write) 2169744 2169792 48 0.0
.bss 67168 67176 8 0.0
.data 2416 2408 -8 -0.3
.heap 963760 963760 0 0.0
.text 1128008 1128056 48 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491272 48 0.0
(read/write) 114144 114140 -4 -0.0
.bss 51288 51288 0 0.0
.data 1000 996 -4 -0.4
.text 485904 485952 48 0.0
lock-app qpg6100+debug (read only) 467556 467604 48 0.0
(read/write) 114140 114144 4 0.0
.bss 50240 50240 0 0.0
.data 956 952 -4 -0.4
.text 462236 462284 48 0.0
persistent-storage-app qpg6100+debug (read only) 155236 152620 -2616 -1.7
(read/write) 114140 114140 0 0.0
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 149916 147300 -2616 -1.7
telink lighting-app tlsr9518adk80d (read/write) 665202 665298 96 0.0
bss 69944 69952 8 0.0
noinit 33216 33216 0 0.0
text 458454 458550 96 0.0

@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11184: Size comparison from 1e27d92 to d8ad5c1

Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 d8ad5c1 change % change
efr32 lighting-app BRD4161A (read only) 738120 738152 32 0.0
(read/write) 115428 115436 8 0.0
.bss 113676 113684 8 0.0
.text 738112 738144 32 0.0
BRD4161A+rpc (read only) 725560 725592 32 0.0
.bss 130180 130188 8 0.0
.text 725552 725584 32 0.0
lock-app BRD4161A (read only) 717400 717448 48 0.0
(read/write) 113244 113252 8 0.0
.bss 111532 111540 8 0.0
.text 717392 717440 48 0.0
window-app BRD4161A (read only) 718304 718336 32 0.0
.bss 111852 111860 8 0.0
.text 718296 718328 32 0.0
esp32 all-clusters-app c3devkit (read only) 876382 876474 92 0.0
(read/write) 1308944 1308960 16 0.0
.dram0.bss 59248 59264 16 0.0
.flash.text 876382 876474 92 0.0
m5stack (read only) 907747 907779 32 0.0
(read/write) 428724 428736 12 0.0
.dram0.bss 61744 61760 16 0.0
.flash.text 907747 907779 32 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701716 60 0.0
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593664 52 0.0
.bss 69172 69180 8 0.0
.text 516776 516824 48 0.0
shell k32w061+debug (read/write) 425252 425336 84 0.0
.bss 63256 63264 8 0.0
.text 359620 359700 80 0.0
linux all-clusters-app debug (read only) 1655073 1655153 80 0.0
(read/write) 119104 119136 32 0.0
.bss 51376 51408 32 0.1
.text 1384738 1384818 80 0.0
bridge-app debug+rpc (read only) 1283341 1283421 80 0.0
(read/write) 85160 85192 32 0.0
.bss 51856 51888 32 0.1
.text 1076981 1077061 80 0.0
chip-tool debug (read only) 4266229 4266293 64 0.0
(read/write) 122176 122208 32 0.0
.bss 17680 17712 32 0.2
.text 3788725 3788789 64 0.0
lighting-app debug+rpc (read only) 1542281 1542361 80 0.0
(read/write) 102000 102032 32 0.0
.bss 41208 41240 32 0.1
.text 1280658 1280738 80 0.0
ota-provider-app debug (read only) 1239849 1239929 80 0.0
(read/write) 67872 67904 32 0.0
.bss 37440 37472 32 0.1
.text 1032466 1032546 80 0.0
ota-requestor-app debug (read only) 1301465 1301545 80 0.0
(read/write) 76616 76648 32 0.0
.bss 45216 45248 32 0.1
.text 1076226 1076306 80 0.0
shell debug (read only) 787153 787217 64 0.0
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1775041 112 0.0
(read/write) 289624 289656 32 0.0
.bss 223280 223312 32 0.0
.text 1478178 1478290 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291400 2291464 64 0.0
.heap 850632 850640 8 0.0
.text 1254000 1254064 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275608 2275736 128 0.0
.heap 858056 858064 8 0.0
.text 1238208 1238336 128 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2253328 2253392 64 0.0
.text 1215928 1215992 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048976 2049040 64 0.0
.heap 875272 875280 8 0.0
.text 1011576 1011640 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 863583 48 0.0
bss 112132 112136 4 0.0
text 577960 578016 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 824363 824411 48 0.0
bss 108372 108376 4 0.0
text 551136 551192 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788526 788622 96 0.0
bss 113504 113508 4 0.0
text 507428 507484 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840211 840291 80 0.0
bss 111168 111172 4 0.0
text 559444 559496 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765506 765586 80 0.0
bss 112576 112580 4 0.0
text 489004 489056 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 844959 48 0.0
bss 111304 111308 4 0.0
text 562656 562708 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840279 80 0.0
bss 111200 111204 4 0.0
text 559288 559340 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776499 64 0.0
bss 109072 109076 4 0.0
text 520236 520296 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691538 48 0.0
bss 110056 110060 4 0.0
text 440848 440896 48 0.0
p6 lock-app default (read/write) 2169744 2169792 48 0.0
.bss 67168 67176 8 0.0
.text 1128008 1128056 48 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491272 48 0.0
.text 485904 485952 48 0.0
lock-app qpg6100+debug (read only) 467556 467604 48 0.0
(read/write) 114140 114144 4 0.0
.text 462236 462284 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665298 96 0.0
bss 69944 69952 8 0.0
text 458454 458550 96 0.0
Decreases (15 builds for efr32, esp32, k32w, mbed, p6, qpg)
platform target config section 1e27d92 d8ad5c1 change % change
efr32 lighting-app BRD4161A .data 1752 1748 -4 -0.2
BRD4161A+rpc .data 1852 1848 -4 -0.2
lock-app BRD4161A .data 1712 1708 -4 -0.2
window-app BRD4161A .data 1716 1712 -4 -0.2
esp32 all-clusters-app m5stack .flash.rodata 208732 208728 -4 -0.0
k32w lighting-app k32w061+se05x+release .data 1900 1896 -4 -0.2
lock-app k32w061+debug .data 1864 1860 -4 -0.2
shell k32w061+debug .data 672 668 -4 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5192 5184 -8 -0.2
lighting-app CY8CPROTO_062_4343W+release .data 5568 5560 -8 -0.1
shell CY8CPROTO_062_4343W+release .data 4968 4960 -8 -0.2
p6 lock-app default .data 2416 2408 -8 -0.3
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
.data 1000 996 -4 -0.4
lock-app qpg6100+debug .data 956 952 -4 -0.4
persistent-storage-app qpg6100+debug (read only) 155236 152620 -2616 -1.7
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 149916 147300 -2616 -1.7
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1e27d92 d8ad5c1 change % change
efr32 lighting-app BRD4161A (read only) 738120 738152 32 0.0
(read/write) 115428 115436 8 0.0
.bss 113676 113684 8 0.0
.data 1752 1748 -4 -0.2
.text 738112 738144 32 0.0
BRD4161A+rpc (read only) 725560 725592 32 0.0
(read/write) 132036 132036 0 0.0
.bss 130180 130188 8 0.0
.data 1852 1848 -4 -0.2
.text 725552 725584 32 0.0
lock-app BRD4161A (read only) 717400 717448 48 0.0
(read/write) 113244 113252 8 0.0
.bss 111532 111540 8 0.0
.data 1712 1708 -4 -0.2
.text 717392 717440 48 0.0
window-app BRD4161A (read only) 718304 718336 32 0.0
(read/write) 113572 113572 0 0.0
.bss 111852 111860 8 0.0
.data 1716 1712 -4 -0.2
.text 718296 718328 32 0.0
esp32 all-clusters-app c3devkit (read only) 876382 876474 92 0.0
(read/write) 1308944 1308960 16 0.0
.dram0.bss 59248 59264 16 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 200016 200016 0 0.0
.flash.text 876382 876474 92 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907747 907779 32 0.0
(read/write) 428724 428736 12 0.0
.dram0.bss 61744 61760 16 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208732 208728 -4 -0.0
.flash.text 907747 907779 32 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701716 60 0.0
.bss 78688 78688 0 0.0
.data 1900 1896 -4 -0.2
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593664 52 0.0
.bss 69172 69180 8 0.0
.data 1864 1860 -4 -0.2
.text 516776 516824 48 0.0
shell k32w061+debug (read/write) 425252 425336 84 0.0
.bss 63256 63264 8 0.0
.data 672 668 -4 -0.6
.text 359620 359700 80 0.0
linux all-clusters-app debug (read only) 1655073 1655153 80 0.0
(read/write) 119104 119136 32 0.0
.bss 51376 51408 32 0.1
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138069 0 0.0
.text 1384738 1384818 80 0.0
bridge-app debug+rpc (read only) 1283341 1283421 80 0.0
(read/write) 85160 85192 32 0.0
.bss 51856 51888 32 0.1
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111044 0 0.0
.text 1076981 1077061 80 0.0
chip-tool debug (read only) 4266229 4266293 64 0.0
(read/write) 122176 122208 32 0.0
.bss 17680 17712 32 0.2
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 214704 0 0.0
.text 3788725 3788789 64 0.0
lighting-app debug+rpc (read only) 1542281 1542361 80 0.0
(read/write) 102000 102032 32 0.0
.bss 41208 41240 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129169 0 0.0
.text 1280658 1280738 80 0.0
ota-provider-app debug (read only) 1239849 1239929 80 0.0
(read/write) 67872 67904 32 0.0
.bss 37440 37472 32 0.1
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111208 0 0.0
.text 1032466 1032546 80 0.0
ota-requestor-app debug (read only) 1301465 1301545 80 0.0
(read/write) 76616 76648 32 0.0
.bss 45216 45248 32 0.1
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 127424 0 0.0
.text 1076226 1076306 80 0.0
shell debug (read only) 787153 787217 64 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608098 608162 64 0.0
tv-app debug (read only) 1774929 1775041 112 0.0
(read/write) 289624 289656 32 0.0
.bss 223280 223312 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 154488 0 0.0
.text 1478178 1478290 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291400 2291464 64 0.0
.bss 180620 180620 0 0.0
.data 5192 5184 -8 -0.2
.heap 850632 850640 8 0.0
.text 1254000 1254064 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275608 2275736 128 0.0
.bss 172820 172820 0 0.0
.data 5568 5560 -8 -0.1
.heap 858056 858064 8 0.0
.text 1238208 1238336 128 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253328 2253392 64 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215928 1215992 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2049040 64 0.0
.bss 156208 156208 0 0.0
.data 4968 4960 -8 -0.2
.heap 875272 875280 8 0.0
.text 1011576 1011640 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 863583 48 0.0
bss 112132 112136 4 0.0
rodata 97816 97816 0 0.0
text 577960 578016 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 824363 824411 48 0.0
bss 108372 108376 4 0.0
rodata 88596 88596 0 0.0
text 551136 551192 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788526 788622 96 0.0
bss 113504 113508 4 0.0
rodata 93056 93056 0 0.0
text 507428 507484 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840211 840291 80 0.0
bss 111168 111172 4 0.0
rodata 94172 94172 0 0.0
text 559444 559496 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765506 765586 80 0.0
bss 112576 112580 4 0.0
rodata 89476 89476 0 0.0
text 489004 489056 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 844959 48 0.0
bss 111304 111308 4 0.0
rodata 95416 95416 0 0.0
text 562656 562708 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840279 80 0.0
bss 111200 111204 4 0.0
rodata 94192 94192 0 0.0
text 559288 559340 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776499 64 0.0
bss 109072 109076 4 0.0
rodata 72536 72536 0 0.0
text 520236 520296 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691538 48 0.0
bss 110056 110060 4 0.0
rodata 67180 67180 0 0.0
text 440848 440896 48 0.0
p6 lock-app default (read/write) 2169744 2169792 48 0.0
.bss 67168 67176 8 0.0
.data 2416 2408 -8 -0.3
.heap 963760 963760 0 0.0
.text 1128008 1128056 48 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491272 48 0.0
(read/write) 114144 114140 -4 -0.0
.bss 51288 51288 0 0.0
.data 1000 996 -4 -0.4
.text 485904 485952 48 0.0
lock-app qpg6100+debug (read only) 467556 467604 48 0.0
(read/write) 114140 114144 4 0.0
.bss 50240 50240 0 0.0
.data 956 952 -4 -0.4
.text 462236 462284 48 0.0
persistent-storage-app qpg6100+debug (read only) 155236 152620 -2616 -1.7
(read/write) 114140 114140 0 0.0
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 149916 147300 -2616 -1.7
telink lighting-app tlsr9518adk80d (read/write) 665202 665298 96 0.0
bss 69944 69952 8 0.0
noinit 33216 33216 0 0.0
text 458454 458550 96 0.0

kpschoedel
kpschoedel requested changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@kpschoedel kpschoedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to retain a straightforward way to mock System::Layer.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11184: Size comparison from 3947eba to 72f9faa

Increases (5 builds for k32w, p6, telink)
platform target config section 3947eba 72f9faa change % change
k32w lighting-app k32w061+se05x+release (read/write) 699128 699172 44 0.0
.text 613708 613756 48 0.0
lock-app k32w061+debug (read/write) 591432 591484 52 0.0
.bss 68220 68228 8 0.0
.text 515548 515596 48 0.0
shell k32w061+debug (read/write) 424988 425072 84 0.0
.bss 63280 63288 8 0.0
.text 359332 359412 80 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.bss 66216 66224 8 0.0
.text 1126136 1126200 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662994 104 0.0
bss 68992 69000 8 0.0
text 458036 458132 96 0.0
Decreases (4 builds for k32w, p6)
platform target config section 3947eba 72f9faa change % change
k32w lighting-app k32w061+se05x+release .data 1900 1896 -4 -0.2
lock-app k32w061+debug .data 1864 1860 -4 -0.2
shell k32w061+debug .data 672 668 -4 -0.6
p6 lock-app default .data 2416 2408 -8 -0.3
Full report (5 builds for k32w, p6, telink)
platform target config section 3947eba 72f9faa change % change
k32w lighting-app k32w061+se05x+release (read/write) 699128 699172 44 0.0
.bss 77720 77720 0 0.0
.data 1900 1896 -4 -0.2
.text 613708 613756 48 0.0
lock-app k32w061+debug (read/write) 591432 591484 52 0.0
.bss 68220 68228 8 0.0
.data 1864 1860 -4 -0.2
.text 515548 515596 48 0.0
shell k32w061+debug (read/write) 424988 425072 84 0.0
.bss 63280 63288 8 0.0
.data 672 668 -4 -0.6
.text 359332 359412 80 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.bss 66216 66224 8 0.0
.data 2416 2408 -8 -0.3
.heap 964712 964712 0 0.0
.text 1126136 1126200 64 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662994 104 0.0
bss 68992 69000 8 0.0
noinit 33216 33216 0 0.0
text 458036 458132 96 0.0

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11184: Size comparison from 3947eba to 24c0f2b

Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3947eba 24c0f2b change % change
efr32 lighting-app BRD4161A (read only) 736636 736684 48 0.0
(read/write) 114476 114480 4 0.0
.bss 112724 112732 8 0.0
.text 736628 736676 48 0.0
BRD4161A+rpc (read only) 724076 724108 32 0.0
(read/write) 131080 131084 4 0.0
.bss 129228 129236 8 0.0
.text 724068 724100 32 0.0
lock-app BRD4161A (read only) 715932 715980 48 0.0
(read/write) 112292 112296 4 0.0
.bss 110580 110588 8 0.0
.text 715924 715972 48 0.0
window-app BRD4161A (read only) 716836 716884 48 0.0
(read/write) 112616 112620 4 0.0
.bss 110900 110908 8 0.0
.text 716828 716876 48 0.0
esp32 all-clusters-app c3devkit (read only) 880562 880654 92 0.0
(read/write) 1307800 1307816 16 0.0
.dram0.bss 58456 58472 16 0.0
.flash.text 880562 880654 92 0.0
m5stack (read only) 911375 911515 140 0.0
(read/write) 427560 427572 12 0.0
.dram0.bss 60952 60968 16 0.0
.flash.text 911375 911515 140 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699172 44 0.0
.text 613708 613756 48 0.0
lock-app k32w061+debug (read/write) 591432 591484 52 0.0
.bss 68220 68228 8 0.0
.text 515548 515596 48 0.0
shell k32w061+debug (read/write) 424988 425072 84 0.0
.bss 63280 63288 8 0.0
.text 359332 359412 80 0.0
linux all-clusters-app debug (read only) 1687001 1687113 112 0.0
(read/write) 119024 119056 32 0.0
.bss 50640 50672 32 0.1
.text 1415874 1415986 112 0.0
bridge-app debug+rpc (read only) 1281957 1282069 112 0.0
(read/write) 84136 84168 32 0.0
.bss 50800 50832 32 0.1
.text 1076693 1076805 112 0.0
chip-tool debug (read only) 4314925 4315021 96 0.0
(read/write) 123648 123680 32 0.0
.bss 17712 17744 32 0.2
.text 3831621 3831717 96 0.0
lighting-app debug+rpc (read only) 1540865 1540977 112 0.0
(read/write) 101008 101040 32 0.0
.bss 40184 40216 32 0.1
.text 1280370 1280482 112 0.0
ota-provider-app debug (read only) 1239033 1239145 112 0.0
(read/write) 67104 67136 32 0.0
.bss 36640 36672 32 0.1
.text 1032498 1032610 112 0.0
ota-requestor-app debug (read only) 1302033 1302145 112 0.0
(read/write) 76360 76392 32 0.0
.bss 44896 44928 32 0.1
.text 1077170 1077282 112 0.0
shell debug (read only) 786145 786257 112 0.0
.text 607186 607298 112 0.0
tv-app debug (read only) 1773337 1773465 128 0.0
(read/write) 288600 288632 32 0.0
.bss 222224 222256 32 0.0
.text 1477682 1477810 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2295016 64 0.0
.heap 851400 851408 8 0.0
.text 1257552 1257616 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274400 64 0.0
.heap 859008 859016 8 0.0
.text 1236936 1237000 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2252120 64 0.0
.text 1214656 1214720 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048656 2048720 64 0.0
.heap 875248 875256 8 0.0
.text 1011256 1011320 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861331 64 0.0
bss 111180 111184 4 0.0
text 577612 577668 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822175 80 0.0
bss 107424 107428 4 0.0
text 550784 550840 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786354 48 0.0
bss 112556 112560 4 0.0
text 507080 507136 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838023 48 0.0
bss 110216 110220 4 0.0
text 559092 559144 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763318 48 0.0
bss 111628 111632 4 0.0
text 488652 488704 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842691 48 0.0
bss 110352 110356 4 0.0
text 562300 562352 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837995 48 0.0
bss 110252 110256 4 0.0
text 558932 558984 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776227 48 0.0
bss 109096 109100 4 0.0
text 519936 519996 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691266 64 0.0
bss 110080 110084 4 0.0
text 440548 440596 48 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.bss 66216 66224 8 0.0
.text 1126136 1126200 64 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490548 48 0.0
.text 485180 485228 48 0.0
lock-app qpg6100+debug (read only) 466844 466892 48 0.0
(read/write) 114140 114144 4 0.0
.text 461524 461572 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662994 104 0.0
bss 68992 69000 8 0.0
text 458036 458132 96 0.0
Decreases (15 builds for efr32, esp32, k32w, mbed, p6, qpg)
platform target config section 3947eba 24c0f2b change % change
efr32 lighting-app BRD4161A .data 1752 1748 -4 -0.2
BRD4161A+rpc .data 1852 1848 -4 -0.2
lock-app BRD4161A .data 1712 1708 -4 -0.2
window-app BRD4161A .data 1716 1712 -4 -0.2
esp32 all-clusters-app m5stack .flash.rodata 208344 208340 -4 -0.0
k32w lighting-app k32w061+se05x+release .data 1900 1896 -4 -0.2
lock-app k32w061+debug .data 1864 1860 -4 -0.2
shell k32w061+debug .data 672 668 -4 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .data 5216 5208 -8 -0.2
lighting-app CY8CPROTO_062_4343W+release .data 5568 5560 -8 -0.1
shell CY8CPROTO_062_4343W+release .data 4968 4960 -8 -0.2
p6 lock-app default .data 2416 2408 -8 -0.3
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
.data 1000 996 -4 -0.4
lock-app qpg6100+debug .data 956 952 -4 -0.4
persistent-storage-app qpg6100+debug (read only) 155820 153204 -2616 -1.7
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 150500 147884 -2616 -1.7
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3947eba 24c0f2b change % change
efr32 lighting-app BRD4161A (read only) 736636 736684 48 0.0
(read/write) 114476 114480 4 0.0
.bss 112724 112732 8 0.0
.data 1752 1748 -4 -0.2
.text 736628 736676 48 0.0
BRD4161A+rpc (read only) 724076 724108 32 0.0
(read/write) 131080 131084 4 0.0
.bss 129228 129236 8 0.0
.data 1852 1848 -4 -0.2
.text 724068 724100 32 0.0
lock-app BRD4161A (read only) 715932 715980 48 0.0
(read/write) 112292 112296 4 0.0
.bss 110580 110588 8 0.0
.data 1712 1708 -4 -0.2
.text 715924 715972 48 0.0
window-app BRD4161A (read only) 716836 716884 48 0.0
(read/write) 112616 112620 4 0.0
.bss 110900 110908 8 0.0
.data 1716 1712 -4 -0.2
.text 716828 716876 48 0.0
esp32 all-clusters-app c3devkit (read only) 880562 880654 92 0.0
(read/write) 1307800 1307816 16 0.0
.dram0.bss 58456 58472 16 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199640 0 0.0
.flash.text 880562 880654 92 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911375 911515 140 0.0
(read/write) 427560 427572 12 0.0
.dram0.bss 60952 60968 16 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208340 -4 -0.0
.flash.text 911375 911515 140 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699172 44 0.0
.bss 77720 77720 0 0.0
.data 1900 1896 -4 -0.2
.text 613708 613756 48 0.0
lock-app k32w061+debug (read/write) 591432 591484 52 0.0
.bss 68220 68228 8 0.0
.data 1864 1860 -4 -0.2
.text 515548 515596 48 0.0
shell k32w061+debug (read/write) 424988 425072 84 0.0
.bss 63280 63288 8 0.0
.data 672 668 -4 -0.6
.text 359332 359412 80 0.0
linux all-clusters-app debug (read only) 1687001 1687113 112 0.0
(read/write) 119024 119056 32 0.0
.bss 50640 50672 32 0.1
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138069 0 0.0
.text 1415874 1415986 112 0.0
bridge-app debug+rpc (read only) 1281957 1282069 112 0.0
(read/write) 84136 84168 32 0.0
.bss 50800 50832 32 0.1
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076805 112 0.0
chip-tool debug (read only) 4314925 4315021 96 0.0
(read/write) 123648 123680 32 0.0
.bss 17712 17744 32 0.2
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3831717 96 0.0
lighting-app debug+rpc (read only) 1540865 1540977 112 0.0
(read/write) 101008 101040 32 0.0
.bss 40184 40216 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280482 112 0.0
ota-provider-app debug (read only) 1239033 1239145 112 0.0
(read/write) 67104 67136 32 0.0
.bss 36640 36672 32 0.1
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110408 0 0.0
.text 1032498 1032610 112 0.0
ota-requestor-app debug (read only) 1302033 1302145 112 0.0
(read/write) 76360 76392 32 0.0
.bss 44896 44928 32 0.1
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127072 0 0.0
.text 1077170 1077282 112 0.0
shell debug (read only) 786145 786257 112 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607298 112 0.0
tv-app debug (read only) 1773337 1773465 128 0.0
(read/write) 288600 288632 32 0.0
.bss 222224 222256 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153464 0 0.0
.text 1477682 1477810 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2295016 64 0.0
.bss 179828 179828 0 0.0
.data 5216 5208 -8 -0.2
.heap 851400 851408 8 0.0
.text 1257552 1257616 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274400 64 0.0
.bss 171868 171868 0 0.0
.data 5568 5560 -8 -0.1
.heap 859008 859016 8 0.0
.text 1236936 1237000 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252120 64 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214720 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048720 64 0.0
.bss 156232 156232 0 0.0
.data 4968 4960 -8 -0.2
.heap 875248 875256 8 0.0
.text 1011256 1011320 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861331 64 0.0
bss 111180 111184 4 0.0
rodata 96860 96860 0 0.0
text 577612 577668 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822175 80 0.0
bss 107424 107428 4 0.0
rodata 87640 87640 0 0.0
text 550784 550840 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786354 48 0.0
bss 112556 112560 4 0.0
rodata 92100 92100 0 0.0
text 507080 507136 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838023 48 0.0
bss 110216 110220 4 0.0
rodata 93216 93216 0 0.0
text 559092 559144 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763318 48 0.0
bss 111628 111632 4 0.0
rodata 88520 88520 0 0.0
text 488652 488704 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842691 48 0.0
bss 110352 110356 4 0.0
rodata 94460 94460 0 0.0
text 562300 562352 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837995 48 0.0
bss 110252 110256 4 0.0
rodata 93236 93236 0 0.0
text 558932 558984 52 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776227 48 0.0
bss 109096 109100 4 0.0
rodata 72536 72536 0 0.0
text 519936 519996 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691266 64 0.0
bss 110080 110084 4 0.0
rodata 67180 67180 0 0.0
text 440548 440596 48 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.bss 66216 66224 8 0.0
.data 2416 2408 -8 -0.3
.heap 964712 964712 0 0.0
.text 1126136 1126200 64 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490548 48 0.0
(read/write) 114144 114140 -4 -0.0
.bss 50336 50336 0 0.0
.data 1000 996 -4 -0.4
.text 485180 485228 48 0.0
lock-app qpg6100+debug (read only) 466844 466892 48 0.0
(read/write) 114140 114144 4 0.0
.bss 49288 49288 0 0.0
.data 956 952 -4 -0.4
.text 461524 461572 48 0.0
persistent-storage-app qpg6100+debug (read only) 155820 153204 -2616 -1.7
(read/write) 114140 114140 0 0.0
.bss 27752 18328 -9424 -34.0
.data 372 356 -16 -4.3
.text 150500 147884 -2616 -1.7
telink lighting-app tlsr9518adk80d (read/write) 662890 662994 104 0.0
bss 68992 69000 8 0.0
noinit 33216 33216 0 0.0
text 458036 458132 96 0.0

mspang
mspang reviewed Nov 2, 2021
View reviewed changes
src/platform/Globals.cpp Outdated Show resolved Hide resolved
@kghost kghost merged commit 979f780 into project-chip:master Nov 2, 2021
@kghost kghost deleted the no-global branch November 2, 2021 21:22
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
InetLayer/SystemLayer use C++11 singleton patter instead of global va…
41ce732 
…riable (project-chip#11184)

* InetLayer/SystemLayer use C++11 singleton patter instead of global variable

* Add mock for SystemLayer

* Remove NDEBUG guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang left review comments

@msandstedt msandstedt msandstedt approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple woody-apple approved these changes

@kpschoedel kpschoedel kpschoedel approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples lib platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kghost @mspang @msandstedt @emargolis @woody-apple @kpschoedel