Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run arm64 AndroidStudio build in Android CI #11103

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Only run arm64 AndroidStudio build in Android CI #11103

merged 1 commit into from
Oct 28, 2021

Conversation

austinh0
Copy link
Contributor

Problem

  • Adding the AndroidStudio IDE build to Android CI significantly increased CI time, since the current android-androidstudio-chip-tool target will build arm, arm64, x86, and x64 targets.

Change overview

  • Split singular androidstudio target into different targets per-ABI: android-androidstudio-$ABI-chip-tool
    • Add Gradle property which sets ndk { abiFilters }
  • Exclusively build android-androidstudio-arm64-chip-tool in Android CI. In my fork, this cut CI time down to 40min.

Testing

  • Ran all android-androidstudio-* targets locally
  • CI verifies arm64 target and other android targets

@boring-cyborg boring-cyborg bot added android documentation Improvements or additions to documentation github scripts workflows labels Oct 28, 2021
@github-actions
Copy link

github-actions bot commented Oct 28, 2021 •
edited
Loading

PR #11103: Size comparison from c747af9 to 6690e57

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c747af9 6690e57 change % change
efr32 lighting-app BRD4161A (read only) 737316 737316 0 0.0
(read/write) 115428 115428 0 0.0
.bss 113676 113676 0 0.0
.data 1752 1752 0 0.0
.text 737308 737308 0 0.0
BRD4161A+rpc (read only) 724756 724756 0 0.0
(read/write) 132032 132032 0 0.0
.bss 130180 130180 0 0.0
.data 1852 1852 0 0.0
.text 724748 724748 0 0.0
lock-app BRD4161A (read only) 716612 716612 0 0.0
(read/write) 113244 113244 0 0.0
.bss 111532 111532 0 0.0
.data 1712 1712 0 0.0
.text 716604 716604 0 0.0
window-app BRD4161A (read only) 717516 717516 0 0.0
(read/write) 113568 113568 0 0.0
.bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 717508 717508 0 0.0
esp32 all-clusters-app c3devkit (read only) 875926 875926 0 0.0
(read/write) 1308672 1308672 0 0.0
.dram0.bss 59248 59248 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199744 199744 0 0.0
.flash.text 875926 875926 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907183 907183 0 0.0
(read/write) 428460 428460 0 0.0
.dram0.bss 61744 61744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208468 208468 0 0.0
.flash.text 907183 907183 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700976 700976 0 0.0
.bss 78688 78688 0 0.0
.data 1900 1900 0 0.0
.text 614588 614588 0 0.0
lock-app k32w061+debug (read/write) 592932 592932 0 0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516096 516096 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1649345 1649345 0 0.0
(read/write) 119136 119136 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137813 137813 0 0.0
.text 1379218 1379218 0 0.0
bridge-app debug+rpc (read only) 1278261 1278261 0 0.0
(read/write) 85192 85192 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110780 110780 0 0.0
.text 1072117 1072117 0 0.0
chip-tool debug (read only) 4270421 4270421 0 0.0
(read/write) 122208 122208 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 97536 97536 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214224 214224 0 0.0
.text 3793349 3793349 0 0.0
lighting-app debug+rpc (read only) 1537209 1537209 0 0.0
(read/write) 102032 102032 0 0.0
.bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128913 128913 0 0.0
.text 1275794 1275794 0 0.0
ota-provider-app debug (read only) 1239033 1239033 0 0.0
(read/write) 67904 67904 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111080 111080 0 0.0
.text 1031730 1031730 0 0.0
ota-requestor-app debug (read only) 1301385 1301385 0 0.0
(read/write) 76648 76648 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25496 25496 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127936 127936 0 0.0
.text 1075586 1075586 0 0.0
shell debug (read only) 787361 787361 0 0.0
(read/write) 57792 57792 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36880 36880 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608258 608258 0 0.0
tv-app debug (read only) 1770561 1770561 0 0.0
(read/write) 289656 289656 0 0.0
.bss 223280 223280 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154904 154904 0 0.0
.text 1473346 1473346 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290600 2290600 0 0.0
.bss 180620 180620 0 0.0
.data 5192 5192 0 0.0
.heap 850632 850632 0 0.0
.text 1253200 1253200 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274928 2274928 0 0.0
.bss 172820 172820 0 0.0
.data 5568 5568 0 0.0
.heap 858056 858056 0 0.0
.text 1237528 1237528 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252648 2252648 0 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215248 1215248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048984 2048984 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011584 1011584 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862863 862863 0 0.0
bss 112132 112132 0 0.0
rodata 97528 97528 0 0.0
text 577576 577576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823687 823687 0 0.0
bss 108372 108372 0 0.0
rodata 88304 88304 0 0.0
text 550752 550752 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787854 787854 0 0.0
bss 113504 113504 0 0.0
rodata 92768 92768 0 0.0
text 507044 507044 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839535 839535 0 0.0
bss 111168 111168 0 0.0
rodata 93880 93880 0 0.0
text 559060 559060 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764834 764834 0 0.0
bss 112576 112576 0 0.0
rodata 89188 89188 0 0.0
text 488620 488620 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844239 844239 0 0.0
bss 111304 111304 0 0.0
rodata 95128 95128 0 0.0
text 562272 562272 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839527 839527 0 0.0
bss 111200 111200 0 0.0
rodata 93904 93904 0 0.0
text 558904 558904 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2168936 2168936 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1127200 1127200 0 0.0
qpg lighting-app qpg6100+debug (read only) 491192 491192 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52400 52400 0 0.0
.data 1000 1000 0 0.0
.text 485872 485872 0 0.0
lock-app qpg6100+debug (read only) 467532 467532 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51352 51352 0 0.0
.data 956 956 0 0.0
.text 462212 462212 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664466 664466 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458034 458034 0 0.0

@andy31415
Copy link
Contributor

Fast track (1 day): change affects build instructions only and is validated by CI. Changes are platform specific (android) and made by platform owner.

@woody-apple woody-apple merged commit ccda2f7 into project-chip:master Oct 28, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@austinh0
Split androidstudio target into each ABI, and add only arm64 to CI. (p…
139fbba 
…roject-chip#11103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
android documentation Improvements or additions to documentation fast track github review - pending scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinh0 @andy31415 @bzbarsky-apple @woody-apple