Fix build failure with chip_enable_wifi = false #10869

yufengwangca · 2021-10-22T19:18:14Z

Problem

What is being fixed? Examples:

Build failed with 'chip_enable_wifi=false chip_enable_ble=false chip_enable_openthread=false'

yufengw@yufengw-SEi:~/Workspace/connectedhomeip$ ninja -C out/debug
ninja: Entering directory `out/debug'
[1211/1261] ld ./chip-shell
FAILED: chip-shell chip-shell.map 
g++ -O0 -fPIC -Werror -Wl,--fatal-warnings -Wl,-z,defs -fdiagnostics-color -pie -Wl,-Map,./chip-shell.map -Wl,--gc-sections @./chip-shell.rsp -o ./chip-shell
/usr/bin/ld: obj/src/lib/shell/shell_core.Engine.cpp.o: in function `chip::shell::Engine::RegisterDefaultCommands()':
/home/yufengw/Workspace/connectedhomeip/out/debug/../../src/lib/shell/Engine.cpp:104: undefined reference to `chip::shell::RegisterWiFiCommands()'
collect2: error: ld returned 1 exit status
[1220/1261] ld ./chip-tool
ninja: build stopped: subcommand failed

Fixes Linux build failure when CHIP_DEVICE_CONFIG_ENABLE_WPA disabled #10817

Change overview

Fix build failure with chip_enable_wifi = false

Testing

How was this tested? (at least one bullet point required)

source scripts/activate.sh
gn gen out/debug --args='chip_enable_wifi=false'
ninja -C out/debug

yufengwangca · 2021-10-22T19:22:06Z

Can not repo this failure with CHIP_DEVICE_CONFIG_ENABLE_WPA disabled, confirmed with Zach Michel, we should see the failure with chip_enable_wifi = false on linux

github-actions · 2021-10-22T20:54:15Z

PR #10869: Size comparison from 685e556 to a0eab46

35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`685e556`	`a0eab46`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	784320	784320
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	763528	763528
	window-app	BRD4161A	.bss	116204	116204
			.data	1764	1764
			.text	764356	764356
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	764028	764028
esp32	all-clusters-app	c3devkit	.dram0.bss	60304	60304
			.dram0.data	16440	16440
			.flash.rodata	199968	199968
			.flash.text	874354	874354
			.iram0.text	57564	57564
		m5stack	.dram0.bss	62808	62808
			.dram0.data	32084	32084
			.flash.rodata	208704	208704
			.flash.text	905307	905307
			.iram0.text	125115	125115
k32w	lock-app	k32w061+debug	.bss	69076	69076
			.data	1864	1864
			.text	516108	516108
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	359480	359480
	lighting-app	k32w061+se05x+release	.bss	78592	78592
			.data	1900	1900
			.text	614808	614808
linux	all-clusters-app	debug	.bss	52208	52208
			.data	978	978
			.data.rel.ro	60448	60448
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	512	512
			.rodata	136469	136469
			.text	1352642	1352642
	chip-tool	debug	.bss	17712	17712
			.data	1584	1584
			.data.rel.ro	93888	93888
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	416	416
			.rodata	194308	194308
			.text	3510213	3510213
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	440	440
			.rodata	110312	110312
			.text	1022578	1022578
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	25800	25800
			.dynamic	592	592
			.got	4144	4144
			.init	27	27
			.init_array	512	512
			.rodata	128392	128392
			.text	`1141106`	`1141106`
	shell	debug	.bss	16136	16136
			.data	242	242
			.data.rel.ro	36496	36496
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	336	336
			.rodata	76463	76463
			.text	598242	598242
	tv-app	debug	.bss	216592	216592
			.data	2032	2032
			.data.rel.ro	57408	57408
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	608	608
			.rodata	152936	152936
			.text	1452994	1452994
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	27112	27112
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	400	400
			.rodata	110748	110748
			.text	`1063461`	`1063461`
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	53808	53808
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	127921	127921
			.text	1261410	1261410
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172108	172108
			.data	5464	5464
			.heap	858872	858872
			.text	1220112	1220112
	lock-app	CY8CPROTO_062_4343W+release	.bss	171028	171028
			.data	5432	5432
			.heap	859984	859984
			.text	1198072	1198072
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113184	113184
			rodata	98100	98100
			text	577104	577104
	lock-app	nrf52840dk_nrf52840	bss	112256	112256
			rodata	94500	94500
			text	558592	558592
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824
			rodata	45776	45776
			text	339456	339456
	pump-app	nrf52840dk_nrf52840	bss	112316	112316
			rodata	95396	95396
			text	561744	561744
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252
			rodata	94476	94476
			text	558384	558384
	shell	nrf52840dk_nrf52840	bss	109072	109072
			rodata	72524	72524
			text	520208	520208
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109424	109424
			rodata	88876	88876
			text	550296	550296
		nrf5340dk_nrf5340_cpuapp	bss	114556	114556
			rodata	93340	93340
			text	506572	506572
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113628	113628
			rodata	89760	89760
			text	488056	488056
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056
			rodata	67168	67168
			text	440816	440816
p6	lock-app	default	.bss	68224	68224
			.data	2416	2416
			.heap	962704	962704
			.text	1126776	1126776
qpg	lighting-app	qpg6100+debug	.bss	53472	53472
			.data	1004	1004
			.text	486056	486056
	lock-app	qpg6100+debug	.bss	52416	52416
			.data	960	960
			.text	462204	462204
	persistent-storage-app	qpg6100+debug	.bss	27752	27752
			.data	372	372
			.text	149896	149896
telink	lighting-app	tlsr9518adk80d	bss	71004	71004
			noinit	33216	33216
			text	457612	457612

z-michel

Verified these changes fixed the build failure.

woody-apple · 2021-10-22T21:32:28Z

@yufengwangca Can we please add a test/build to confirm this doesn't regress again?

yufengwangca · 2021-10-22T21:59:49Z

@yufengwangca Can we please add a test/build to confirm this doesn't regress again?

Can we please add a test/build to confirm this doesn't regress again?

Sure, I am Out of home today, will add the test build next week with a follow-up PR #10878

github-actions · 2021-10-22T22:12:14Z

PR #10869: Size comparison from 8e62dd6 to 468891b

23 builds (for efr32, k32w, linux, mbed, p6, qpg, telink)

platform	target	config	section	`8e62dd6`	`468891b`
efr32	lighting-app	BRD4161A	.bss	114732	114732
			.data	1752	1752
			.text	736780	736780
	lock-app	BRD4161A	.bss	112588	112588
			.data	1712	1712
			.text	715980	715980
	window-app	BRD4161A	.bss	112900	112900
			.data	1716	1716
			.text	716824	716824
	lighting-app	BRD4161A+rpc	.bss	131236	131236
			.data	1852	1852
			.text	724204	724204
k32w	lock-app	k32w061+debug	.bss	70244	70244
			.data	1864	1864
			.text	516076	516076
	shell	k32w061+debug	.bss	63256	63256
			.data	672	672
			.text	359544	359544
	lighting-app	k32w061+se05x+release	.bss	79760	79760
			.data	1900	1900
			.text	614792	614792
linux	all-clusters-app	debug	.bss	52208	52208
			.data	978	978
			.data.rel.ro	60448	60448
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	512	512
			.rodata	136469	136469
			.text	1353122	1353122
	chip-tool	debug	.bss	17712	17712
			.data	1584	1584
			.data.rel.ro	93888	93888
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	416	416
			.rodata	194308	194308
			.text	3510757	3510757
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	440	440
			.rodata	110312	110312
			.text	1023042	1023042
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	25800	25800
			.dynamic	592	592
			.got	4144	4144
			.init	27	27
			.init_array	512	512
			.rodata	128360	128360
			.text	`1141650`	`1141650`
	shell	debug	.bss	16136	16136
			.data	242	242
			.data.rel.ro	36496	36496
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	336	336
			.rodata	76463	76463
			.text	598722	598722
	tv-app	debug	.bss	216592	216592
			.data	2032	2032
			.data.rel.ro	57408	57408
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	608	608
			.rodata	152936	152936
			.text	1453538	1453538
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	27112	27112
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	400	400
			.rodata	110748	110748
			.text	1063925	1063925
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	53808	53808
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	127921	127921
			.text	1261874	1261874
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172108	172108
			.data	5464	5464
			.heap	858872	858872
			.text	1220112	1220112
	lock-app	CY8CPROTO_062_4343W+release	.bss	171028	171028
			.data	5432	5432
			.heap	859984	859984
			.text	1198008	1198008
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064
p6	lock-app	default	.bss	68224	68224
			.data	2416	2416
			.heap	962704	962704
			.text	1127016	1127016
qpg	lighting-app	qpg6100+debug	.bss	53472	53472
			.data	1004	1004
			.text	486032	486032
	lock-app	qpg6100+debug	.bss	52416	52416
			.data	960	960
			.text	462188	462188
	persistent-storage-app	qpg6100+debug	.bss	27752	27752
			.data	372	372
			.text	149896	149896
telink	lighting-app	tlsr9518adk80d	bss	71004	71004
			noinit	33216	33216
			text	457664	457664

12 builds (for esp32, nrfconnect)

platform	target	config	section	`8e62dd6`	`468891b`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60304	60304	0
			.dram0.data	16440	16440	0
			.flash.rodata	199968	199968	0
			.flash.text	874330	874330	0
			.iram0.text	57564	57564	0
		m5stack	.dram0.bss	62808	62808	0
			.dram0.data	32084	32084	0
			.flash.rodata	208704	208704	0
			.flash.text	905351	905439	88
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113184	113184	0
			rodata	98100	98100	0
			text	577196	577196	0
	lock-app	nrf52840dk_nrf52840	bss	112256	112256	0
			rodata	94500	94500	0
			text	558684	558684	0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0
			rodata	45776	45776	0
			text	339456	339456	0
	pump-app	nrf52840dk_nrf52840	bss	112316	112316	0
			rodata	95396	95396	0
			text	561836	561836	0
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252	0
			rodata	94476	94476	0
			text	558476	558476	0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0
			rodata	72524	72524	0
			text	520300	520300	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109424	109424	0
			rodata	88876	88876	0
			text	550388	550388	0
		nrf5340dk_nrf5340_cpuapp	bss	114556	114556	0
			rodata	93340	93340	0
			text	506664	506664	0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113628	113628	0
			rodata	89760	89760	0
			text	488148	488148	0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0
			rodata	67168	67168	0
			text	440908	440908	0

boring-cyborg bot added linux platform labels Oct 22, 2021

pullapprove bot requested review from woody-apple and yunhanw-google October 22, 2021 19:19

pullapprove bot added the review - pending label Oct 22, 2021

saurabhst approved these changes Oct 22, 2021

View reviewed changes

woody-apple approved these changes Oct 22, 2021

View reviewed changes

Fix build failure with chip_enable_wifi = false

468891b

z-michel approved these changes Oct 22, 2021

View reviewed changes

yufengwangca added the hotfix urgent fix needed, can bypass review label Oct 22, 2021

yufengwangca mentioned this pull request Oct 22, 2021

Add test build with with 'chip_enable_wifi=false chip_enable_ble=false chip_enable_openthread=false' #10878

Closed

woody-apple merged commit b1fcb67 into project-chip:master Oct 22, 2021

yufengwangca deleted the pr/linux/wpa branch October 25, 2021 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build failure with chip_enable_wifi = false #10869

Fix build failure with chip_enable_wifi = false #10869

yufengwangca commented Oct 22, 2021 •

edited

Loading

yufengwangca commented Oct 22, 2021

github-actions bot commented Oct 22, 2021

z-michel left a comment

woody-apple commented Oct 22, 2021

yufengwangca commented Oct 22, 2021

github-actions bot commented Oct 22, 2021 •

edited

Loading

Fix build failure with chip_enable_wifi = false #10869

Fix build failure with chip_enable_wifi = false #10869

Conversation

yufengwangca commented Oct 22, 2021 • edited Loading

Problem

Change overview

Testing

yufengwangca commented Oct 22, 2021

github-actions bot commented Oct 22, 2021

z-michel left a comment

Choose a reason for hiding this comment

woody-apple commented Oct 22, 2021

yufengwangca commented Oct 22, 2021

github-actions bot commented Oct 22, 2021 • edited Loading

yufengwangca commented Oct 22, 2021 •

edited

Loading

github-actions bot commented Oct 22, 2021 •

edited

Loading