-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failure with chip_enable_wifi = false #10869
Conversation
Can not repo this failure with CHIP_DEVICE_CONFIG_ENABLE_WPA disabled, confirmed with Zach Michel, we should see the failure with chip_enable_wifi = false on linux |
PR #10869: Size comparison from 685e556 to a0eab46 35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified these changes fixed the build failure.
@yufengwangca Can we please add a test/build to confirm this doesn't regress again? |
Sure, I am Out of home today, will add the test build next week with a follow-up PR #10878 |
PR #10869: Size comparison from 8e62dd6 to 468891b 23 builds (for efr32, k32w, linux, mbed, p6, qpg, telink)
12 builds (for esp32, nrfconnect)
|
Problem
What is being fixed? Examples:
Change overview
Fix build failure with chip_enable_wifi = false
Testing
How was this tested? (at least one bullet point required)
gn gen out/debug --args='chip_enable_wifi=false'
ninja -C out/debug