Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error with ambiguous reference to ‘Messaging’ #10803

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Fix build error with ambiguous reference to ‘Messaging’ #10803

merged 1 commit into from
Oct 21, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • There is an ambiguous reference to ‘Messaging’ in app/clusters/operational-credentials-server/operational-credentials-server.cpp
../../../examples/lighting-app/linux/third_party/connectedhomeip/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp:355:9: error: reference to ‘Messaging’ is ambiguous
  355 |         Messaging::ExchangeContext * ec = commandObj->GetExchangeContext();
      |         ^~~~~~~~~
In file included from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/messaging/ExchangeMessageDispatch.h:27,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/messaging/ApplicationExchangeDispatch.h:28,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/messaging/ExchangeDelegate.h:27,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/messaging/ExchangeContext.h:31,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/app/util/af-types.h:60,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h:27,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp:26:
../../../examples/lighting-app/linux/third_party/connectedhomeip/src/messaging/Flags.h:30:11: note: candidates are: ‘namespace chip::Messaging { }’
   30 | namespace Messaging {
      |           ^~~~~~~~~
In file included from ../../../examples/lighting-app/linux/third_party/connectedhomeip/zzz_generated/app-common/app-common/zap-generated/cluster-objects.h:24,
                 from ../../../examples/lighting-app/linux/third_party/connectedhomeip/src/app/clusters/operational-credentials-server/operational-credentials-server.cpp:28:
../../../examples/lighting-app/linux/third_party/connectedhomeip/zzz_generated/app-common/app-common/zap-generated/ids/Clusters.h:316:11: note:                 ‘namespace chip::app::Clusters::Messaging { }’
  316 | namespace Messaging {
      |           ^~~~~~~~~

Change overview

Fix build error with ambiguous reference to ‘Messaging’

Testing

How was this tested? (at least one bullet point required)

  • Tested with build.gn

@boring-cyborg boring-cyborg bot added the app label Oct 21, 2021
@github-actions
Copy link

github-actions bot commented Oct 21, 2021 •
edited
Loading

PR #10803: Size comparison from ea1b443 to 6f49dce

1 build (for telink)
platform target config section ea1b443 6f49dce change % change
telink lighting-app tlsr9518adk80d bss 70992 70992 0 0.0
noinit 33216 33216 0 0.0
text 457130 457130 0 0.0
19 builds (for efr32, k32w, linux, p6, qpg)
platform target config section ea1b443 6f49dce change % change
efr32 lighting-app BRD4161A .bss 118028 118028 0 0.0
.data 1800 1800 0 0.0
.text 781632 781632 0 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 760776 760776 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 761684 761684 0 0.0
lighting-app BRD4161A+rpc .bss 131356 131356 0 0.0
.data 1852 1852 0 0.0
.text 761332 761332 0 0.0
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 514552 514552 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357288 357288 0 0.0
lighting-app k32w061+se05x+release .bss 78584 78584 0 0.0
.data 1900 1900 0 0.0
.text 613320 613320 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 59072 59072 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136117 136117 0 0.0
.text 1343490 1343490 0 0.0
chip-tool debug .bss 17520 17520 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 91984 91984 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 183524 183524 0 0.0
.text 3459445 3459445 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109960 109960 0 0.0
.text 1012322 1012322 0 0.0
ota-requestor-app debug .bss 205696 205696 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128104 128104 0 0.0
.text 1130866 1130866 0 0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71887 71887 0 0.0
.text 573250 573250 0 0.0
tv-app debug .bss 216560 216560 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 56096 56096 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152616 152616 0 0.0
.text 1444482 1444482 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110492 110492 0 0.0
.text 1052197 1052197 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127665 127665 0 0.0
.text 1252482 1252482 0 0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1125280 1125280 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 485508 485508 0 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 952 952 0 0.0
.text 461588 461588 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102628 102628 0 0.0
4 builds (for esp32, mbed)
platform target config section ea1b443 6f49dce change % change
esp32 all-clusters-app c3devkit .dram0.bss 60296 60296 0 0.0
.dram0.data 16432 16432 0 0.0
.flash.rodata 199072 199072 0 0.0
.flash.text 873126 873126 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 62800 62800 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207832 207832 0 0.0
.flash.text 904179 904267 88 0.0
.iram0.text 125115 125115 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172092 172092 0 0.0
.data 5464 5464 0 0.0
.heap 858888 858888 0 0.0
.text 1219008 1219008 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171012 171012 0 0.0
.data 5432 5432 0 0.0
.heap 860000 860000 0 0.0
.text 1196904 1196904 0 0.0
10 builds (for nrfconnect)
platform target config section ea1b443 6f49dce change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 113172 113172 0 0.0
rodata 97668 97668 0 0.0
text 576752 576752 0 0.0
lock-app nrf52840dk_nrf52840 bss 112240 112240 0 0.0
rodata 94004 94004 0 0.0
text 558240 558240 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 112308 112308 0 0.0
rodata 94988 94988 0 0.0
text 561396 561396 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 112248 112248 0 0.0
rodata 94064 94064 0 0.0
text 558032 558032 0 0.0
shell nrf52840dk_nrf52840 bss 109068 109068 0 0.0
rodata 71644 71644 0 0.0
text 518980 518980 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 109416 109416 0 0.0
rodata 88448 88448 0 0.0
text 549952 549952 0 0.0
nrf5340dk_nrf5340_cpuapp bss 114548 114548 0 0.0
rodata 92908 92908 0 0.0
text 506224 506224 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 113612 113612 0 0.0
rodata 89264 89264 0 0.0
text 487704 487704 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110052 110052 0 0.0
rodata 66288 66288 0 0.0
text 439592 439592 0 0.0

@yufengwangca yufengwangca added the hotfix urgent fix needed, can bypass review label Oct 21, 2021
@yufengwangca yufengwangca merged commit 0c16976 into project-chip:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@saurabhst saurabhst saurabhst approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app hotfix urgent fix needed, can bypass review review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yufengwangca @tcarmelveilleux @saurabhst @yunhanw-google @jmartinez-silabs