-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disparity in OnOff cluster revision #10789
Merged
woody-apple
merged 3 commits into
project-chip:master
from
jmartinez-silabs:OnOff_Revision
Oct 22, 2021
Merged
Fix disparity in OnOff cluster revision #10789
woody-apple
merged 3 commits into
project-chip:master
from
jmartinez-silabs:OnOff_Revision
Oct 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
tcarmelveilleux,
turon,
vivien-apple and
wbschiller
October 21, 2021 18:25
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
October 21, 2021 18:25
andy31415
approved these changes
Oct 21, 2021
yunhanw-google
approved these changes
Oct 21, 2021
PR #10789: Size comparison from 30f7de7 to b1d94a1 22 builds (for efr32, k32w, linux, mbed, p6, qpg, telink)
12 builds (for esp32, nrfconnect)
|
Size increase report for "nrfconnect-example-build" from 30f7de7
Full report output
|
rcasallas-silabs
approved these changes
Oct 22, 2021
selissia
approved these changes
Oct 22, 2021
saurabhst
approved these changes
Oct 22, 2021
woody-apple
approved these changes
Oct 22, 2021
@jmartinez-silabs can you resolve conflicts? |
…aturemap attribute in lighting-app and required onoff attributes in lock-app
jmartinez-silabs
force-pushed
the
OnOff_Revision
branch
from
October 22, 2021 17:15
b1d94a1
to
4aa9b18
Compare
msandstedt
approved these changes
Oct 22, 2021
Size increase report for "gn_qpg-example-build" from 3f984d7
Full report output
|
PR #10789: Size comparison from 3f984d7 to 4aa9b18 27 builds (for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some app report cluster revision of 2
The test case suite checks for cluster revision 3
Spec now defines cluster revision 4
Fixes #10657
Change overview
Update the OnOff ClusterRevision attribute to 4 for all examples using the OnOff cluster
Enable FeatureMap for Lighting app and lock-app
For lock-app enable also other required OnOff attibutes
Testing
The test suites now checks for OnOff cluster revision 4