-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move registerCommandsTests outside of the test_cluster.zapt partial as it introduce some dependencies on chip-tool built-in Commands class #10758
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_MoveRegisterCommandsTests
Oct 21, 2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it introduce some dependencies on chip-tool built-in Commands class
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
turon and
wbschiller
October 21, 2021 08:33
vivien-apple
changed the title
Chip tool move register commands tests
Move registerCommandsTests outside of the test_cluster.zapt partial as it introduce some dependencies on chip-tool built-in Commands class
Oct 21, 2021
PR #10758: Size comparison from c4a4361 to 3f52235 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
12 builds (for esp32, nrfconnect)
|
Fits the fast path label, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The signature
void registerCommandsTests(Commands & commands)
into the partial that generates tests cases introduce a dependency ontochip-tool
buit-inCommands
andCommand
objects.If some other examples wants to reuse the partial, then they need to reimplement those objects, that may not fit for their use cases.
Change overview
registerCommandsTests
fromexamples/chip-tool/templates/partials/test_cluster.zapt
toexamples/chip-tool/templates/tests-commands.zapt
. It does not change anything forchip-tool
itself while making it easier to reuse for others.Testing
Running codegen show no changes at all.